Skip to contentSkip to conversation

xfs: actually enable the swapext compat handler

PATCH In review Christoph Hellwig 3 participants 4 messages Sep 1, 2009 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: actually enable the swapext compat handler

Fix a small typo in the compat ioctl handler that cause the swapext compat handler to never be called.

fs/xfs/linux-2.6/xfs_ioctl32.c +1 -1
Index: linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c
===================================================================
@@ -619,7 +619,7 @@ xfs_file_compat_ioctl(
 	case XFS_IOC_GETVERSION_32:
 		cmd = _NATIVE_IOC(cmd, long);
 		return xfs_file_ioctl(filp, cmd, p);
-	case XFS_IOC_SWAPEXT: {
+	case XFS_IOC_SWAPEXT_32: {
 		struct xfs_swapext	  sxp;
 		struct compat_xfs_swapext __user *sxu = arg;
 

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Christoph Hellwig

Fix a small typo in the compat ioctl handler that cause the swapext compat handler to never be called.

Guilty-party: Eric Sandeen <[email protected]>

Quoted 14 lines

Index: linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c
===================================================================

fs/xfs/linux-2.6/xfs_ioctl32.c +1 -1
@@ -619,7 +619,7 @@ xfs_file_compat_ioctl(
 	case XFS_IOC_GETVERSION_32:
 		cmd = _NATIVE_IOC(cmd, long);
 		return xfs_file_ioctl(filp, cmd, p);
-	case XFS_IOC_SWAPEXT: {
+	case XFS_IOC_SWAPEXT_32: {
 		struct xfs_swapext	  sxp;
 		struct compat_xfs_swapext __user *sxu = arg;
 
Quoted 5 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
Quoted 10 lines · Eric Sandeen
Quoted 6 lines · Christoph Hellwig

Fix a small typo in the compat ioctl handler that cause the swapext compat handler to never be called.

Guilty-party: Eric Sandeen <[email protected]>

Haha, thanks. Felix, can you push this one to Linus for 2.6.31?

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by
#3 lore raw
Quoted 11 lines · Christoph Hellwig
Quoted 10 lines · Eric Sandeen
Quoted 6 lines · Christoph Hellwig

Fix a small typo in the compat ioctl handler that cause the swapext compat handler to never be called.

Guilty-party: Eric Sandeen <[email protected]>

Yep, trivial fix. Looks good.

Quoted 3 lines
Quoted 1 line

Haha, thanks. Felix, can you push this one to Linus for 2.6.31?

Sure, doing it now.

Felix

Quoted 6 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs