Skip to contentSkip to conversation

Fix coalesced interrupt reporting in IOAPIC

PATCH Applied Gleb Natapov 2 participants 2 messages Sep 3, 2009 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix coalesced interrupt reporting in IOAPIC

This bug was introduced by b4a2f5e723e4f7df46731106faf9e2405673c073

virt/kvm/ioapic.c +2 -0
index e9de458..38a2d20 100644
@@ -194,6 +194,8 @@ int kvm_ioapic_set_irq(struct kvm_ioapic *ioapic, int irq, int level)
 			if ((edge && old_irr != ioapic->irr) ||
 			    (!edge && !entry.fields.remote_irr))
 				ret = ioapic_service(ioapic, irq);
+			else
+				ret = 0; /* report coalesced interrupt */
 		}
 		trace_kvm_ioapic_set_irq(entry.bits, irq, ret == 0);
 	}

--
Gleb.

#1 lore raw
Quoted 17 lines · Gleb Natapov

This bug was introduced by b4a2f5e723e4f7df46731106faf9e2405673c073

virt/kvm/ioapic.c +2 -1
index e9de458..38a2d20 100644
@@ -194,6 +194,8 @@ int kvm_ioapic_set_irq(struct kvm_ioapic *ioapic, int irq, int level)
 			if ((edge && old_irr != ioapic->irr) ||
 			    (!edge && !entry.fields.remote_irr))
 				ret = ioapic_service(ioapic, irq);
+			else
+				ret = 0; /* report coalesced interrupt */
 		}
 		trace_kvm_ioapic_set_irq(entry.bits, irq, ret == 0);
 	}
--
Quoted 1 line

Gleb.

Applied, thanks.