ssb: Fail ssb modinit, if attach of the buses failed.

PATCH New Michael Buesch 1 participant 1 message Sep 5, 2009 Sonics silicon backplane driver (ssb)

lore

Share & tools

lore

Michael Buesch

author

2009-09-05 09:20 UTC #0 lore raw

PATCH 1/1 ssb: Fail ssb modinit, if attach of the buses failed.

SSB modinit should not succeed, if busattach failed.

Signed-off-by Michael Buesch <[email protected]>

---
 drivers/ssb/main.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

drivers/ssb/main.c +4 -2

@@ -1358,8 +1358,10 @@ static int __init ssb_modinit(void)
 	ssb_buses_lock();
 	err = ssb_attach_queued_buses();
 	ssb_buses_unlock();
-	if (err)
+	if (err) {
 		bus_unregister(&ssb_bustype);
+		goto out;
+	}
 
 	err = b43_pci_ssb_bridge_init();
 	if (err) {

@@ -1375,7 +1377,7 @@ static int __init ssb_modinit(void)
 		/* don't fail SSB init because of this */
 		err = 0;
 	}
-
+out:
 	return err;
 }
 /* ssb must be initialized after PCI but before the ssb drivers.

Signature · 1 line

Greetings, Michael.