Skip to contentSkip to conversation

be2iscsi driver

DISCUSSION Jayamohan Kallickal 3 participants 3 messages Sep 8, 2009 SCSI

lore
Share & tools
lore
#0 lore raw

Hi

This patch contains a fix for powerpc compile issue and has
been tested for compile on powerpc with allyesconfig option.

I request you to pl consider this for inclusion in the Linux Kernel.

This patch requires Mike's Patch
(commit f54b4b17046a762b80787edda3bb25e84ff0809c and
240e4e54b2b324681cda93b10e750ff9d0251b41 on
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git)
Since Mike's patches have already been applied, I am not including them here.

This patch supports blk-iopoll and is pulled from Jens Axboe's tree at

git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-2.6-block.git
blk-iopoll

The series of patches are described below:

[PATCH 1/6]: Modified scsi Layer and be2iscsi Makefile/Kconfig
to add be2iscsi

[PATCH 2/6]: This file contains all routines for Initiallization/Teardown,
registering with upper layer, IO Handling, allocation/free etc.

[PATCH 3/6]: These are the low level routines to talk to the chip for
Management commands.

[PATCH 4/6]: The iscsi hooks to interact with open-iscsi layer.

[PATCH 5/6]: The Firmware Commands that are used for Management action
like setup /tear down a connection etc.

[PATCH 6/6]: The modified MAINTAINERS file with be2iscsi added.

Thank You

Jayamohan Kallickal

---

#1 lore raw

Hi Jayamohan,

Quoted 3 lines · On Tue, 8 Sep 2009 14:05:58 +0530 Jayamohan Kallickal…

This patch contains a fix for powerpc compile issue and has
been tested for compile on powerpc with allyesconfig option.

Thanks for that.

Quoted 1 line

The series of patches are described below:

This series should be applied in an order that allows the kernel as a whole to keep building at each step. The easiest way to guarantee that would be to put your patch 1 as the last one.

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#2 lore raw
Quoted 7 lines · Stephen Rothwell

Hi Jayamohan,

Quoted 3 lines · On Tue, 8 Sep 2009 14:05:58 +0530 Jayamohan Kallickal…

This patch contains a fix for powerpc compile issue and has
been tested for compile on powerpc with allyesconfig option.

Quoted 7 lines

Thanks for that.

Quoted 1 line

The series of patches are described below:

This series should be applied in an order that allows the kernel as a whole to keep building at each step. The easiest way to guarantee that would be to put your patch 1 as the last one.

Actually, I just folded these patches in to one last time. For new drivers, it really makes no sense to apply anything other than all in one go.

However, for code inspection purposes, this is pretty useless. The fix is buried somewhere in several thousand lines of code.

Jayamohan, could you please just send a patch for what's currently in the tree that fixes the issue, so we can better verify by inspection that it's correct? I'll fold it into the driver submit, so there won't be any point in the tree where there's a ppc build breakage, but I would like to see what the fix is without having to rebuild this patch and run interdiff.

Thanks,

James