Skip to contentSkip to conversation

b43: Fix resume failure

PATCH New Michael Buesch 1 participant 1 message Sep 11, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 b43: Fix resume failure

This fixes a resume failure where a signal is pending on resume so the firmware upload fails.
This removes the interruptible sleep, because we don't really need it. In the worst case (with broken firmware) the sleep loop will take 1 second. In the common case (working firmware), it will only take a few milliseconds. So we don't really need to be interruptible.

---

drivers/net/wireless/b43/main.c +1 -5
Index: wireless-testing/drivers/net/wireless/b43/main.c
===================================================================
@@ -2309,11 +2309,7 @@ static int b43_upload_microcode(struct b
 			err = -ENODEV;
 			goto error;
 		}
-		msleep_interruptible(50);
-		if (signal_pending(current)) {
-			err = -EINTR;
-			goto error;
-		}
+		msleep(50);
 	}
 	b43_read32(dev, B43_MMIO_GEN_IRQ_REASON);	/* dummy read */
 
Signature · 1 line
Greetings, Michael.