Skip to contentSkip to conversation

Have atalk_route_packet() return NET_RX_SUCCESS not NET_XMIT_SUCCESS

PATCH Applied Mark Smith 2 participants 2 messages Sep 13, 2009 – Sep 15, 2009

Subsystems (2)
lore
Share & tools
lore

Mark Smith

author
#0 lore raw

PATCH 1/1 Have atalk_route_packet() return NET_RX_SUCCESS not NET_XMIT_SUCCESS

Have atalk_route_packet() return NET_RX_SUCCESS not NET_XMIT_SUCCESS

atalk_route_packet() returns NET_RX_DROP if it's call to aarp_send_ddp() returns NET_XMIT_DROP. If aarp_send_ddp() returns anything else atalk_route_packet() should return NET_RX_SUCCESS, not NET_XMIT_SUCCESS.

net/appletalk/ddp.c +1 -1
index 4a6ff2b..b1a4290 100644
@@ -1372,7 +1372,7 @@ static int atalk_route_packet(struct sk_buff *skb, struct net_device *dev,
 
 	if (aarp_send_ddp(rt->dev, skb, &ta, NULL) == NET_XMIT_DROP)
 		return NET_RX_DROP;
-	return NET_XMIT_SUCCESS;
+	return NET_RX_SUCCESS;
 free_it:
 	kfree_skb(skb);
 drop:
maintainer Applied
#1 lore raw

From: Mark Smith <[email protected]>
Date: Sun, 13 Sep 2009 16:18:43 +0930

Quoted 8 lines

Have atalk_route_packet() return NET_RX_SUCCESS not NET_XMIT_SUCCESS

atalk_route_packet() returns NET_RX_DROP if it's call to aarp_send_ddp() returns NET_XMIT_DROP. If aarp_send_ddp() returns anything else atalk_route_packet() should return NET_RX_SUCCESS, not NET_XMIT_SUCCESS.

Applied.