Skip to contentSkip to conversation

be2net: fix some cmds to use mccq instead of mbox

PATCH Applied Sathya Perla 2 participants 2 messages Sep 17, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 be2net: fix some cmds to use mccq instead of mbox

All cmds issued to BE after the creation of mccq must now use the mcc-q (and not mbox) to avoid a hw issue that results in mbox poll timeout.

---
 drivers/net/benet/be.h      |    1 +
 drivers/net/benet/be_cmds.c |  412 ++++++++++++++++++++++++++-----------------
 drivers/net/benet/be_cmds.h |    5 +-
 drivers/net/benet/be_main.c |   42 +++---
 4 files changed, 271 insertions(+), 189 deletions(-)
drivers/net/benet/be.h +1 -0
index 13b72ce..684c6fe 100644
@@ -362,5 +362,6 @@ static inline u8 is_udp_pkt(struct sk_buff *skb)
 extern void be_cq_notify(struct be_adapter *adapter, u16 qid, bool arm,
 		u16 num_popped);
 extern void be_link_status_update(struct be_adapter *adapter, bool link_up);
+extern void netdev_stats_update(struct be_adapter *adapter);
 extern int be_load_fw(struct be_adapter *adapter, u8 *func);
 #endif				/* BE_H */
drivers/net/benet/be_cmds.c +246 -166

900 lines not on this page · raw message

drivers/net/benet/be_cmds.h +3 -2
index fd7028e..93e432f 100644
@@ -61,7 +61,8 @@ enum {
 /* The command is completing because the queue was getting flushed */
 	MCC_STATUS_QUEUE_FLUSHING = 0x4,
 /* The command is completing with a DMA error */
-	MCC_STATUS_DMA_FAILED = 0x5
+	MCC_STATUS_DMA_FAILED = 0x5,
+	MCC_STATUS_NOT_SUPPORTED = 0x66
 };
 
 #define CQE_STATUS_COMPL_MASK		0xFFFF
@@ -761,7 +762,7 @@ extern int be_cmd_get_flow_control(struct be_adapter *adapter,
 			u32 *tx_fc, u32 *rx_fc);
 extern int be_cmd_query_fw_cfg(struct be_adapter *adapter, u32 *port_num);
 extern int be_cmd_reset_function(struct be_adapter *adapter);
-extern void be_process_mcc(struct be_adapter *adapter);
+extern int be_process_mcc(struct be_adapter *adapter);
 extern int be_cmd_write_flashrom(struct be_adapter *adapter,
 			struct be_dma_mem *cmd, u32 flash_oper,
 			u32 flash_opcode, u32 buf_size);
drivers/net/benet/be_main.c +21 -21

104 lines not on this page · raw message

Signature · 1 line
1.6.0.4
maintainer Applied
#1 lore raw

From: Sathya Perla <[email protected]>
Date: Thu, 17 Sep 2009 10:13:31 +0530

Quoted 4 lines

All cmds issued to BE after the creation of mccq must now use the mcc-q (and not mbox) to avoid a hw issue that results in mbox poll timeout.

Applied, thanks.