media/tvp514x: recognize the error case in tvp514x_read_reg()
PATCH 1/1 media/tvp514x: recognize the error case in tvp514x_read_reg()
From: Sebastian Andrzej Siewior <[email protected]>
i2c_smbus_read_byte_data() returns a negative value on error. It is very likely to be != -1 (-EPERM).
---
Noticed by strange results during signal beeing pending.
drivers/media/video/tvp514x.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/video/tvp514x.c +1 -1
@@ -272,7 +272,7 @@ static int tvp514x_read_reg(struct v4l2_subdev *sd, u8 reg) read_again: err =i2c_smbus_read_byte_data (client, reg); -if (err ==-1 ) { +if (err <0 ) {if (retry <=I2C_RETRY_COUNT ) {v4l2_warn (sd,"Read: retry ... %d\n" , retry); retry++;
Signature · 1 line
1.6.3.3
Quoted 36 lines
-----Original Message-----
From: Sebastian Andrzej Siewior [mailto:[email protected]]
Sent: Wednesday, September 23, 2009 12:04 AM
To: Mauro Carvalho Chehab
Cc: [email protected]; Hiremath, Vaibhav; Roel Kluin
Subject: [PATCH] media/tvp514x: recognize the error case intvp514x_read_reg()From: Sebastian Andrzej Siewior <[email protected]>
i2c_smbus_read_byte_data()returns a negative value on error. It is very
likely to be != -1 (-EPERM).Signed-off-by Sebastian Andrzej Siewior <[email protected]>---
Noticed by strange results during signal beeing pending.drivers/media/video/tvp514x.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/media/video/tvp514x.c +1
-1@@ -272,7 +272,7 @@ static int tvp514x_read_reg(struct v4l2_subdev *sd, u8 reg) read_again: err =i2c_smbus_read_byte_data (client, reg); -if (err ==-1 ) { +if (err <0 ) {if (retry <=I2C_RETRY_COUNT ) {v4l2_warn (sd,"Read: retry ... %d\n" , retry);
Quoted 1 line
retry++;
[Hiremath, Vaibhav] Thanks Sebastian, good catch.
Acked by Vaibhav Hiremath.
Hans, can you apply this patch to your tree.
Thanks,
Vaibhav
Quoted 3 lines
--
1.6.3.3