Skip to contentSkip to conversation

ZOOM2 mux setup

U-Boot Olof Johansson 2 participants 2 messages Sep 22, 2009

lore
Share & tools
lore
#0 lore raw

Hi,

I stumbled across this when fixing the whitespace in the mux setup tables for various omap platforms.

I don't find it to be a very sustainable way of adding random delays into the gpio setups. Having it open-coded in a C file is much preferred.

from boards/logicpd/zoom2/zoom2.h:

/* Toggle Reset pin of TL16CP754C device */\

        MUX_VAL(CP(MCBSP4_CLKX),        (IEN  | PTU | EN  | M4)) /* GPIO_152 */\
 udelay(10);\
        MUX_VAL(CP(MCBSP4_CLKX),        (IEN  | PTD | EN  | M4)) /* GPIO_152 */\

Also, it seems like alot of the tables are really pretty common between boards. Maybe those should be extracted out to a separate base table, with additional per-board tables to be applied on top?

-Olof

#1 lore raw
Quoted 10 lines · Olof Johansson

Hi,

I stumbled across this when fixing the whitespace in the mux setup tables for various omap platforms.

I don't find it to be a very sustainable way of adding random delays into the gpio setups. Having it open-coded in a C file is much preferred.

from boards/logicpd/zoom2/zoom2.h:

Quoted 9 lines

/* Toggle Reset pin of TL16CP754C device */\

        MUX_VAL(CP(MCBSP4_CLKX),        (IEN  | PTU | EN  | M4)) /* GPIO_152 */\
 udelay(10);\
        MUX_VAL(CP(MCBSP4_CLKX),        (IEN  | PTD | EN  | M4)) /* GPIO_152 */\

Also, it seems like alot of the tables are really pretty common between boards. Maybe those should be extracted out to a separate base table, with additional per-board tables to be applied on top?

GPIO toggling should really be done with gpio interface and not the mux interface.

I will see about cleaning this up when I have time.

Tom

Quoted 2 lines

-Olof