powerpc/85xx: add eSDHC support for MPC8536DS boards
Subsystems (3)
PATCH 84/232 powerpc/85xx: add eSDHC support for MPC8536DS boards
From: Anton Vorontsov <[email protected]>
This patch simply adds sdhci node to the device tree.
We specify clock-frequency manually, so that eSDHC will work without upgrading U-Boot. Though, that'll only work for default setup (1500 MHz) on new board revisions. For non-default setups, it's recommended to upgrade U-Boot, since it will fixup clock-frequency automatically.
---
arch/powerpc/boot/dts/mpc8536ds.dts | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/powerpc/boot/dts/mpc8536ds.dts renamed from arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards +8 -0
@@ -258,6 +258,14 @@ clock-frequency = <250000000>; }; + sdhci@2e000 { + compatible = "fsl,mpc8536-esdhc", "fsl,esdhc"; + reg = <0x2e000 0x1000>; + interrupts = <72 0x2>; + interrupt-parent = <&mpic>; + clock-frequency = <250000000>; + }; + serial0: serial@4500 { cell-index = <0>; device_type = "serial";
_
Quoted 27 lines · On Tue, Sep 22, 2009 at 04:45:17PM -0700, [email protected] wrote:
From: Anton Vorontsov <[email protected]>
This patch simply adds sdhci node to the device tree.
We specify clock-frequency manually, so that eSDHC will work without upgrading U-Boot. Though, that'll only work for default setup (1500 MHz) on new board revisions. For non-default setups, it's recommended to upgrade U-Boot, since it will fixup clock-frequency automatically.
Signed-off-by Anton Vorontsov <[email protected]>Cc Pierre Ossman <[email protected]>Cc Kumar Gala <[email protected]>Cc David Vrabel <[email protected]>Cc Ben Dooks <[email protected]>Cc Sascha Hauer <[email protected]>Cc Benjamin Herrenschmidt <[email protected]>Cc <[email protected]>Signed-off-by Andrew Morton <[email protected]>---
arch/powerpc/boot/dts/mpc8536ds.dts | 8 ++++++++ 1 file changed, 8 insertions(+)diff -puN
arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boardsarch/powerpc/boot/dts/mpc8536ds.dts
arch/powerpc/boot/dts/mpc8536ds.dts line 259
Quoted 2 lines
arch/powerpc/boot/dts/mpc8536ds.dts renamed from arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards +0
-0@@ -258,6 +258,14 @@ clock-frequency = <250000000>; };
By "clock-frequency = <250000000>;" above and the one down below* I can see that this patch is already applied (via powerpc tree).
Please don't merge this particular patch, it's already there.
arch/powerpc/boot/dts/mpc8536ds.dts line 266
Quoted 6 lines
arch/powerpc/boot/dts/mpc8536ds.dts renamed from arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards +6
-0+ sdhci@2e000 { + compatible = "fsl,mpc8536-esdhc", "fsl,esdhc"; + reg = <0x2e000 0x1000>; + interrupts = <72 0x2>; + interrupt-parent = <&mpic>; + clock-frequency = <250000000>;
*
Quoted 6 lines
arch/powerpc/boot/dts/mpc8536ds.dts renamed from arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards +2
-0+ }; + serial0: serial@4500 { cell-index = <0>; device_type = "serial";_
Thanks,
Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2
Quoted 45 lines · On Wed, 23 Sep 2009 04:32:00 +0400 Anton Vorontsov <[email protected]>…
Quoted 27 lines · On Tue, Sep 22, 2009 at 04:45:17PM -0700, [email protected] wrote:
From: Anton Vorontsov <[email protected]>
This patch simply adds sdhci node to the device tree.
We specify clock-frequency manually, so that eSDHC will work without upgrading U-Boot. Though, that'll only work for default setup (1500 MHz) on new board revisions. For non-default setups, it's recommended to upgrade U-Boot, since it will fixup clock-frequency automatically.
Signed-off-by Anton Vorontsov <[email protected]>Cc Pierre Ossman <[email protected]>Cc Kumar Gala <[email protected]>Cc David Vrabel <[email protected]>Cc Ben Dooks <[email protected]>Cc Sascha Hauer <[email protected]>Cc Benjamin Herrenschmidt <[email protected]>Cc <[email protected]>Signed-off-by Andrew Morton <[email protected]>---
arch/powerpc/boot/dts/mpc8536ds.dts | 8 ++++++++ 1 file changed, 8 insertions(+)diff -puN
arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boardsarch/powerpc/boot/dts/mpc8536ds.dtsarch/powerpc/boot/dts/mpc8536ds.dts line 259
Quoted 2 lines
arch/powerpc/boot/dts/mpc8536ds.dts renamed from arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards +0
-0@@ -258,6 +258,14 @@ clock-frequency = <250000000>; };By "clock-frequency = <250000000>;" above and the one down below* I can see that this patch is already applied (via powerpc tree).
Please don't merge this particular patch, it's already there.
arch/powerpc/boot/dts/mpc8536ds.dts line 266
Quoted 6 lines
arch/powerpc/boot/dts/mpc8536ds.dts renamed from arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards +6
-0+ sdhci@2e000 { + compatible = "fsl,mpc8536-esdhc", "fsl,esdhc"; + reg = <0x2e000 0x1000>; + interrupts = <72 0x2>; + interrupt-parent = <&mpic>; + clock-frequency = <250000000>;*
Quoted 6 lines
Quoted 6 lines
arch/powerpc/boot/dts/mpc8536ds.dts renamed from arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards +2
-0+ }; + serial0: serial@4500 { cell-index = <0>; device_type = "serial";_
So someone went and stole [patch 7/7] from your series and didn't tell me?
I wasn't expecting that.
Quoted 47 lines · Andrew Morton
Quoted 45 lines · On Wed, 23 Sep 2009 04:32:00 +0400 Anton Vorontsov <[email protected]>…
Quoted 27 lines · On Tue, Sep 22, 2009 at 04:45:17PM -0700, [email protected] wrote:
From: Anton Vorontsov <[email protected]>
This patch simply adds sdhci node to the device tree.
We specify clock-frequency manually, so that eSDHC will work without upgrading U-Boot. Though, that'll only work for default setup (1500 MHz) on new board revisions. For non-default setups, it's recommended to upgrade U-Boot, since it will fixup clock-frequency automatically.
Signed-off-by Anton Vorontsov <[email protected]>Cc Pierre Ossman <[email protected]>Cc Kumar Gala <[email protected]>Cc David Vrabel <[email protected]>Cc Ben Dooks <[email protected]>Cc Sascha Hauer <[email protected]>Cc Benjamin Herrenschmidt <[email protected]>Cc <[email protected]>Signed-off-by Andrew Morton <[email protected]>---
arch/powerpc/boot/dts/mpc8536ds.dts | 8 ++++++++ 1 file changed, 8 insertions(+)diff -puN
arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boardsarch/powerpc/boot/dts/mpc8536ds.dtsarch/powerpc/boot/dts/mpc8536ds.dts line 259
Quoted 2 lines
arch/powerpc/boot/dts/mpc8536ds.dts renamed from arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards +0
-0@@ -258,6 +258,14 @@ clock-frequency = <250000000>; };By "clock-frequency = <250000000>;" above and the one down below* I can see that this patch is already applied (via powerpc tree).
Please don't merge this particular patch, it's already there.
arch/powerpc/boot/dts/mpc8536ds.dts line 266
Quoted 6 lines
arch/powerpc/boot/dts/mpc8536ds.dts renamed from arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards +6
-0+ sdhci@2e000 { + compatible = "fsl,mpc8536-esdhc", "fsl,esdhc"; + reg = <0x2e000 0x1000>; + interrupts = <72 0x2>; + interrupt-parent = <&mpic>; + clock-frequency = <250000000>;*
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
arch/powerpc/boot/dts/mpc8536ds.dts renamed from arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards +2
-0+ }; + serial0: serial@4500 { cell-index = <0>; device_type = "serial";_
So someone went and stole [patch 7/7] from your series and didn't tell me?
Kumar told that he applied it to his next tree, you were Cc'ed.
http://lkml.org/lkml/2009/8/25/235
Thanks,
Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2