xfs: stop calling filemap_fdatawait inside ->fsync
PATCH 1/1 xfs: stop calling filemap_fdatawait inside ->fsync
Now that the VFS actually waits for the data I/O to complete before calling into ->fsync we can stop doing it ourselves.
fs/xfs/linux-2.6/xfs_file.c +0 -7
@@ -176,14 +176,7 @@ xfs_file_fsync( struct dentry *dentry, int datasync) { -struct inode *inode = dentry->d_inode;struct xfs_inode *ip =XFS_I (inode); -int error; - -/* capture size updates in I/O completion before writing the inode. */ - error =filemap_fdatawait (inode->i_mapping); -if (error) -return error;xfs_iflags_clear (ip,XFS_ITRUNCATED );return -xfs_fsync (ip);
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 4 lines · Christoph Hellwig
Now that the VFS actually waits for the data I/O to complete before calling into ->fsync we can stop doing it ourselves.
Signed-off-by Christoph Hellwig <[email protected]>
Looks good.
Quoted 20 lines
Index:
linux-2.6/fs/xfs/linux-2.6/xfs_file.c
===================================================================fs/xfs/linux-2.6/xfs_file.c +0
-7@@ -176,14 +176,7 @@ xfs_file_fsync( struct dentry *dentry, int datasync) { -struct inode *inode = dentry->d_inode;struct xfs_inode *ip =XFS_I (inode); -int error; - -/* capture size updates in I/O completion before writing the inode. */ - error =filemap_fdatawait (inode->i_mapping); -if (error) -return error;xfs_iflags_clear (ip,XFS_ITRUNCATED );return -xfs_fsync (ip);
Quoted 4 lines
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs