Skip to contentSkip to conversation

s3c24xx gpiolib question

PATCH Vasily Khoruzhick 2 participants 2 messages Sep 27, 2009 – Sep 28, 2009

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Vasily Khoruzhick

author
#0 lore raw

Hi,

Is following patch sufficient to add GPJ port support to s3c24xx gpiolib? And how to switch gpioline to custom function mode (for example TOUT0 on GPB0) via gpiolib?

arch/arm/plat-s3c24xx/gpiolib.c +12 -1
index 6d7a961..65d79f9 100644
@@ -151,7 +151,8 @@ struct s3c_gpio_chip s3c24xx_gpios[] = {
 			.ngpio			= 16,
 			.to_irq			= s3c24xx_gpiolib_bankg_toirq,
 		},
-	}, {
+	}, 
+	[7] = {
 		.base	= S3C2410_GPHCON,
 		.pm	= __gpio_pm(&s3c_gpio_pm_2bit),
 		.chip	= {

@@ -161,6 +162,16 @@ struct s3c_gpio_chip s3c24xx_gpios[] = {
 			.ngpio			= 11,
 		},
 	},
+	[8] = {
+		.base	= S3C2440_GPJCON,
+		.pm = __gpio_pm(&s3c_gpio_pm_2bit),
+		.chip	= {
+			.base			= S3C2440_GPJ0,
+			.owner			= THIS_MODULE,
+			.label			= "GPIOJ",
+			.ngpio			= 16,
+		},
+	},
 };
 
 static __init int s3c24xx_gpiolib_init(void)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20090927/2dd0962b/attachment.sig>

#1 lore raw
Quoted 21 lines · Vasily Khoruzhick

Hi,

Is following patch sufficient to add GPJ port support to s3c24xx gpiolib? And how to switch gpioline to custom function mode (for example TOUT0 on GPB0) via gpiolib?

arch/arm/plat-s3c24xx/gpiolib.c +2 -1
index 6d7a961..65d79f9 100644
@@ -151,7 +151,8 @@ struct s3c_gpio_chip s3c24xx_gpios[] = {
 			.ngpio			= 16,
 			.to_irq			= s3c24xx_gpiolib_bankg_toirq,
 		},
-	}, {
+	}, 
+	[7] = {
 		.base	= S3C2410_GPHCON,
 		.pm	= __gpio_pm(&s3c_gpio_pm_2bit),
 		.chip	= {

arch/arm/plat-s3c24xx/gpiolib.c struct s3c_gpio_chip s3c24xx_gpios[] = { · line 169

Quoted 8 lines
arch/arm/plat-s3c24xx/gpiolib.c +5 -0
@@ -161,6 +162,16 @@ struct s3c_gpio_chip s3c24xx_gpios[] = {
 			.ngpio			= 11,
 		},
 	},
+	[8] = {
+		.base	= S3C2440_GPJCON,
+		.pm = __gpio_pm(&s3c_gpio_pm_2bit),
+		.chip	= {
+			.base			= S3C2440_GPJ0,

I need to get the gpio number space compressed to get this to work, it got shuffled out of this round of patches due to urgent meetings.

Signature · 4 lines
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.