Skip to contentSkip to conversation

multipath-tools: Fix dry-run output

PATCH New Benjamin Marzinski 1 participant 1 message Sep 28, 2009 Device mapper

lore
Share & tools
lore

Benjamin Marzinski

author maintainer
#0 lore raw

PATCH 1/1 multipath-tools: Fix dry-run output

When multipath checks whether or not the multipath device needs to be renamed, it only does the check if dry-run isn't selected. This means that you will instead see all your renames as creates during a dry-run. The attached patch fixes this.

---
 libmultipath/configure.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
libmultipath/configure.c +1 -1
Index: multipath-tools-090902/libmultipath/configure.c
===================================================================
@@ -151,7 +151,7 @@ select_action (struct multipath * mpp, v
 	if (!cmpp) {
 		cmpp = find_mp_by_wwid(curmp, mpp->wwid);
 
-		if (cmpp && !conf->dry_run) {
+		if (cmpp) {
 			condlog(2, "%s: rename %s to %s", mpp->wwid,
 				cmpp->alias, mpp->alias);
 			strncpy(mpp->alias_old, cmpp->alias, WWID_SIZE);