Skip to contentSkip to conversation

powerpc: warning: allocated section `.data_nosave' not in segment

PATCH In review Sean MacLennan 2 participants 2 messages Sep 29, 2009 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: warning: allocated section `.data_nosave' not in segment

We need to align before the output section. Having the align inside the output section causes the linker to put some filler in there, which makes it a non-empty section, but this section isn't assigned to a segment so you get a warning from the linker.

---

(quoted diff) +0 -0

b/arch/powerpc/kernel/vmlinux.lds.S index f564293..e853763 100644

arch/powerpc/kernel/vmlinux.lds.S +1 -0
@@ -236,6 +236,7 @@ SECTIONS
 		READ_MOSTLY_DATA(L1_CACHE_BYTES)
 	}
 
+  	. = ALIGN(PAGE_SIZE);
 	.data_nosave : AT(ADDR(.data_nosave) - LOAD_OFFSET) {
 		NOSAVE_DATA
 	}
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines

We need to align before the output section. Having the align inside the output section causes the linker to put some filler in there, which makes it a non-empty section, but this section isn't assigned to a segment so you get a warning from the linker.

---

(quoted diff) +0 -0

b/arch/powerpc/kernel/vmlinux.lds.S index f564293..e853763 100644

arch/powerpc/kernel/vmlinux.lds.S SECTIONS · line 242

Quoted 7 lines
arch/powerpc/kernel/vmlinux.lds.S +1 -0
@@ -236,6 +236,7 @@ SECTIONS
 		READ_MOSTLY_DATA(L1_CACHE_BYTES)
 	}
 
+  	. = ALIGN(PAGE_SIZE);
 	.data_nosave : AT(ADDR(.data_nosave) - LOAD_OFFSET) {
 		NOSAVE_DATA
 	}

The patch is good and fixes a real problem. But, I still don't see how it caused the "warning: allocated section `.data_nosave' not in segment", it would be good if we can find out.

Segher