lguest: GET_ID "support"
PATCH 4/4 lguest: GET_ID "support"
We advertise the feature for testing, then promptly fail when the guest uses it.
Signed-off-by Rusty Russell <[email protected]>
--- Documentation/lguest/lguest.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
Documentation/lguest/lguest.c +8 -1
@@ -1654,7 +1654,11 @@ static void blk_request(struct virtqueue* In general the virtio block driver is allowed to try SCSI commands. * It'd be nice if we supported eject, for example, but we don't. */ -if (out->type &VIRTIO_BLK_T_SCSI_CMD ) { +if (out->type ==VIRTIO_BLK_T_GET_ID ) { +fprintf (stderr,"GET ID command unsupported\n" ); + *in =VIRTIO_BLK_S_UNSUPP ; + wlen =sizeof (*in); + }else if (out->type &VIRTIO_BLK_T_SCSI_CMD ) {fprintf (stderr,"Scsi commands unsupported\n" ); *in =VIRTIO_BLK_S_UNSUPP ; wlen =sizeof (*in);
@@ -1751,6 +1755,9 @@ static void setup_block_file(const charadd_feature (dev,VIRTIO_BLK_F_SEG_MAX ); conf.seg_max =cpu_to_le32 (VIRTQUEUE_NUM -2 ); +/* We have GET_ID, at least for testing! */ +add_feature (dev,VIRTIO_BLK_F_GET_ID ); +/* * We only have 8 bits of configuration space for each device. But a * new feature for virtio_blk added a 1k 'identify' field to struct