Skip to contentSkip to conversation

Subject: [PATCH 2.4] Fix Kernel 2.4 build with bash 4

PATCH Stefan Seyfried 2 participants 3 messages Oct 2, 2009

lore
Share & tools
lore
#0 lore raw
---
 scripts/Configure |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
scripts/Configure +2 -2
index 1a3af43..7a73423 100644
@@ -546,9 +546,9 @@ if [ -f $DEFAULTS ]; then
   echo "#"
   echo "# Using defaults found in" $DEFAULTS
   echo "#"
-  . $DEFAULTS
+  . ./$DEFAULTS
   sed -e 's/# \(CONFIG_[^ ]*\) is not.*/\1=n/' <$DEFAULTS >.config-is-not.$$
-  . .config-is-not.$$
+  . ./.config-is-not.$$
   rm .config-is-not.$$
 else
   echo "#"
Signature · 1 line
1.6.4.2
#1 lore raw

Hi Stefan,

Quoted 12 lines · Stefan Seyfried
---
 scripts/Configure |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
scripts/Configure +0 -0
index 1a3af43..7a73423 100644
@@ -546,9 +546,9 @@ if [ -f $DEFAULTS ]; then
   echo "#"

scripts/Configure if [ -f $DEFAULTS ]; then · line 554

Quoted 10 lines
scripts/Configure +2 -2
   echo "# Using defaults found in" $DEFAULTS
   echo "#"
-  . $DEFAULTS
+  . ./$DEFAULTS
   sed -e 's/# \(CONFIG_[^ ]*\) is not.*/\1=n/' <$DEFAULTS >.config-is-not.$$
-  . .config-is-not.$$
+  . ./.config-is-not.$$
   rm .config-is-not.$$
 else
   echo "#"

This is amazing it has ever worked at all ! None of my scripts which use ". $file" without "./" work even in bash 3. Probably this depends on some PATH variables and maybe your environment has changed since you upgarded to bash 4.

Thanks for the fix, I'll merge it.
Willy

#2 lore raw
Quoted 4 lines · On Fri, 2 Oct 2009 11:25:07 +0200 Willy Tarreau <[email protected]> wrote:

This is amazing it has ever worked at all ! None of my scripts which use ". $file" without "./" work even in bash 3. Probably this depends on some PATH variables and maybe your environment has changed since you upgarded to bash 4.

Well, people started reporting it when distributions (openSUSE FACTORY and Fedora 11) switched to bash 4. Maybe the shell's defaults are now just a bit stricter, or the distros abandoned a PATH setting that was common before, I have no idea.

Quoted 1 line

Thanks for the fix, I'll merge it.

Thanks! Saves me a local patch ;)

Signature · 4 lines
Stefan Seyfried

"Any ideas, John?"
"Well, surrounding them's out."