Nested function in drivers/of/of_mdio.c
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
Please resend your question with both [email protected] and [email protected] added to the cc: list.
g.
Quoted 51 lines · Jérôme Pouiller
Dear,
I have a problem with commit
8bc487d150b939e69830c39322df4ee486efe381in filedrivers/of/of_mdio.cin functionof_phy_find_device.As you see, this function define
match()as a nested function. My
compiler (powerpc-e500-linux-gnu-gcc-3.4.1) raise an error during link
due to this nested definition:
drivers/built-in.o(.text+0x5e2a4): In function `of_phy_find_device':/home/jezz/linux-next/drivers/of/of_mdio.c:107:
undefined reference to `__trampoline_setup'I am sure I could solve problem by rebuilding my toolchain. Nevertheless, I think nested function definition is not perfectly supported by all compilers. Also, I suggest to place function
match()outside of scope ofof_phy_find_deviceas in following patch.drivers/of/of_mdio.c +4
-5@@ -97,6 +97,10 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) } EXPORT_SYMBOL(of_mdiobus_register); +static int match (struct device *dev,void *phy_np) +{ + return dev_archdata_get_node(&dev->archdata) == phy_np; +} /*** of_phy_find_device - Give a PHY node, find the phy_device * @phy_np: Pointer to the phy's device tree node @@ -106,11 +110,6 @@ EXPORT_SYMBOL(of_mdiobus_register); struct phy_device *of_phy_find_device(struct device_node *phy_np) { struct device *d; - int match(struct device *dev, void *phy_np) - { - return dev_archdata_get_node(&dev->archdata) == phy_np; - } - if (!phy_np) return NULL;What do you think about it?
Best regards,
--
Jérôme Pouiller (jezz AT sysmic DOT org)
Signature · 2 lines
Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.