kirkwood: missing pci support for openrd_base board
Subsystems (2)
(I suggest we move this discussion to the OpenRD mailing list only in the future)
Quoted 6 lines · On Thu, 8 Oct 2009 13:33:42 +0200 Dieter Kiermaier <[email protected]> wrote:
I try most recent kernel form kernel.org:
Linux DB88FXX81 2.6.32-rc3-00052-g0eca52a #5 PREEMPT Thu Oct 8 13:20:27 CEST 2009 armv5tel GNU/Linux
So everything else seems to work well but I can't get pci bus working?
Is PCI expected to work or are there some patches missing (and if so, where are they available?)
It's just because PCIe initialization isn't called. I sent this patch over a month ago, but it hasn't been merged yet:
http://www.spinics.net/lists/arm-kernel/msg73112.html
// Simon
Hi all,
I try most recent kernel form kernel.org:
Linux DB88FXX81 2.6.32-rc3-00052-g0eca52a #5 PREEMPT Thu Oct 8 13:20:27 CEST 2009 armv5tel GNU/Linux
So everything else seems to work well but I can't get pci bus working?
Is PCI expected to work or are there some patches missing (and if so, where are they available?)
Many thanks for your answer!
Dieter
Simon,
Quoted 11 lines
(I suggest we move this discussion to the OpenRD mailing list only in the future)
Quoted 4 lines · On Thu, 8 Oct 2009 13:33:42 +0200 Dieter Kiermaier <[email protected]> wrote:
I try most recent kernel form kernel.org:
Linux DB88FXX81 2.6.32-rc3-00052-g0eca52a #5 PREEMPT Thu Oct 8 13:20:27 CEST 2009 armv5tel GNU/Linux
Quoted 7 lines
Quoted 2 lines
So everything else seems to work well but I can't get pci bus working?
Is PCI expected to work or are there some patches missing (and if so, where are they available?)It's just because PCIe initialization isn't called. I sent this patch over a month ago, but it hasn't been merged yet:
Many thanks for the patch - I've googled a lot but can't find the information. Sorry for the noise!
Dieter
Quoted 10 lines
// Simon
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "OpenRD" group. To post to this group, send email to openrd at googlegroups.com
To unsubscribe from this group, send email to openrd+unsubscribe at googlegroups.com For more options, visit this group at http://groups.google.com/group/openrd?hl=en
-~----------~----~----~----~------~----~------~--~---
Simon,
I will verify and ACK on mailing list.
- Dhaval
Quoted 27 lines · Dieter Kiermaier
Simon,
Quoted 8 lines
(I suggest we move this discussion to the OpenRD mailing list only in the future)
Quoted 2 lines · On Thu, 8 Oct 2009 13:33:42 +0200 Dieter Kiermaier <[email protected]> wrote:
I try most recent kernel form kernel.org:
Quoted 8 lines
Quoted 4 lines
Linux DB88FXX81 2.6.32-rc3-00052-g0eca52a #5 PREEMPT Thu Oct 8 13:20:27 CEST 2009 armv5tel GNU/Linux
So everything else seems to work well but I can't get pci bus working?
Is PCI expected to work or are there some patches missing (and if so, where are they available?)It's just because PCIe initialization isn't called. I sent this patch over a month ago, but it hasn't been merged yet:
Many thanks for the patch - I've googled a lot but can't find the information. Sorry for the noise!
Dieter
Quoted 2 lines
// Simon
Signature · 15 lines
_____________________________________________________________________ Disclaimer: This e-mail message and all attachments transmitted with it are intended solely for the use of the addressee and may contain legally privileged and confidential information. If the reader of this message is not the intended recipient, or an employee or agent responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution, copying, or other use of this message or its attachments is strictly prohibited. If you have received this message in error, please notify the sender immediately by replying to this message and please delete it from your computer. Any views expressed in this message are those of the individual sender unless otherwise stated.Company has taken enough precautions to prevent the spread of viruses. However the company accepts no liability for any damage caused by any virus transmitted by this email. _____________________________________________________________________
Quoted 9 lines · Simon Kagstrom
Quoted 1 line · On Thu, 8 Oct 2009 13:33:42 +0200 Dieter Kiermaier <[email protected]> wrote:
Is PCI expected to work or are there some patches missing (and if so, where are they available?)
It's just because PCIe initialization isn't called. I sent this patch over a month ago, but it hasn't been merged yet:
Could you verify this still applies and works fine on the latest kernel and resend please? Also don't forget to CC me or chances for me to miss the patch are greater.
Nicolas
PATCH v2 1/1 OpenRD base: Initialize PCI express and i2c
---
Right now I don't have a PCI card to test with, so Dieter: could you test the patch and ack it?
ChangeLog:
v2:
* Rebase against 2.6.32
* Remove UART1 initialization (UART1 is not always present - either the SD card or UART1 is selected)
arch/arm/mach-kirkwood/openrd_base-setup.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)
arch/arm/mach-kirkwood/openrd_base-setup.c +12 -0
@@ -70,8 +70,20 @@ static void __init openrd_base_init(void)kirkwood_ge00_init (&openrd_base_ge00_data);kirkwood_sata_init (&openrd_base_sata_data);kirkwood_sdio_init (&openrd_base_mvsdio_data); + +kirkwood_i2c_init (); } +static int __init openrd_base_pci_init (void ) +{ +if (machine_is_openrd_base ()) +kirkwood_pcie_init (); + +return 0 ; + } +subsys_initcall (openrd_base_pci_init); + +MACHINE_START (OPENRD_BASE ,"Marvell OpenRD Base Board" )/* Maintainer: Dhaval Vasa <[email protected]> */ .phys_io = KIRKWOOD_REGS_PHYS_BASE,
Signature · 1 line
1.6.0.4
PATCH v2 1/1 OpenRD base: Initialize PCI express and i2c
Hi Simon,
I've tested you patch against 2.6.32-rc3 from Linus' tree and it works fine and applies without any issues.
Without patch:
h-3.2# uname -a
Linux DB88FXX81 2.6.32-rc3-00256-g36a0790 #1 PREEMPT Fri Oct 9 08:44:33 CEST 2009 armv5tel GNU/Linux sh-3.2#
sh-3.2#
sh-3.2# lspci
sh-3.2#
with applied patch:
sh-3.2# uname -a
Linux DB88FXX81 2.6.32-rc3-00256-g36a0790-dirty #2 PREEMPT Fri Oct 9 08:47:02 CEST 2009 armv5tel GNU/Linux sh-3.2# lspci
00:00.0 Class 0580: Device 11ab:6281 (rev 02)
00:01.0 Class 0200: Device 10ec:8168 (rev 01)
sh-3.2#
Sorry for the silly question, but what have I do to ack it?
Greetings,
Dieter
Quoted 40 lines
Signed-off-by Simon Kagstrom <[email protected]>---
Right now I don't have a PCI card to test with, so Dieter: could you test the patch and ack it?ChangeLog:
v2:
* Rebase against 2.6.32
* Remove UART1 initialization (UART1 is not always present - either the SD card or UART1 is selected)arch/arm/mach-kirkwood/openrd_base-setup.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)arch/arm/mach-kirkwood/openrd_base-setup.c +12
-0@@ -70,8 +70,20 @@ static void __init openrd_base_init(void)kirkwood_ge00_init (&openrd_base_ge00_data);kirkwood_sata_init (&openrd_base_sata_data);kirkwood_sdio_init (&openrd_base_mvsdio_data); + +kirkwood_i2c_init (); } +static int __init openrd_base_pci_init (void ) +{ +if (machine_is_openrd_base ()) +kirkwood_pcie_init (); + +return 0 ; + } +subsys_initcall (openrd_base_pci_init); + +MACHINE_START (OPENRD_BASE ,"Marvell OpenRD Base Board" )/* Maintainer: Dhaval Vasa <[email protected]> */ .phys_io = KIRKWOOD_REGS_PHYS_BASE,
Nicolas Pitre
AppliedPATCH v2 1/1 OpenRD base: Initialize PCI express and i2c
Quoted 12 lines · Dieter Kiermaier
Hi Simon,
I've tested you patch against 2.6.32-rc3 from Linus' tree and it works fine and applies without any issues.
Without patch:
h-3.2# uname -a
Linux DB88FXX81 2.6.32-rc3-00256-g36a0790 #1 PREEMPT Fri Oct 9 08:44:33 CEST 2009 armv5tel GNU/Linux sh-3.2#
sh-3.2#
sh-3.2# lspci
sh-3.2#
Quoted 8 lines
with applied patch:
sh-3.2# uname -a
Linux DB88FXX81 2.6.32-rc3-00256-g36a0790-dirty #2 PREEMPT Fri Oct 9 08:47:02 CEST 2009 armv5tel GNU/Linux sh-3.2# lspci
00:00.0 Class 0580: Device 11ab:6281 (rev 02)
00:01.0 Class 0200: Device 10ec:8168 (rev 01)
sh-3.2#
I've applied it to the orion repo.
Quoted 1 line
Sorry for the silly question, but what have I do to ack it?
You basically say so like you did above. Some maintainers also prefer you provide a ready to cop and paste line such as:
Nicolas