Skip to contentSkip to conversation

qemu: allow pulseaudio backend to be the default

PATCH Superseded Michael S. Tsirkin 2 participants 2 messages Oct 13, 2009

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qemu: allow pulseaudio backend to be the default

From: Mark McLoughlin <[email protected]>
Date: Fri, 4 Sep 2009 10:24:03 +0000 (+0100)
Subject: qemu: allow pulseaudio backend to be the default
X-Git-Url: http://repo.or.cz/w/qemu-kvm/fedora.git?a=commitdiff_plain;h=8ab0d97572

We're seeing various issues with the SDL audio backend and want to switch to the pulseaudio backend. See e.g.

https://bugzilla.redhat.com/495964
https://bugzilla.redhat.com/519540
https://bugzilla.redhat.com/496627

The pulseaudio backend seems to work well, so we should allow it to be selected as the default.

---

The patch above is in qemu in Fedora 11. Pulseaudio seems to be the only way to get decent sound quality on default installation in that distro, and there does not seem to be a reason not to allow pulseaudio be the default, if the user chooses to make it so at configure time.

Please comment or commit.

audio/paaudio.c +1 -1
index a50fccc..547e252 100644
@@ -507,7 +507,7 @@ struct audio_driver pa_audio_driver = {
     INIT_FIELD (init           = ) qpa_audio_init,
     INIT_FIELD (fini           = ) qpa_audio_fini,
     INIT_FIELD (pcm_ops        = ) &qpa_pcm_ops,
-    INIT_FIELD (can_be_default = ) 0,
+    INIT_FIELD (can_be_default = ) 1,
     INIT_FIELD (max_voices_out = ) INT_MAX,
     INIT_FIELD (max_voices_in  = ) INT_MAX,
     INIT_FIELD (voice_size_out = ) sizeof (PAVoiceOut),
#1 lore raw
Quoted 12 lines · Michael S. Tsirkin

From: Mark McLoughlin <[email protected]>
Date: Fri, 4 Sep 2009 10:24:03 +0000 (+0100)
Subject: qemu: allow pulseaudio backend to be the default
X-Git-Url: http://repo.or.cz/w/qemu-kvm/fedora.git?a=commitdiff_plain;h=8ab0d97572

We're seeing various issues with the SDL audio backend and want to switch to the pulseaudio backend. See e.g.

https://bugzilla.redhat.com/495964
https://bugzilla.redhat.com/519540
https://bugzilla.redhat.com/496627

Quoted 5 lines

The pulseaudio backend seems to work well, so we should allow it to be selected as the default.

A big whatever from me, as explained before this driver is a 30-40min hack that's why i never felt it deserved to be default, buf if it works for you, fine. One request though, please do provide a patch which doesn't require me to git am -i it.. Something simple.

[..snip..]

Signature · 1 line
mailto:[email protected]