Skip to contentSkip to conversation

x86,apic: allow noop operations to be called almost at any time

PATCH In review Cyrill Gorcunov 1 participant 2 messages Oct 15, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86,apic: allow noop operations to be called almost at any time

As only apic noop is used we allow to use almost any operation caller wants (and which of them noop driver supports of course).

Initially it was reported by Ingo Molnar that apic noop issue a warning for pkg id (which is actually false positive and should be eliminated).

So we save checking (and warning issue) for read/write operations while allow any other ops to be freely used.

Also:
- fix noop_cpu_to_logical_apicid, it should be 0.
- rename noop_default_phys_pkg_id to noop_phys_pkg_id (we use default_ prefix for more general routines in apic subsystem).

---
 arch/x86/kernel/apic/apic.c      |    1 
 arch/x86/kernel/apic/apic_noop.c |  103 +++++++++++++++++++++------------------
 2 files changed, 58 insertions(+), 46 deletions(-)
arch/x86/kernel/apic/apic.c +1 -0
Index: linux-2.6.git/arch/x86/kernel/apic/apic.c
=====================================================================
@@ -246,6 +246,7 @@ static int modern_apic(void)
  */
 void apic_disable(void)
 {
+	pr_info("APIC: switched to apic NOOP\n");
 	apic = &apic_noop;
 }
 
arch/x86/kernel/apic/apic_noop.c +57 -46

169 lines not on this page · raw message

#1 lore raw

[tip:x86/apic] x86: apic: Allow noop operations to be called almost at any time

Commit-ID:  f88f2b4fdb1e098433ad2b005b6f7353f7268ce1
Gitweb:     http://git.kernel.org/tip/f88f2b4fdb1e098433ad2b005b6f7353f7268ce1
Author:     Cyrill Gorcunov <[email protected]>
AuthorDate: Thu, 15 Oct 2009 19:04:16 +0400
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 15 Oct 2009 17:26:53 +0200

x86: apic: Allow noop operations to be called almost at any time

As only apic noop is used we allow to use almost any operation caller wants (and which of them noop driver supports of course).

Initially it was reported by Ingo Molnar that apic noop issue a warning for pkg id (which is actually false positive and should be eliminated).

So we save checking (and warning issue) for read/write operations while allow any other ops to be freely used.

Also:
- fix noop_cpu_to_logical_apicid, it should be 0.
- rename noop_default_phys_pkg_id to noop_phys_pkg_id (we use default_ prefix for more general routines in apic subsystem).

LKML-Reference: <20091015150416.GC5331@lenovo>

---
 arch/x86/kernel/apic/apic.c      |    1 +
 arch/x86/kernel/apic/apic_noop.c |  105 +++++++++++++++++++++-----------------
 2 files changed, 59 insertions(+), 47 deletions(-)
arch/x86/kernel/apic/apic.c +1 -0
index 61a5628..dce93d4 100644
@@ -246,6 +246,7 @@ static int modern_apic(void)
  */
 void apic_disable(void)
 {
+	pr_info("APIC: switched to apic NOOP\n");
 	apic = &apic_noop;
 }
 
arch/x86/kernel/apic/apic_noop.c +58 -47

170 lines not on this page · raw message