be2iscsi: Enabling MSIX and mcc_rings V2

drivers/scsi/be2iscsi/be_main.c +4 -1

@@ -355,13 +526,32 @@ static irqreturn_t be_isr(int irq, void *dev_id)
 static int beiscsi_init_irqs(struct beiscsi_hba *phba)
 {
        struct pci_dev *pcidev = phba->pcidev;
-       int ret;
+       struct hwi_controller *phwi_ctrlr;
+       struct hwi_context_memory *phwi_context;
+       int ret, msix_vec, i = 0;
+       char desc[32];

drivers/scsi/be2iscsi/be_main.c +7 -19

-static int beiscsi_create_eq(struct beiscsi_hba *phba,
+static int beiscsi_create_eqs(struct beiscsi_hba *phba,
                             struct hwi_context_memory *phwi_context)
 {
-       unsigned int idx;
-       int ret;
+       unsigned int i, num_eq_pages;
+       int ret, eq_for_mcc;
        struct be_queue_info *eq;
        struct be_dma_mem *mem;
-       struct be_mem_descriptor *mem_descr;
        void *eq_vaddress;
+       dma_addr_t paddr;
 
-       idx = 0;
-       eq = &phwi_context->be_eq.q;
-       mem = &eq->dma_mem;
-       mem_descr = phba->init_mem;
-       mem_descr += HWI_MEM_EQ;
-       eq_vaddress = mem_descr->mem_array[idx].virtual_address;
-
-       ret = be_fill_queue(eq, phba->params.num_eq_entries,
-                           sizeof(struct be_eq_entry), eq_vaddress);
-       if (ret) {
-               shost_printk(KERN_ERR, phba->shost,
-                            "be_fill_queue Failed for EQ \n");
-               return ret;
-       }
+       num_eq_pages = PAGES_REQUIRED(phba->params.num_eq_entries * \
+                                     sizeof(struct be_eq_entry));
 
-       mem->dma = mem_descr->mem_array[idx].bus_address.u.a64.address;
+       if (enable_msix)

drivers/scsi/be2iscsi/be_main.c +8 -0

+static int
+beiscsi_alloc_sysfs_attr(struct Scsi_Host *shost)
+{
+       int ret;
+
+       ret = sysfs_create_bin_file(&shost->shost_dev.kobj,
+                                   &sysfs_drvr_fw_prgrm_attr);
+       if (ret)

drivers/scsi/be2iscsi/be_main.c +5 -0

+static void beiscsi_msix_enable(struct beiscsi_hba *phba)
+{
+       int i, status;
+
+       for (i = 0; i <= phba->num_cpus; i++)

This patch

1) Turns on msix
2) Adds mcc_ring support for sending FW commands
3) Adds Support for Ring Mode of WRB Posting
4) Adds sysfs for FW commands

This patch

1) Turns on msix
2) Adds mcc_ring support for sending FW commands
3) Adds Support for Ring Mode of WRB Posting
4) Adds sysfs for FW commands

_____ From: Mike Christie [mailto:[email protected]]
To: Jayamohan Kalickal [mailto:[email protected]]
Cc: [email protected]
Sent: Wed, 21 Oct 2009 10:19:06 -0700
Subject: Re: [PATCH 1/1] be2iscsi: Enabling MSIX and mcc_rings V2

Quoted 6 lines · Jayamohan Kallickal

This patch

1) Turns on msix
2) Adds mcc_ring support for sending FW commands
3) Adds Support for Ring Mode of WRB Posting
4) Adds sysfs for FW commands

I think msix should be a separate patch from the fw command one, and the ring mode changes could probably be in a separate patch too.

Will Do that

drivers/scsi/be2iscsi/be_cmds.c static int be_mcc_compl_process(struct be_ctrl_info *ctrl, · line 94

Quoted 9 lines

drivers/scsi/be2iscsi/be_cmds.c +9 -0

+
+static void beiscsi_async_link_state_process(struct beiscsi_hba *phba,
+		struct be_async_event_link_state *evt)
+{
+	switch (evt->port_link_status) {
+	case ASYNC_EVENT_LINK_DOWN:
+		SE_DEBUG(DBG_LVL_1, "Link Down on Physical Port %d \n",
+						evt->physical_port);
+		break;

When you get a link down, does it cause the fw do start iscsi recovery or does it send the driver a notification that a command is failed due to the link down. For example if we were doing erl0, and the link is gone, would the fw return some error for each command?

For link down maybe you want to fire a iscsi conn error for each session/connection on the port, so that way the iscsi layer can block the sessions and start recovery.

The FW will report LINKDOWN event almost immediately when the event is noticed.

Some thoughts on the implementation

1) Rather than immediately shutting down all the sessions , wait for a predetermined
time ,say, 10 Secs(if the user has pulled the cable and is connecting it back ,for eg, to
connect to a different port on the switch etc). Since IO's will not exceed the Queue Depth, this should be fine. However, for MPIO, we may need to load with a parameter (or something better) so that we will fail immediately and IO's can be switched over to other port faster.

2) Since this function to shutdown sessions will be used by many drivers , shall we make this part of libiscsi. Can do this.

2) Since this is

2)

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

___________________________________________________________________________________
This message, together with any attachment(s), contains confidential and proprietary information of ServerEngines Corporation and is intended only for the designated recipient(s) named above. Any unauthorized review, printing, retention, copying, disclosure or distribution is strictly prohibited. If you are not the intended recipient of this message, please immediately advise the sender by reply email message and delete all copies of this message and any attachment(s). Thank you.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

4) Adds sysfs for FW commands

drivers/scsi/be2iscsi/be_main.c +30 -0

+	if (!ret_len) {
+		memcpy(buf, phba->attr_mem, count);
+		return count;
+	} else
+		return ret_len;
+}
+
+static ssize_t
+beiscsi_sysfs_fw_rd(struct kobject *kobj, struct bin_attribute *bin_attr,
+		    char *buf, loff_t off, size_t count) {
+
+	struct Scsi_Host *shost = class_to_shost(container_of(kobj,
+						 struct device, kobj));
+	struct beiscsi_hba *phba = iscsi_host_priv(shost);
+
+	memcpy(buf, phba->attr_mem, count);
+	return count;
+}
+
+static struct bin_attribute sysfs_drvr_fw_prgrm_attr = {
+	.attr = {
+		.name = "be2iscsi_fw_prgrm",
+		.mode = S_IRUSR | S_IWUSR,
+		.owner = THIS_MODULE,
+	},
+	.size = 0,
+	.read = beiscsi_sysfs_fw_rd,
+	.write = beiscsi_sysfs_fw_wr,
+};
+