Skip to contentSkip to conversation

opensm/osm_ucast_cache.c: Eliminate unneeded define

PATCH In review Hal Rosenstock 3 participants 5 messages Oct 21, 2009 – Nov 2, 2009 2 messages not in the archive InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 opensm/osm_ucast_cache.c: Eliminate unneeded define

Also, cosmetic change to OSM_LOG message

---

opensm/opensm/osm_ucast_cache.c +1 -3
index 4700c5f..09bbf33 100644
@@ -59,8 +59,6 @@
 #include <opensm/osm_node.h>
 #include <opensm/osm_port.h>
 
-#define CACHE_SW_PORTS 36
-
 typedef struct cache_port {
 	boolean_t is_leaf;
 	uint16_t remote_lid_ho;
@@ -420,7 +418,7 @@ void osm_ucast_cache_invalidate(osm_ucast_mgr_t * p_mgr)
 	}
 	cl_qmap_remove_all(&p_mgr->cache_sw_tbl);
 
-	OSM_LOG(p_mgr->p_log, OSM_LOG_VERBOSE, "Unicast Cache Invalidated.\n");
+	OSM_LOG(p_mgr->p_log, OSM_LOG_VERBOSE, "Unicast cache invalidated\n");
 Exit:
 	OSM_LOG_EXIT(p_mgr->p_log);
 }

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 7 lines · Sasha Khapyorsky
Quoted 2 lines · Hal Rosenstock

Also, cosmetic change to OSM_LOG message

Please don't mix.

I used "Unicast Cache" (with upper case starting letters) as for a name.

A nit but any reason for that one message being inconsistent (in terms of case) with the other log messages there ?

-- Hal

Quoted 4 lines
Quoted 3 lines
Quoted 8 lines

Applied with changes. Thanks.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): f0e08f230911020731v26824599xab02b93094397ec3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#5 lore raw
Quoted 3 lines · Hal Rosenstock

A nit but any reason for that one message being inconsistent (in terms of case) with the other log messages there ?

Other messages are debug printouts and cannot be compared.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#6 lore raw
Quoted 6 lines · Sasha Khapyorsky
Quoted 3 lines · Hal Rosenstock

A nit but any reason for that one message being inconsistent (in terms of case) with the other log messages there ?

Other messages are debug printouts and cannot be compared.

That seems pretty arbitrary to me. I don't think that's the case with different levels of printing elsewhere.

-- Hal

Quoted 3 lines

Sasha

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html