2.6.32-rc5 guest crash
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 5 lines · Johannes Stezenbach
Hi,
I'm using linux-2.6.32-rc5-81-g964fe08 as both host and guest, and the guest crashes on boot:
Quoted 8 lines
Calibrating delay loop...
general protection fault: 0000 [#1] PREEMPT SMP last sysfs file: Modules linked in:Pid: 0, comm: swapper Not tainted (2.6.32-rc5 #1)
EIP: 0061:[<c11f915d>] EFLAGS: 00010046 CPU: 0
EIP is atcmpxchg8b_emu+0x1/0x12
OK, it's the non-paravirt "cli" we're breaking on (the pushfl is bad too).
This is because alternatives haven't been subbed yet. The Right Thing is to make this asm code paravirt aware. The Easy Thing is to fix this code to only get included when we're actually compiling for a 386 or 486 (this was introduced with the original pentium AFAICT).
How's this Ingo, Arjan?
Subject: x86: sidestep lguest problem by only building cmpxchg8b_emu for pre-Pentium
Arjen's 79e1dd05d1a22 "x86: Provide an alternative() based cmpxchg64()" broke lguest, even on systems which have cmpxchg8b support. The emulation code gets used until alternatives get run, but it contains native instructions, not their paravirt alternatives.
The simplest fix is to turn this code off except for 386 and 486 builds.
arch/x86/Kconfig.cpu +1 -1
@@ -400,7 +400,7 @@ config X86_TSC config X86_CMPXCHG64 def_bool y - depends on X86_PAE || X86_64 || MCORE2 || MPENTIUM4 || MPENTIUMM || MPENTIUMIII || MPENTIUMII || M686 || MATOM + depends on !M386 && !M486 # this should be set for all -march=.. options where the compiler # generates cmov.
[tip:x86/urgent] x86: Side-step lguest problem by only building cmpxchg8b_emu for pre-Pentium
Commit-ID: ae1b22f6e46c03cede7cea234d0bf2253b4261cf Gitweb: http://git.kernel.org/tip/ae1b22f6e46c03cede7cea234d0bf2253b4261cf Author: Rusty Russell <[email protected]> AuthorDate: Mon, 26 Oct 2009 14:26:04 +1030 Committer: Ingo Molnar <[email protected]> CommitDate: Mon, 26 Oct 2009 12:33:02 +0100
x86: Side-step lguest problem by only building cmpxchg8b_emu for pre-Pentium
Commit 79e1dd05d1a22 "x86: Provide an alternative() based cmpxchg64()" broke lguest, even on systems which have cmpxchg8b support. The emulation code gets used until alternatives get run, but it contains native instructions, not their paravirt alternatives.
The simplest fix is to turn this code off except for 386 and 486 builds.
LKML-Reference: <[email protected]>
--- arch/x86/Kconfig.cpu | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/Kconfig.cpu +1 -1
@@ -400,7 +400,7 @@ config X86_TSC config X86_CMPXCHG64 def_bool y - depends on X86_PAE || X86_64 || MCORE2 || MPENTIUM4 || MPENTIUMM || MPENTIUMIII || MPENTIUMII || M686 || MATOM + depends on !M386 && !M486 # this should be set for all -march=.. options where the compiler # generates cmov.
Quoted 17 lines · Rusty Russell
Subject: x86: sidestep lguest problem by only building
cmpxchg8b_emufor pre-PentiumArjen's
79e1dd05d1a22"x86: Provide analternative()basedcmpxchg64()" broke lguest, even on systems which have cmpxchg8b support. The emulation code gets used until alternatives get run, but it contains native instructions, not their paravirt alternatives.The simplest fix is to turn this code off except for 386 and 486 builds.
Reported-by Johannes Stezenbach <[email protected]>Signed-off-by Rusty Russell <[email protected]>
arch/x86/Kconfig.cpu config X86_TSC · line 403
Quoted 5 lines
arch/x86/Kconfig.cpu +1
-1@@ -400,7 +400,7 @@ config X86_TSC config X86_CMPXCHG64 def_bool y - depends on X86_PAE || X86_64 || MCORE2 || MPENTIUM4 || MPENTIUMM || MPENTIUMIII || MPENTIUMII || M686 || MATOM + depends on !M386 && !M486
FWIW, I've tested it both with original host kernel (only used recompiled kernel as guest), and after reboot, the guest works in both cases and the host kernel still boots with the patch applied.
Thanks,
Johannes
[Lguest] 2.6.33 guest crash (was: Re: 2.6.32-rc5 guest crash)
In reply to Rusty RussellQuoted 5 lines · Rusty Russell
Quoted 4 lines · Johannes Stezenbach
I'm using linux-2.6.32-rc5-81-g964fe08 as both host and guest, and the guest crashes on boot:
Quoted 8 lines
Quoted 8 lines
Calibrating delay loop...
general protection fault: 0000 [#1] PREEMPT SMP last sysfs file: Modules linked in:Pid: 0, comm: swapper Not tainted (2.6.32-rc5 #1)
EIP: 0061:[<c11f915d>] EFLAGS: 00010046 CPU: 0
EIP is atcmpxchg8b_emu+0x1/0x12
I recently installed 2.6.33 and now the error which was fixed in 2.6.32 is back since the fix got reverted in db677ffa5f5a4f15b9dad4d132b3477b80766d82
What now?
Am I correct to assume that I can avoid the issue
by switching to a 64bit kernel (on host + guest)?
Quoted 29 lines
OK, it's the non-paravirt "cli" we're breaking on (the pushfl is bad too).
This is because alternatives haven't been subbed yet. The Right Thing is to make this asm code paravirt aware. The Easy Thing is to fix this code to only get included when we're actually compiling for a 386 or 486 (this was introduced with the original pentium AFAICT).
How's this Ingo, Arjan?
Subject: x86: sidestep lguest problem by only building
cmpxchg8b_emufor pre-PentiumArjen's
79e1dd05d1a22"x86: Provide analternative()basedcmpxchg64()" broke lguest, even on systems which have cmpxchg8b support. The emulation code gets used until alternatives get run, but it contains native instructions, not their paravirt alternatives.The simplest fix is to turn this code off except for 386 and 486 builds.
Reported-by Johannes Stezenbach <[email protected]>Signed-off-by Rusty Russell <[email protected]>
arch/x86/Kconfig.cpu config X86_TSC · line 406
Quoted 8 lines
arch/x86/Kconfig.cpu +1
-1@@ -400,7 +400,7 @@ config X86_TSC config X86_CMPXCHG64 def_bool y - depends on X86_PAE || X86_64 || MCORE2 || MPENTIUM4 || MPENTIUMM || MPENTIUMIII || MPENTIUMII || M686 || MATOM + depends on !M386 && !M486 # this should be set for all -march=.. options where the compiler # generates cmov.
Thanks
Johannes
Re: [Lguest] 2.6.33 guest crash (was: Re: 2.6.32-rc5 guest crash)
Quoted 3 lines · On Sun, Mar 14, 2010 at 06:34:59PM +0100, I wrote:
Am I correct to assume that I can avoid the issue
by switching to a 64bit kernel (on host + guest)?
Silly question ;-/
So what would be the real fix?
Johannes
Re: [Lguest] 2.6.33 guest crash (was: Re: 2.6.32-rc5 guest crash)
Quoted 8 lines · Johannes Stezenbach
Quoted 3 lines · On Sun, Mar 14, 2010 at 06:34:59PM +0100, I wrote:
Am I correct to assume that I can avoid the issue
by switching to a 64bit kernel (on host + guest)?Silly question ;-/
So what would be the real fix?
That patch broke Real Machines. The real answer is actually to do some more emulation in the host; I like lguest but I can't really justify many lguest-specific hacks outside the lguest dirs.
There are a few patches needed to make Linus' latest work, I'll post them soon. But for this specific issue, how's this?
Subject: lguest: workaround cmpxchg8b_emu by ignoring cli in the guest.
It's only used by cmpxchg8b_emu (see db677ffa5f5a for the gory details), and fixing that to be paravirt aware would be more work than simply ignoring it (and AFAICT only help lguest).
(We can't emulate it properly: the popf which expects to restore interrupts does not trap).
drivers/lguest/x86/core.c +12 -0
@@ -288,6 +288,18 @@ static int emulate_insn(struct lg_cpu *c insn =lgread (cpu, physaddr, u8);/* +* Around 2.6.33, the kernel started using an emulation for the +* cmpxchg8b instruction in early boot on many configurations. This +* code isn't paravirtualized, and it tries to disable interrupts. +* Ignore it, which will Mostly Work. +*/ +if (insn ==0xfa ) { +/* "cli", or Clear Interrupt Enable instruction. Skip it. */ + cpu->regs->eip++; +return 1 ; + } + +/* * 0x66 is an "operand prefix". It means it's using the upper 16 bits * of the eax register. */
Re: [Lguest] 2.6.33 guest crash
Quoted 18 lines · Rusty Russell
Quoted 9 lines · Johannes Stezenbach
Quoted 3 lines · On Sun, Mar 14, 2010 at 06:34:59PM +0100, I wrote:
Am I correct to assume that I can avoid the issue
by switching to a 64bit kernel (on host + guest)?Silly question ;-/
So what would be the real fix?
That patch broke Real Machines. The real answer is actually to do some more emulation in the host; I like lguest but I can't really justify many lguest-specific hacks outside the lguest dirs.
There are a few patches needed to make Linus' latest work, I'll post them soon. But for this specific issue, how's this?
Quoted 9 lines
Subject: lguest: workaround
cmpxchg8b_emuby ignoring cli in the guest.It's only used by
cmpxchg8b_emu(seedb677ffa5f5afor the gory details), and fixing that to be paravirt aware would be more work than simply ignoring it (and AFAICT only help lguest).(We can't emulate it properly: the popf which expects to restore interrupts does not trap).
Why isn't the cli getting paravirtualized?
J
Quoted 28 lines
Signed-off-by Rusty Russell<[email protected]>Cc Jeremy Fitzhardinge<[email protected]>drivers/lguest/x86/core.c +12
-0@@ -288,6 +288,18 @@ static int emulate_insn(struct lg_cpu *c insn =lgread (cpu, physaddr, u8);/* +* Around 2.6.33, the kernel started using an emulation for the +* cmpxchg8b instruction in early boot on many configurations. This +* code isn't paravirtualized, and it tries to disable interrupts. +* Ignore it, which will Mostly Work. +*/ +if (insn ==0xfa ) { +/* "cli", or Clear Interrupt Enable instruction. Skip it. */ + cpu->regs->eip++; +return 1 ; + } + +/* * 0x66 is an "operand prefix". It means it's using the upper 16 bits * of the eax register. */
Re: [Lguest] 2.6.33 guest crash (was: Re: 2.6.32-rc5 guest crash)
In reply to Rusty RussellHi Rusty,
Quoted 27 lines · Rusty Russell
Subject: lguest: workaround
cmpxchg8b_emuby ignoring cli in the guest.It's only used by
cmpxchg8b_emu(seedb677ffa5f5afor the gory details), and fixing that to be paravirt aware would be more work than simply ignoring it (and AFAICT only help lguest).(We can't emulate it properly: the popf which expects to restore interrupts does not trap).
Signed-off-by Rusty Russell <[email protected]>Cc Jeremy Fitzhardinge <[email protected]>drivers/lguest/x86/core.c +5
-0@@ -288,6 +288,18 @@ static int emulate_insn(struct lg_cpu *c insn =lgread (cpu, physaddr, u8);/* +* Around 2.6.33, the kernel started using an emulation for the +* cmpxchg8b instruction in early boot on many configurations. This +* code isn't paravirtualized, and it tries to disable interrupts. +* Ignore it, which will Mostly Work. +*/
drivers/lguest/x86/core.c static int emulate_insn(struct lg_cpu *c · line 305
Quoted 10 lines
drivers/lguest/x86/core.c +7
-0+if (insn ==0xfa ) { +/* "cli", or Clear Interrupt Enable instruction. Skip it. */ + cpu->regs->eip++; +return 1 ; + } + +/* * 0x66 is an "operand prefix". It means it's using the upper 16 bits * of the eax register. */
I just tested this patch with 2.6.34-rc4 (as both host and guest), it seems to work fine.
Thanks,
Johannes