Skip to contentSkip to conversation

KVM: MMU: update invlpg handler comment

PATCH Applied Marcelo Tosatti 2 participants 2 messages Oct 26, 2009 – Oct 27, 2009

Subsystems (3)
x86 KVM KVM x86
lore
Share & tools
lore

Marcelo Tosatti

author
#0 lore raw

Large page translations are always synchronized (either in level 3 or level 2), so its not necessary to properly deal with them in the invlpg handler.

Signed-off-by Marcelo Tosatti <[email protected]>
arch/x86/kvm/paging_tmpl.h +0 -1
Index: b/arch/x86/kvm/paging_tmpl.h
===================================================================
@@ -467,7 +467,6 @@ static void FNAME(invlpg)(struct kvm_vcp
 		level = iterator.level;
 		sptep = iterator.sptep;
 
-		/* FIXME: properly handle invlpg on large guest pages */
 		if (level == PT_PAGE_TABLE_LEVEL  ||
 		    ((level == PT_DIRECTORY_LEVEL && is_large_pte(*sptep))) ||
 		    ((level == PT_PDPE_LEVEL && is_large_pte(*sptep)))) {
Applied
#1 lore raw
Quoted 4 lines · Marcelo Tosatti

Large page translations are always synchronized (either in level 3 or level 2), so its not necessary to properly deal with them in the invlpg handler.

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function