opensm/osm_sm_mad_ctrl.c: In sm_mad_ctrl_send_err_cb, set init failure on PKeyTable and QoS initialization failure

PATCH Hal Rosenstock 2 participants 2 messages Oct 30, 2009 – Nov 1, 2009 4 messages not in the archive InfiniBand

Share & tools

A message that is not in the archive (sent off-list or not yet received): 20091030012213.GR20136@me

A message that is not in the archive (sent off-list or not yet received): 949139550.4222411256937590346.JavaMail.root@sz0074a.westchester.pa.mail.comcast.net

A message that is not in the archive (sent off-list or not yet received): 949139550.4222411256937590346.JavaMail.root-m8vEhog2yEGs1RcX6exeh1Wh7bxQi8rYbcbDuTDi3LmGxX56iWlbXw@public.gmane.org

Hal Rosenstock

author

2009-10-30 21:45 UTC #3 lore raw

Quoted 15 lines · Sasha Khapyorsky

Quoted 12 lines · Hal Rosenstock
Signed-off-by Hal Rosenstock <[email protected]>
---
opensm/opensm/osm_sm_mad_ctrl.c +0 -0
index 791c848..f0bc407 100644
@@ -723,7 +723,10 @@ static void sm_mad_ctrl_send_err_cb(IN void *context,
 IN osm_madw_t * p_madw)
(p_smp->attr_id == IB_MAD_ATTR_PORT_INFO || p_smp->attr_id == IB_MAD_ATTR_MCAST_FWD_TBL ||

Quoted 8 lines

Quoted 6 lines
p_smp->attr_id == IB_MAD_ATTR_SWITCH_INFO || - p_smp->attr_id == IB_MAD_ATTR_LIN_FWD_TBL)) {
+             p_smp->attr_id == IB_MAD_ATTR_LIN_FWD_TBL ||
+             p_smp->attr_id == IB_MAD_ATTR_P_KEY_TABLE ||
+             p_smp->attr_id == IB_MAD_ATTR_SLVL_TABLE ||
+ p_smp->attr_id == IB_MAD_ATTR_VL_ARBITRATION)) {
Why this change?

Why not ? Aren't these initialization failures ? Why should they be excluded ? If I recall correctly, they were originally excluded due to "newness" but that was years ago.

Quoted 1 line

Any real issue with current behavior (reporting errors and continue)?

In subnets using SL based routing seems that SLVL is critical. One might want PKey table failures to be treated similarly when partitions are configured. It's less compelling for VL arbitration.

-- Hal

Quoted 8 lines

Sasha
Quoted 4 lines
OSM_LOG(p_ctrl->p_log, OSM_LOG_ERROR, "ERR 3119: " "Set method failed for attribute 0x%X (%s)\n", cl_ntoh16(p_smp->attr_id),

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): f0e08f230910301445q6a4790aam295c254c430f0f82-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

Sasha Khapyorsky

2009-11-01 15:52 UTC #5 lore raw

Quoted 25 lines · Hal Rosenstock

Quoted 15 lines · Sasha Khapyorsky
Quoted 12 lines · Hal Rosenstock
Signed-off-by Hal Rosenstock <[email protected]>
---
opensm/opensm/osm_sm_mad_ctrl.c +0 -0
index 791c848..f0bc407 100644
@@ -723,7 +723,10 @@ static void sm_mad_ctrl_send_err_cb(IN void *context,
 IN osm_madw_t * p_madw)
(p_smp->attr_id == IB_MAD_ATTR_PORT_INFO || p_smp->attr_id == IB_MAD_ATTR_MCAST_FWD_TBL ||
Quoted 8 lines
Quoted 6 lines
p_smp->attr_id == IB_MAD_ATTR_SWITCH_INFO || - p_smp->attr_id == IB_MAD_ATTR_LIN_FWD_TBL)) {
+             p_smp->attr_id == IB_MAD_ATTR_LIN_FWD_TBL ||
+             p_smp->attr_id == IB_MAD_ATTR_P_KEY_TABLE ||
+             p_smp->attr_id == IB_MAD_ATTR_SLVL_TABLE ||
+ p_smp->attr_id == IB_MAD_ATTR_VL_ARBITRATION)) {
Why this change?

Quoted 3 lines

Why not ? Aren't these initialization failures ? Why should they be excluded ? If I recall correctly, they were originally excluded due to "newness" but that was years ago.

Ok, let's try this.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html