Skip to contentSkip to conversation

infiniband-diags/ibqueryerrors: Add support for PortXmitDiscardDetails

PATCH Applied Hal Rosenstock 4 participants 8 messages Nov 4, 2009 – Nov 16, 2009 3 messages not in the archive InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH v2 1/1 infiniband-diags/ibqueryerrors: Add support for PortXmitDiscardDetails

When --details selected, if PortCounters has transmit discards, then query PortXmitDiscardDetails. On reset, if --details is selected, then PortXmitDiscardDetails will also be reset.

Unfortunately, PortSamplesControl:OptionMask can't be trusted to determine which PortXmitDiscardDetails counters are supported so an option was added for this.

Signed-off-by Hal Rosenstock <[email protected]>

---
Changes since v1:
Better description

infiniband-diags/man/ibqueryerrors.8 +3 -1
index 1352246..d5a499e 100644
@@ -1,4 +1,4 @@
-.TH IBQUERYERRORS 8 "Jan 24, 2008" "OpenIB" "OpenIB Diagnostics"
+.TH IBQUERYERRORS 8 "Oct 30, 2009" "OpenIB" "OpenIB Diagnostics"
 
 .SH NAME
 ibqueryerrors.pl \- query and report non-zero IB port counters

@@ -58,6 +58,8 @@ printed or not.  This is because data counters are only \fBprinted\fR on ports
 which have errors.  This means if a port has 0 errors and the \-K option is
 specified the data counters will be cleared without any printed output.
 .TP
+\fB\-\-details\fR include transmit discard details
+.TP
 \fB\-R\fR  (This option is obsolete and does nothing)
 
 .SH COMMON OPTIONS
infiniband-diags/src/ibqueryerrors.c +51 -1

98 lines not on this page · raw message

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Applied
#2 lore raw
Quoted 8 lines · Hal Rosenstock

When --details selected, if PortCounters has transmit discards, then query PortXmitDiscardDetails. On reset, if --details is selected, then PortXmitDiscardDetails will also be reset.

Unfortunately, PortSamplesControl:OptionMask can't be trusted to determine which PortXmitDiscardDetails counters are supported so an option was added for this.

Interesting... Why so? Is it any bug in existing hw? Which one?

Quoted 1 line
Signed-off-by Hal Rosenstock <[email protected]>

Applied. Thanks.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 11 lines · Sasha Khapyorsky
Quoted 8 lines · Hal Rosenstock

When --details selected, if PortCounters has transmit discards, then query PortXmitDiscardDetails. On reset, if --details is selected, then PortXmitDiscardDetails will also be reset.

Unfortunately, PortSamplesControl:OptionMask can't be trusted to determine which PortXmitDiscardDetails counters are supported so an option was added for this.

Interesting... Why so? Is it any bug in existing hw? Which one?

Could you elaborate?

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
Quoted 7 lines · Sasha Khapyorsky
Quoted 6 lines · Sasha Khapyorsky
Quoted 5 lines · Hal Rosenstock

When --details selected, if PortCounters has transmit discards, then query PortXmitDiscardDetails. On reset, if --details is selected, then PortXmitDiscardDetails will also be reset.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Unfortunately, PortSamplesControl:OptionMask can't be trusted to determine which PortXmitDiscardDetails counters are supported so an option was added for this.

Interesting... Why so? Is it any bug in existing hw? Which one?

Could you elaborate?

I don't think this is the forum to discuss vendor bugs.

-- Hal

Quoted 7 lines

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): f0e08f230911130643l788ef2e5n538c123912300d42-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#6 lore raw
Quoted 12 lines · Hal Rosenstock
Quoted 11 lines · Sasha Khapyorsky
Quoted 10 lines · Sasha Khapyorsky
Quoted 8 lines · Hal Rosenstock

When --details selected, if PortCounters has transmit discards, then query PortXmitDiscardDetails. On reset, if --details is selected, then PortXmitDiscardDetails will also be reset.

Unfortunately, PortSamplesControl:OptionMask can't be trusted to determine which PortXmitDiscardDetails counters are supported so an option was added for this.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Interesting... Why so? Is it any bug in existing hw? Which one?

Could you elaborate?

I don't think this is the forum to discuss vendor bugs.

Really? If so why did you post patch here which workarounds something that you don't want to describe?

I think that it is important for developers to be aware about existing bugs which may require workarounds. Guess that this is also important for vendors since they likely want to have working products.

Anyway don't expect that next time I will apply things blindly.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#7 lore raw
Quoted 13 lines · Sasha Khapyorsky
Quoted 12 lines · Hal Rosenstock
Quoted 11 lines · Sasha Khapyorsky
Quoted 10 lines · Sasha Khapyorsky
Quoted 8 lines · Hal Rosenstock

When --details selected, if PortCounters has transmit discards, then query PortXmitDiscardDetails. On reset, if --details is selected, then PortXmitDiscardDetails will also be reset.

Unfortunately, PortSamplesControl:OptionMask can't be trusted to determine which PortXmitDiscardDetails counters are supported so an option was added for this.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Interesting... Why so? Is it any bug in existing hw? Which one?

Could you elaborate?

I don't think this is the forum to discuss vendor bugs.

Really? If so why did you post patch here which workarounds something that you don't want to describe?

I wanted to answer why it wasn't done differently (without the vendor specifics).

Quoted 5 lines

I think that it is important for developers to be aware about existing bugs which may require workarounds. Guess that this is also important for vendors since they likely want to have working products.

Anyway don't expect that next time I will apply things blindly.

Didn't seem to me that anything has been applied blindly.

-- Hal

Quoted 2 lines

Sasha

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 4AFF9714.1040708-smomgflXvOZWk0Htik3J/[email protected]

#10 lore raw
Quoted 6 lines · Or Gerlitz
Quoted 3 lines · Sasha Khapyorsky
Quoted 3 lines

I don't think this is the forum to discuss vendor bugs.

no way we can commit here a fix for undocumented bug

The bug is documented. What is broken is indicated in the patch description. The only thing omitted is the vendor/device. I think it violates vendor confidentiality to go further and I'm not in a position to do that.

-- Hal

Quoted 4 lines

Or.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html