Skip to contentSkip to conversation

hwmon: (adt7475) Cache limits for 60 seconds

PATCH In review Jean Delvare 2 participants 2 messages Nov 9, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (adt7475) Cache limits for 60 seconds

The comment says that limits are cached for 60 seconds but the code actually caches them for only 2 seconds. Align the code on the comment, as 60 seconds make more sense.

Cc Hans de Goede <[email protected]>
Cc Jordan Crouse <[email protected]>
---
 drivers/hwmon/adt7475.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/adt7475.c +1 -1
@@ -1151,7 +1151,7 @@ static struct adt7475_data *adt7475_upda
 	}
 
 	/* Limits and settings, should never change update every 60 seconds */
-	if (time_after(jiffies, data->limits_updated + HZ * 2) ||
+	if (time_after(jiffies, data->limits_updated + HZ * 60) ||
 	    !data->valid) {
 		data->config5 = adt7475_read(REG_CONFIG5);
 
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#1 lore raw

Re: [lm-sensors] [PATCH] hwmon: (adt7475) Cache limits for 60

Ack.

Quoted 16 lines · Jean Delvare

The comment says that limits are cached for 60 seconds but the code actually caches them for only 2 seconds. Align the code on the comment, as 60 seconds make more sense.

Cc Hans de Goede<[email protected]>
Cc Jordan Crouse<[email protected]>
---
  drivers/hwmon/adt7475.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

drivers/hwmon/adt7475.c static struct adt7475_data *adt7475_upda · line 1157

Quoted 8 lines
drivers/hwmon/adt7475.c +1 -1
@@ -1151,7 +1151,7 @@ static struct adt7475_data *adt7475_upda
  	}
 
  	/* Limits and settings, should never change update every 60 seconds */
-	if (time_after(jiffies, data->limits_updated + HZ * 2) ||
+	if (time_after(jiffies, data->limits_updated + HZ * 60) ||
  	    !data->valid) {
  		data->config5 = adt7475_read(REG_CONFIG5);
 

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors