Skip to contentSkip to conversation

Lots of tcp_recvmsg warnings in kerneloops list

DISCUSSION Stephen Hemminger 2 participants 2 messages Nov 13, 2009

Subsystems (2)
lore
Share & tools
lore
#1 lore raw
Quoted 4 lines · Stephen Hemminger

Has anyone looked into this? Is there a fix? Should it be sent to stable?

http://kerneloops.org/searchweek.php?search=tcp_recvmsg
--

Only debugging AFAIK, no discoveries yet.

commit c62f4c453ab4b0240ab857bfd089da2c01ad91e7

Author: Arjan van de Ven <[email protected]>
Date:   Thu Oct 22 21:37:56 2009 -0700

net: use WARN() for the WARN_ON in commit b6b39e8f3fbbb

Commit b6b39e8f3fbbb (tcp: Try to catch MSG_PEEK bug) added a printk() to the WARN_ON() that's in tcp.c. This patch changes this combination to WARN(); the advantage of WARN() is that the printk message shows up inside the message, so that kerneloops.org will collect the message.

In addition, this gets rid of an extra if() statement.

commit b6b39e8f3fbbb31001b836afec87bcaf4811a7bf

Author: Herbert Xu <[email protected]>
Date:   Mon Oct 19 19:41:06 2009 +0000

tcp: Try to catch MSG_PEEK bug

This patch tries to print out more information when we hit the MSG_PEEK bug in tcp_recvmsg. It's been around since at least 2005 and it's about time that we finally fix it.