Skip to contentSkip to conversation

mpt2sas : missing initialization of scsih_cmds is included

PATCH In review Kashyap, Desai 1 participant 2 messages Nov 17, 2009 – Dec 7, 2009 SCSI

lore
Share & tools
lore

Kashyap, Desai

author
#0 lore raw

PATCH 1/1 mpt2sas : missing initialization of scsih_cmds is included

Internal command scsih_cmds init is included in mpt2sas_base_attach.

Signed-off-by Kashyap Desai <[email protected]>

---

drivers/scsi/mpt2sas/mpt2sas_base.c +5 -0
index 6422e25..89d0240 100644
@@ -3583,6 +3583,11 @@ mpt2sas_base_attach(struct MPT2SAS_ADAPTER *ioc)
 	ioc->transport_cmds.status = MPT2_CMD_NOT_USED;
 	mutex_init(&ioc->transport_cmds.mutex);
 
+	/* scsih internal command bits */
+	ioc->scsih_cmds.reply = kzalloc(ioc->reply_sz, GFP_KERNEL);
+	ioc->scsih_cmds.status = MPT2_CMD_NOT_USED;
+	mutex_init(&ioc->scsih_cmds.mutex);
+
 	/* task management internal command bits */
 	ioc->tm_cmds.reply = kzalloc(ioc->reply_sz, GFP_KERNEL);
 	ioc->tm_cmds.status = MPT2_CMD_NOT_USED;
author
#1 lore raw

James,

This patch is fix in mpt2sas 03.100.03.00 included in 2.6.33. Can you please include this patch in 2.6.33?

- Kashyap

Quoted 30 lines

-----Original Message-----
From: Kashyap, Desai [mailto:[email protected]]
Sent: Tuesday, November 17, 2009 1:17 PM
To: [email protected]
Cc: [email protected]; Moore, Eric; Prakash, Sathya
Subject: [PATCH] mpt2sas : missing initialization of scsih_cmds is included

Internal command scsih_cmds init is included in mpt2sas_base_attach.

Signed-off-by Kashyap Desai <[email protected]>

---

drivers/scsi/mpt2sas/mpt2sas_base.c +5 -0
index 6422e25..89d0240 100644
@@ -3583,6 +3583,11 @@ mpt2sas_base_attach(struct MPT2SAS_ADAPTER *ioc)
 	ioc->transport_cmds.status = MPT2_CMD_NOT_USED;
 	mutex_init(&ioc->transport_cmds.mutex);
 
+	/* scsih internal command bits */
+	ioc->scsih_cmds.reply = kzalloc(ioc->reply_sz, GFP_KERNEL);
+	ioc->scsih_cmds.status = MPT2_CMD_NOT_USED;
+	mutex_init(&ioc->scsih_cmds.mutex);
+
 	/* task management internal command bits */
 	ioc->tm_cmds.reply = kzalloc(ioc->reply_sz, GFP_KERNEL);
 	ioc->tm_cmds.status = MPT2_CMD_NOT_USED;