scsi/pmcraid: redundant check in pmcraid_check_ioctl_buffer()?

PATCH In review [email protected] 1 participant 1 message Nov 17, 2009

Subsystems (2)

SCSI PMC sierra MaxRAID driver

lore

Share & tools

lore

[email protected]

author

2009-11-17 22:56 UTC #0 lore raw

PATCH 18/18 scsi/pmcraid: redundant check in pmcraid_check_ioctl_buffer()?

From: Roel Kluin <[email protected]>

struct pmcraid_ioctl_header member buffer_length is unsigned, so this check appears redundant.

Signed-off-by Roel Kluin <[email protected]>

Acked-by Anil Ravindranath <[email protected]>

Cc James Bottomley <[email protected]>

Signed-off-by Andrew Morton <[email protected]>

---

 drivers/scsi/pmcraid.c |    6 ------
 1 file changed, 6 deletions(-)

drivers/scsi/pmcraid.c renamed from drivers/scsi/pmcraid.c~scsi-pmcraid-redundant-check-in-pmcraid_check_ioctl_buffer +0 -6

diff -puN drivers/scsi/pmcraid.c~scsi-pmcraid-redundant-check-in-pmcraid_check_ioctl_buffer drivers/scsi/pmcraid.c
@@ -3736,12 +3736,6 @@ static int pmcraid_check_ioctl_buffer(
 		return -EINVAL;
 	}
 
-	/* buffer length can't be negetive */
-	if (hdr->buffer_length < 0) {
-		pmcraid_err("ioctl: invalid buffer length specified\n");
-		return -EINVAL;
-	}
-
 	/* check for appropriate buffer access */
 	if ((_IOC_DIR(cmd) & _IOC_READ) == _IOC_READ)
 		access = VERIFY_WRITE;