Skip to contentSkip to conversation

bttv locking problem

DISCUSSION Dan Carpenter 1 participant 1 message Nov 29, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hello,

I did a smatch static checker run and found a double unlock in
bttv-driver.c.
drivers/media/video/bt8xx/bttv-driver.c +3203 bttv_poll() error: double unlock '&fh->cap.vb_lock' I would fix it myself, but I don't know if the poll_wait() is supposed
to be protected by mutex_unlock(&fh->cap.vb_lock) or not.

drivers/media/video/bt8xx/bttv-driver.c
3192 mutex_unlock(&fh->cap.vb_lock);
3193 buf = (struct bttv_buffer*)fh->cap.read_buf;
3194 }
3195
3196 poll_wait(file, &buf->vb.done, wait);
3197 if (buf->vb.state == VIDEOBUF_DONE ||
3198 buf->vb.state == VIDEOBUF_ERROR)
3199 rc = POLLIN|POLLRDNORM;
3200 else
3201 rc = 0;
3202 err:
3203 mutex_unlock(&fh->cap.vb_lock);

regards,
dan carpenter