Skip to contentSkip to conversation

'sysctl_max_map_count' should be non-negative

PATCH New Amerigo Wang 1 participant 1 message Nov 30, 2009 Proc sysctl

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 'sysctl_max_map_count' should be non-negative

Jan Engelhardt reported we have this problem:

setting max_map_count to a value large enough results in programs dying at first try.
This is on 2.6.31.6.

15:59 borg:/proc/sys/vm # echo $[1<<31-1] >max_map_count 15:59 borg:/proc/sys/vm # cat max_map_count 1073741824
15:59 borg:/proc/sys/vm # echo $[1<<31] >max_map_count 15:59 borg:/proc/sys/vm # cat max_map_count Killed

This is because we have a chance to make 'max_map_count' negative. but it's meaningless. Make it only accept non-negative values.

Cc Ingo Molnar <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc James Morris <[email protected]>
Cc Alexey Dobriyan <[email protected]>

---

kernel/sysctl.c +2 -1
index 0d949c5..212360e 100644
@@ -1245,7 +1245,8 @@ static struct ctl_table vm_table[] = {
 		.data		= &sysctl_max_map_count,
 		.maxlen		= sizeof(sysctl_max_map_count),
 		.mode		= 0644,
-		.proc_handler	= &proc_dointvec
+		.proc_handler	= &proc_dointvec_minmax,
+		.extra1		= &zero,
 	},
 #else
 	{