Skip to contentSkip to conversation

fs: move a definition out of switch block

PATCH New Amerigo Wang 1 participant 1 message Nov 30, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: move a definition out of switch block

It's not a good practice to leave a definition between 'switch' and the its first label.

Move it out of the switch block.

Cc Matthew Wilcox <[email protected]>
Cc Alexander Viro <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Oleg Nesterov <[email protected]>
Cc Christoph Hellwig <[email protected]>

---

fs/fcntl.c +1 -1
index 2cf93ec..23b0238 100644
@@ -514,12 +514,12 @@ static void send_sigio_to_task(struct task_struct *p,
 	 * sure we read it once and use the same value throughout.
 	 */
 	int signum = ACCESS_ONCE(fown->signum);
+	siginfo_t si;
 
 	if (!sigio_perm(p, fown, signum))
 		return;
 
 	switch (signum) {
-		siginfo_t si;
 		default:
 			/* Queue a rt signal with the appropriate fd as its
 			   value.  We use SI_SIGIO as the source, not