Skip to contentSkip to conversation

Spatial multiplexing powersave (client support)

PATCH In review Johannes Berg 3 participants 12 messages Nov 30, 2009 – Dec 1, 2009

Subsystems (3)
lore
Share & tools
lore

Johannes Berg

author maintainer
#0 lore raw

cover Spatial multiplexing powersave (client support)

These two patches implement spatial multiplexing power save along with sending action frames if userspace requests changes while associated.

The default is being in dynamic SM PS when powersave is requested, and SM PS turned off when not in powersave. Right now, only station interfaces are supported.

johannes

author maintainer
#1 lore raw

PATCH 1/2 cfg80211: add SM PS hooks

Add spatial multiplexing power save configuration
hooks to cfg80211/nl80211.

---
 include/linux/nl80211.h |   32 ++++++++++++++++++++++++++++++++
 include/net/cfg80211.h  |    5 ++++-
 net/wireless/nl80211.c  |   21 +++++++++++++++++++++
 3 files changed, 57 insertions(+), 1 deletion(-)
include/linux/nl80211.h +32 -0
@@ -606,6 +606,11 @@ enum nl80211_commands {
  * @NL80211_ATTR_MAX_NUM_PMKIDS: maximum number of PMKIDs a firmware can
  *	cache, a wiphy attribute.
  *
+ * @NL80211_ATTR_SMPS_MODE: Used with change interface, this will set the
+ *	desired spatial multiplexing powersave mode for a device. Due to
+ *	multiple virtual interfaces it might not always be the mode that
+ *	actually ends up being used.
+ *
  * @NL80211_ATTR_MAX: highest attribute number currently defined
  * @__NL80211_ATTR_AFTER_LAST: internal use
  */
@@ -743,6 +748,8 @@ enum nl80211_attrs {
 	NL80211_ATTR_PMKID,
 	NL80211_ATTR_MAX_NUM_PMKIDS,
 
+	NL80211_ATTR_SMPS_MODE,
+
 	/* add attributes here, update the policy in nl80211.c */
 
 	__NL80211_ATTR_AFTER_LAST,
@@ -1442,4 +1449,29 @@ enum nl80211_key_attributes {
 	NL80211_KEY_MAX = __NL80211_KEY_AFTER_LAST - 1
 };
 
+/**
+ * enum nl80211_smps_mode - spatial multiplexing powersave mode
+ *
+ * @NL80211_SMPS_AUTOMATIC: automatic SM PS, i.e. enable
+ *	dynamic SM PS if supported and in powersave, disable
+ *	SM PS when powersave is turned off. This is the default
+ *	mode for HT devices if they support SM PS.
+ * @NL80211_SMPS_OFF: SM PS turned off, i.e. all chains on
+ * @NL80211_SMPS_STATIC: static SM PS, i.e. using a single chain
+ * @NL80211_SMPS_DYNAMIC: dynamic SM PS, i.e. chains turned on
+ *	after, for example, rts/cts handshake
+ * @__NL80211_SMPS_NUM: internal
+ * @NL80211_SMPS_MAX: largest allowed smps value
+ */
+enum nl80211_smps_mode {
+	NL80211_SMPS_AUTOMATIC,
+	NL80211_SMPS_OFF,
+	NL80211_SMPS_STATIC,
+	NL80211_SMPS_DYNAMIC,
+
+	/* keep last */
+	__NL80211_SMPS_NUM,
+	NL80211_SMPS_MAX = __NL80211_SMPS_NUM - 1,
+};
+
 #endif /* __LINUX_NL80211_H */
net/wireless/nl80211.c +21 -0
@@ -141,6 +141,7 @@ static struct nla_policy nl80211_policy[
 	[NL80211_ATTR_4ADDR] = { .type = NLA_U8 },
 	[NL80211_ATTR_PMKID] = { .type = NLA_BINARY,
 				 .len = WLAN_PMKID_LEN },
+	[NL80211_ATTR_SMPS_MODE] = { .type = NLA_U32 },
 };
 
 /* policy for the attributes */
@@ -1052,6 +1053,26 @@ static int nl80211_set_interface(struct 
 		params.use_4addr = -1;
 	}
 
+	if (info->attrs[NL80211_ATTR_SMPS_MODE]) {
+		enum nl80211_smps_mode smps_mode;
+
+		smps_mode = nla_get_u32(info->attrs[NL80211_ATTR_SMPS_MODE]);
+
+		if (smps_mode > NL80211_SMPS_MAX) {
+			err = -EINVAL;
+			goto unlock;
+		}
+
+		if (!rdev->ops->set_smps) {
+			err = -EOPNOTSUPP;
+			goto unlock;
+		}
+
+		err = rdev->ops->set_smps(&rdev->wiphy, dev, smps_mode);
+		if (err)
+			goto unlock;
+	}
+
 	if (info->attrs[NL80211_ATTR_MNTR_FLAGS]) {
 		if (ntype != NL80211_IFTYPE_MONITOR) {
 			err = -EINVAL;
include/net/cfg80211.h +4 -1
@@ -1115,7 +1115,10 @@ struct cfg80211_ops {
 				    const struct cfg80211_bitrate_mask *mask);
 
 	int	(*dump_survey)(struct wiphy *wiphy, struct net_device *netdev,
-			int idx, struct survey_info *info);
+			       int idx, struct survey_info *info);
+
+	int	(*set_smps)(struct wiphy *wiphy, struct net_device *netdev,
+			    enum nl80211_smps_mode smps_mode);
 
 	int	(*set_pmksa)(struct wiphy *wiphy, struct net_device *netdev,
 			     struct cfg80211_pmksa *pmksa);
author maintainer
#5 lore raw

PATCH 2/2 mac80211: enable spatial multiplexing powersave

In reply to Johannes Berg

Enable spatial multiplexing in mac80211 by telling the driver what to do and, where necessary, sending action frames to the AP to update the requested SMPS mode.

Also includes a trivial implementation for hwsim that just logs the requested mode.

---
 drivers/net/wireless/mac80211_hwsim.c |   22 ++++++++-
 include/linux/ieee80211.h             |   25 ++++++++++-
 include/net/mac80211.h                |   44 +++++++++++++++++++
 net/mac80211/cfg.c                    |   75 ++++++++++++++++++++++++++++++++++
 net/mac80211/driver-trace.h           |    2 
 net/mac80211/ht.c                     |   47 +++++++++++++++++++++
 net/mac80211/ieee80211_i.h            |   12 +++++
 net/mac80211/main.c                   |   24 ++++++++++
 net/mac80211/mlme.c                   |   63 ++++++++++++++++++++++++++--
 net/mac80211/status.c                 |   38 +++++++++++++++++
 net/mac80211/util.c                   |   74 +++++++++++++++++++++++++++++++++
 11 files changed, 418 insertions(+), 8 deletions(-)
include/net/mac80211.h +44 -0
@@ -597,8 +597,10 @@ enum ieee80211_conf_flags {
  * @IEEE80211_CONF_CHANGE_CHANNEL: the channel/channel_type changed
  * @IEEE80211_CONF_CHANGE_RETRY_LIMITS: retry limits changed
  * @IEEE80211_CONF_CHANGE_IDLE: Idle flag changed
+ * @IEEE80211_CONF_CHANGE_SMPS: Spatial multiplexing powersave mode changed
  */
 enum ieee80211_conf_changed {
+	IEEE80211_CONF_CHANGE_SMPS		= BIT(1),
 	IEEE80211_CONF_CHANGE_LISTEN_INTERVAL	= BIT(2),
 	IEEE80211_CONF_CHANGE_MONITOR		= BIT(3),
 	IEEE80211_CONF_CHANGE_PS		= BIT(4),
@@ -636,6 +638,10 @@ enum ieee80211_conf_changed {
  * @short_frame_max_tx_count: Maximum number of transmissions for a "short"
  *    frame, called "dot11ShortRetryLimit" in 802.11, but actually means the
  *    number of transmissions not the number of retries
+ *
+ * @smps_mode: spatial multiplexing powersave mode; note that
+ *	%NL80211_SMPS_STATIC is used when the device is not
+ *	configured for an HT channel
  */
 struct ieee80211_conf {
 	u32 flags;
@@ -648,6 +654,7 @@ struct ieee80211_conf {
 
 	struct ieee80211_channel *channel;
 	enum nl80211_channel_type channel_type;
+	enum nl80211_smps_mode smps_mode;
 };
 
 /**
@@ -930,6 +937,16 @@ enum ieee80211_tkip_key_type {
  * @IEEE80211_HW_BEACON_FILTER:
  *	Hardware supports dropping of irrelevant beacon frames to
  *	avoid waking up cpu.
+ *
+ * @IEEE80211_HW_SUPPORTS_STATIC_SMPS:
+ *	Hardware supports static spatial multiplexing powersave,
+ *	ie. can turn off all but one chain even on HT connections
+ *	that should be using more chains.
+ *
+ * @IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS:
+ *	Hardware supports dynamic spatial multiplexing powersave,
+ *	ie. can turn off all but one chain and then wake the rest
+ *	up as required after, for example, rts/cts handshake.
  */
 enum ieee80211_hw_flags {
 	IEEE80211_HW_HAS_RATE_CONTROL			= 1<<0,
@@ -947,6 +964,8 @@ enum ieee80211_hw_flags {
 	IEEE80211_HW_SUPPORTS_DYNAMIC_PS		= 1<<12,
 	IEEE80211_HW_MFP_CAPABLE			= 1<<13,
 	IEEE80211_HW_BEACON_FILTER			= 1<<14,
+	IEEE80211_HW_SUPPORTS_STATIC_SMPS		= 1<<15,
+	IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS		= 1<<16,
 };
 
 /**
@@ -1215,6 +1234,31 @@ ieee80211_get_alt_retry_rate(const struc
  */
 
 /**
+ * DOC: Spatial multiplexing power save
+ *
+ * SMPS (Spatial multiplexing power save) is a mechanism to conserve
+ * power in an 802.11n implementation. For details on the mechanism
+ * and rationale, please refer to 802.11 (as amended by 802.11n-2009)
+ * "11.2.3 SM power save".
+ *
+ * The mac80211 implementation is capable of sending action frames
+ * to update the AP about the station's SMPS mode, and will instruct
+ * the driver to enter the specific mode. It will also announce the
+ * requested SMPS mode during the association handshake. Hardware
+ * support for this feature is required, and can be indicated by
+ * hardware flags.
+ *
+ * The default mode will be "automatic", which nl80211/cfg80211
+ * defines to be dynamic SMPS in (regular) powersave, and SMPS
+ * turned off otherwise.
+ *
+ * To support this feature, the driver must set the appropriate
+ * hardware support flags, and handle the SMPS flag to the config()
+ * operation. It will then with this mechanism be instructed to
+ * enter the requested SMPS mode while associated to an HT AP.
+ */
+
+/**
  * DOC: Frame filtering
  *
  * mac80211 requires to see many management frames for proper
net/mac80211/ieee80211_i.h +12 -0
@@ -297,6 +297,8 @@ struct ieee80211_if_managed {
 
 	unsigned long timers_running; /* used for quiesce/restart */
 	bool powersave; /* powersave requested for this iface */
+	enum nl80211_smps_mode req_smps, /* requested smps mode */
+			       ap_smps; /* smps mode AP thinks we're in */
 
 	unsigned long request;
 
@@ -587,6 +589,9 @@ struct ieee80211_local {
 	/* used for uploading changed mc list */
 	struct work_struct reconfig_filter;
 
+	/* used to reconfigure hardware SM PS */
+	struct work_struct recalc_smps;
+
 	/* aggregated multicast list */
 	struct dev_addr_list *mc_list;
 	int mc_count;
@@ -760,6 +765,8 @@ struct ieee80211_local {
 	int user_power_level; /* in dBm */
 	int power_constr_level; /* in dBm */
 
+	enum nl80211_smps_mode smps_mode;
+
 	struct work_struct restart_work;
 
 #ifdef CONFIG_MAC80211_DEBUGFS
@@ -983,6 +990,9 @@ void ieee80211_send_bar(struct ieee80211
 void ieee80211_send_delba(struct ieee80211_sub_if_data *sdata,
 			  const u8 *da, u16 tid,
 			  u16 initiator, u16 reason_code);
+int ieee80211_send_smps_action(struct ieee80211_sub_if_data *sdata,
+			       enum nl80211_smps_mode smps, const u8 *da,
+			       const u8 *bssid);
 
 void ieee80211_sta_stop_rx_ba_session(struct ieee80211_sub_if_data *sdata, u8 *da,
 				u16 tid, u16 initiator, u16 reason);
@@ -1093,6 +1103,8 @@ void ieee80211_sta_def_wmm_params(struct
 u32 ieee80211_sta_get_rates(struct ieee80211_local *local,
 			    struct ieee802_11_elems *elems,
 			    enum ieee80211_band band);
+void ieee80211_recalc_smps(struct ieee80211_local *local,
+			   struct ieee80211_sub_if_data *forsdata);
 
 #ifdef CONFIG_MAC80211_NOINLINE
 #define debug_noinline noinline
net/mac80211/cfg.c +75 -0

97 lines not on this page · raw message

include/linux/ieee80211.h +24 -1
@@ -707,6 +707,10 @@ struct ieee80211_mgmt {
 					u8 action;
 					u8 trans_id[WLAN_SA_QUERY_TR_ID_LEN];
 				} __attribute__ ((packed)) sa_query;
+				struct {
+					u8 action;
+					u8 smps_control;
+				} __attribute__ ((packed)) ht_smps;
 			} u;
 		} __attribute__ ((packed)) action;
 	} u;
@@ -824,6 +828,7 @@ struct ieee80211_ht_cap {
 #define IEEE80211_HT_CAP_LDPC_CODING		0x0001
 #define IEEE80211_HT_CAP_SUP_WIDTH_20_40	0x0002
 #define IEEE80211_HT_CAP_SM_PS			0x000C
+#define		IEEE80211_HT_CAP_SM_PS_SHIFT	2
 #define IEEE80211_HT_CAP_GRN_FLD		0x0010
 #define IEEE80211_HT_CAP_SGI_20			0x0020
 #define IEEE80211_HT_CAP_SGI_40			0x0040
@@ -839,6 +844,7 @@ struct ieee80211_ht_cap {
 /* 802.11n HT capability AMPDU settings (for ampdu_params_info) */
 #define IEEE80211_HT_AMPDU_PARM_FACTOR		0x03
 #define IEEE80211_HT_AMPDU_PARM_DENSITY		0x1C
+#define		IEEE80211_HT_AMPDU_PARM_DENSITY_SHIFT	2
 
 /*
  * Maximum length of AMPDU that the STA can receive.
@@ -922,12 +928,17 @@ struct ieee80211_ht_info {
 #define IEEE80211_MAX_AMPDU_BUF 0x40
 
 
-/* Spatial Multiplexing Power Save Modes */
+/* Spatial Multiplexing Power Save Modes (for capability) */
 #define WLAN_HT_CAP_SM_PS_STATIC	0
 #define WLAN_HT_CAP_SM_PS_DYNAMIC	1
 #define WLAN_HT_CAP_SM_PS_INVALID	2
 #define WLAN_HT_CAP_SM_PS_DISABLED	3
 
+/* for SM power control field lower two bits */
+#define WLAN_HT_SMPS_CONTROL_DISABLED	0
+#define WLAN_HT_SMPS_CONTROL_STATIC	1
+#define WLAN_HT_SMPS_CONTROL_DYNAMIC	3
+
 /* Authentication algorithms */
 #define WLAN_AUTH_OPEN 0
 #define WLAN_AUTH_SHARED_KEY 1
@@ -1150,6 +1161,18 @@ enum ieee80211_spectrum_mgmt_actioncode 
 	WLAN_ACTION_SPCT_CHL_SWITCH = 4,
 };
 
+/* HT action codes */
+enum ieee80211_ht_actioncode {
+	WLAN_HT_ACTION_NOTIFY_CHANWIDTH = 0,
+	WLAN_HT_ACTION_SMPS = 1,
+	WLAN_HT_ACTION_PSMP = 2,
+	WLAN_HT_ACTION_PCO_PHASE = 3,
+	WLAN_HT_ACTION_CSI = 4,
+	WLAN_HT_ACTION_NONCOMPRESSED_BF = 5,
+	WLAN_HT_ACTION_COMPRESSED_BF = 6,
+	WLAN_HT_ACTION_ASEL_IDX_FEEDBACK = 7,
+};
+
 /* Security key length */
 enum ieee80211_key_len {
 	WLAN_KEY_LEN_WEP40 = 5,
net/mac80211/mlme.c +59 -4

94 lines not on this page · raw message

net/mac80211/ht.c +47 -0

50 lines not on this page · raw message

net/mac80211/status.c +38 -0
@@ -134,6 +134,40 @@ static void ieee80211_handle_filtered_fr
 	dev_kfree_skb(skb);
 }
 
+static void ieee80211_frame_acked(struct sta_info *sta, struct sk_buff *skb)
+{
+	struct ieee80211_mgmt *mgmt = (void *) skb->data;
+	struct ieee80211_local *local = sta->local;
+	struct ieee80211_sub_if_data *sdata = sta->sdata;
+
+	if (ieee80211_is_action(mgmt->frame_control) &&
+	    sdata->vif.type == NL80211_IFTYPE_STATION &&
+	    mgmt->u.action.category == WLAN_CATEGORY_HT &&
+	    mgmt->u.action.u.ht_smps.action == WLAN_HT_ACTION_SMPS) {
+		/*
+		 * This update looks racy, but isn't -- if we come
+		 * here we've definitely got a station that we're
+		 * talking to, and on a managed interface that can
+		 * only be the AP. And the only other place updating
+		 * this variable is before we're associated.
+		 */
+		switch (mgmt->u.action.u.ht_smps.smps_control) {
+		case WLAN_HT_SMPS_CONTROL_DYNAMIC:
+			sta->sdata->u.mgd.ap_smps = NL80211_SMPS_DYNAMIC;
+			break;
+		case WLAN_HT_SMPS_CONTROL_STATIC:
+			sta->sdata->u.mgd.ap_smps = NL80211_SMPS_STATIC;
+			break;
+		case WLAN_HT_SMPS_CONTROL_DISABLED:
+		default: /* shouldn't happen since we don't send that */
+			sta->sdata->u.mgd.ap_smps = NL80211_SMPS_OFF;
+			break;
+		}
+
+		ieee80211_queue_work(&local->hw, &local->recalc_smps);
+	}
+}
+
 void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
 {
 	struct sk_buff *skb2;
@@ -209,6 +243,10 @@ void ieee80211_tx_status(struct ieee8021
 		rate_control_tx_status(local, sband, sta, skb);
 		if (ieee80211_vif_is_mesh(&sta->sdata->vif))
 			ieee80211s_update_metric(local, sta, skb);
+
+		if (!(info->flags & IEEE80211_TX_CTL_INJECTED) &&
+		    (info->flags & IEEE80211_TX_STAT_ACK))
+			ieee80211_frame_acked(sta, skb);
 	}
 
 	rcu_read_unlock();
net/mac80211/main.c +24 -0
@@ -113,6 +113,18 @@ int ieee80211_hw_config(struct ieee80211
 		changed |= IEEE80211_CONF_CHANGE_CHANNEL;
 	}
 
+	if (!conf_is_ht(&local->hw.conf)) {
+		/*
+		 * mac80211.h documents that this is only valid
+		 * when the channel is set to an HT type, and
+		 * that otherwise STATIC is used.
+		 */
+		local->hw.conf.smps_mode = NL80211_SMPS_STATIC;
+	} else if (local->hw.conf.smps_mode != local->smps_mode) {
+		local->hw.conf.smps_mode = local->smps_mode;
+		changed |= IEEE80211_CONF_CHANGE_SMPS;
+	}
+
 	if (scan_chan)
 		power = chan->max_power;
 	else
@@ -297,6 +309,16 @@ void ieee80211_restart_hw(struct ieee802
 }
 EXPORT_SYMBOL(ieee80211_restart_hw);
 
+static void ieee80211_recalc_smps_work(struct work_struct *work)
+{
+	struct ieee80211_local *local =
+		container_of(work, struct ieee80211_local, recalc_smps);
+
+	mutex_lock(&local->iflist_mtx);
+	ieee80211_recalc_smps(local, NULL);
+	mutex_unlock(&local->iflist_mtx);
+}
+
 struct ieee80211_hw *ieee80211_alloc_hw(size_t priv_data_len,
 					const struct ieee80211_ops *ops)
 {
@@ -370,6 +392,8 @@ struct ieee80211_hw *ieee80211_alloc_hw(
 	INIT_WORK(&local->restart_work, ieee80211_restart_work);
 
 	INIT_WORK(&local->reconfig_filter, ieee80211_reconfig_filter);
+	INIT_WORK(&local->recalc_smps, ieee80211_recalc_smps_work);
+	local->smps_mode = NL80211_SMPS_OFF;
 
 	INIT_WORK(&local->dynamic_ps_enable_work,
 		  ieee80211_dynamic_ps_enable_work);
net/mac80211/util.c +74 -0

77 lines not on this page · raw message

drivers/net/wireless/mac80211_hwsim.c +19 -3
@@ -619,12 +619,26 @@ static int mac80211_hwsim_config(struct 
 {
 	struct mac80211_hwsim_data *data = hw->priv;
 	struct ieee80211_conf *conf = &hw->conf;
+	static const char *chantypes[4] = {
+		[NL80211_CHAN_NO_HT] = "noht",
+		[NL80211_CHAN_HT20] = "ht20",
+		[NL80211_CHAN_HT40MINUS] = "ht40-",
+		[NL80211_CHAN_HT40PLUS] = "ht40+",
+	};
+	static const char *smps_modes[__NL80211_SMPS_NUM] = {
+		[NL80211_SMPS_AUTOMATIC] = "auto/invalid",
+		[NL80211_SMPS_OFF] = "off",
+		[NL80211_SMPS_STATIC] = "static",
+		[NL80211_SMPS_DYNAMIC] = "dynamic",
+	};
 
-	printk(KERN_DEBUG "%s:%s (freq=%d idle=%d ps=%d)\n",
+	printk(KERN_DEBUG "%s:%s (freq=%d/%s idle=%d ps=%d smps=%s)\n",
 	       wiphy_name(hw->wiphy), __func__,
 	       conf->channel->center_freq,
+	       chantypes[conf->channel_type],
 	       !!(conf->flags & IEEE80211_CONF_IDLE),
-	       !!(conf->flags & IEEE80211_CONF_PS));
+	       !!(conf->flags & IEEE80211_CONF_PS),
+	       smps_modes[conf->smps_mode]);
 
 	data->idle = !!(conf->flags & IEEE80211_CONF_IDLE);
 
@@ -1121,7 +1135,9 @@ static int __init init_mac80211_hwsim(vo
 			BIT(NL80211_IFTYPE_MESH_POINT);
 
 		hw->flags = IEEE80211_HW_MFP_CAPABLE |
-			    IEEE80211_HW_SIGNAL_DBM;
+			    IEEE80211_HW_SIGNAL_DBM |
+			    IEEE80211_HW_SUPPORTS_STATIC_SMPS |
+			    IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS;
 
 		/* ask mac80211 to reserve space for magic */
 		hw->vif_data_size = sizeof(struct hwsim_vif_priv);
net/mac80211/driver-trace.h +2 -0
@@ -140,6 +140,7 @@ TRACE_EVENT(drv_config,
 		__field(u8, short_frame_max_tx_count)
 		__field(int, center_freq)
 		__field(int, channel_type)
+		__field(int, smps)
 	),
 
 	TP_fast_assign(
@@ -155,6 +156,7 @@ TRACE_EVENT(drv_config,
 		__entry->short_frame_max_tx_count = local->hw.conf.short_frame_max_tx_count;
 		__entry->center_freq = local->hw.conf.channel->center_freq;
 		__entry->channel_type = local->hw.conf.channel_type;
+		__entry->smps = local->hw.conf.smps_mode;
 	),
 
 	TP_printk(
#6 lore raw

Re: [PATCH 2/2] mac80211: enable spatial multiplexing powersave

Quoted 7 lines
net/mac80211/cfg.c 2009-11-29 11:40:29.000000000 +0100 renamed from net/mac80211/cfg.c    2009-11-29 11:33:00.000000000 +0100 +1 -0
@@ -1316,6 +1316,54 @@ static int ieee80211_testmode_cmd(struct
  }
  #endif
 
+static int ieee80211_request_smps(struct ieee80211_sub_if_data *sdata,

net/mac80211/cfg.c 2009-11-29 11:40:29.000000000 +0100 static int ieee80211_testmode_cmd(struct · line 1329

Quoted 10 lines
net/mac80211/cfg.c 2009-11-29 11:40:29.000000000 +0100 renamed from net/mac80211/cfg.c    2009-11-29 11:33:00.000000000 +0100 +10 -0
+                                 enum nl80211_smps_mode smps_mode)
+{
+       const u8 *ap;
+       enum nl80211_smps_mode old_req;
+       int err = 0;
+
+       mutex_lock(&sdata->u.mgd.mtx);
+
+       old_req = sdata->u.mgd.req_smps;
+       sdata->u.mgd.req_smps = smps_mode;

sdata->u.mgd.mtx seems protected by sdata->u.mgd.mtx.

Quoted 40 lines
net/mac80211/cfg.c 2009-11-29 11:40:29.000000000 +0100 renamed from net/mac80211/cfg.c    2009-11-29 11:33:00.000000000 +0100 +36 -0
+
+       if (old_req == smps_mode &&
+           smps_mode != NL80211_SMPS_AUTOMATIC)
+               goto out;
+
+       /*
+        * If not associated, or current sasociation is not an HT
+        * association, there's no need to send an action frame.
+        */
+       if (!sdata->u.mgd.associated ||
+           sdata->local->oper_channel_type == NL80211_CHAN_NO_HT) {
+               mutex_lock(&sdata->local->iflist_mtx);
+               ieee80211_recalc_smps(sdata->local, sdata);
+               mutex_unlock(&sdata->local->iflist_mtx);
+               goto out;
+       }
+
+       ap = sdata->u.mgd.associated->cbss.bssid;
+
+       if (smps_mode == NL80211_SMPS_AUTOMATIC) {
+               if (sdata->u.mgd.powersave)
+                       smps_mode = NL80211_SMPS_DYNAMIC;
+               else
+                       smps_mode = NL80211_SMPS_OFF;
+       }
+
+       /* send SM PS frame to AP */
+       err = ieee80211_send_smps_action(sdata, smps_mode,
+                                        ap, ap);
+       if (err)
+               sdata->u.mgd.req_smps = old_req;
+ out:
+       mutex_unlock(&sdata->u.mgd.mtx);
+
+       return err;
+}
  static int ieee80211_set_power_mgmt(struct wiphy *wiphy, struct net_device *dev,
                                    bool enabled, int timeout)
  {

net/mac80211/cfg.c 2009-11-29 11:40:29.000000000 +0100 static int ieee80211_set_power_mgmt(stru · line 1385

Quoted 5 lines
net/mac80211/cfg.c 2009-11-29 11:40:29.000000000 +0100 renamed from net/mac80211/cfg.c    2009-11-29 11:33:00.000000000 +0100 +2 -0
@@ -1333,6 +1381,9 @@ static int ieee80211_set_power_mgmt(stru
        sdata->u.mgd.powersave = enabled;
        conf->dynamic_ps_timeout = timeout;
 
+       /* no change, but if automatic follow powersave */
+       ieee80211_request_smps(sdata, sdata->u.mgd.req_smps);

But yet the caller uses it without any locking. Seems racy between here and the respective mutex_lock().

Quoted 9 lines
net/mac80211/cfg.c 2009-11-29 11:40:29.000000000 +0100 renamed from net/mac80211/cfg.c    2009-11-29 11:33:00.000000000 +0100 +1 -0
@@ -932,6 +981,7 @@ static void ieee80211_set_associated(str
 
        mutex_lock(&local->iflist_mtx);
        ieee80211_recalc_ps(local, -1);
+       ieee80211_recalc_smps(local, sdata);
        mutex_unlock(&local->iflist_mtx);
 
        netif_start_queue(sdata->dev);

net/mac80211/cfg.c 2009-11-29 11:40:29.000000000 +0100 void ieee80211_sta_setup_sdata(struct ie · line 2385

Quoted 8 lines
net/mac80211/cfg.c 2009-11-29 11:40:29.000000000 +0100 renamed from net/mac80211/cfg.c    2009-11-29 11:33:00.000000000 +0100 +5 -0
@@ -2328,6 +2378,11 @@ void ieee80211_sta_setup_sdata(struct ie
                ifmgd->flags |= IEEE80211_STA_WMM_ENABLED;
 
        mutex_init(&ifmgd->mtx);
+
+       if (sdata->local->hw.flags & IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS)
+               ifmgd->req_smps = NL80211_SMPS_AUTOMATIC;
+       else
+               ifmgd->req_smps = NL80211_SMPS_OFF;

How about just checking the HT cap as well and if no HT cap has been set warn as it would indicate a driver bug actually.

Quoted 27 lines
net/mac80211/status.c      2009-11-29 11:35:06.000000000 +0100 renamed from net/mac80211/status.c 2009-11-29 11:33:00.000000000 +0100 +21 -0
@@ -134,6 +134,40 @@ static void ieee80211_handle_filtered_fr
        dev_kfree_skb(skb);
  }
 
+static void ieee80211_frame_acked(struct sta_info *sta, struct sk_buff *skb)
+{
+       struct ieee80211_mgmt *mgmt = (void *) skb->data;
+       struct ieee80211_local *local = sta->local;
+       struct ieee80211_sub_if_data *sdata = sta->sdata;
+
+       if (ieee80211_is_action(mgmt->frame_control) &&
+           sdata->vif.type == NL80211_IFTYPE_STATION &&
+           mgmt->u.action.category == WLAN_CATEGORY_HT &&
+           mgmt->u.action.u.ht_smps.action == WLAN_HT_ACTION_SMPS) {
+               /*
+                * This update looks racy, but isn't -- if we come
+                * here we've definitely got a station that we're
+                * talking to, and on a managed interface that can
+                * only be the AP. And the only other place updating
+                * this variable is before we're associated.
+                */
+               switch (mgmt->u.action.u.ht_smps.smps_control) {
+               case WLAN_HT_SMPS_CONTROL_DYNAMIC:
+                       sta->sdata->u.mgd.ap_smps = NL80211_SMPS_DYNAMIC;
+                       break;

net/mac80211/status.c      2009-11-29 11:35:06.000000000 +0100 static void ieee80211_handle_filtered_fr · line 167

Quoted 10 lines
net/mac80211/status.c      2009-11-29 11:35:06.000000000 +0100 renamed from net/mac80211/status.c 2009-11-29 11:33:00.000000000 +0100 +10 -0
+               case WLAN_HT_SMPS_CONTROL_STATIC:
+                       sta->sdata->u.mgd.ap_smps = NL80211_SMPS_STATIC;
+                       break;
+               case WLAN_HT_SMPS_CONTROL_DISABLED:
+               default: /* shouldn't happen since we don't send that */
+                       sta->sdata->u.mgd.ap_smps = NL80211_SMPS_OFF;
+                       break;
+               }
+
+               ieee80211_queue_work(&local->hw, &local->recalc_smps);

OK from what I gather so far we just queue work if we received an ACK from the action frame we sent. Since we tell the device to ieee80211_stop_device() the device should have stopped RX'ing and that *should* mean preventing processing future tx status reports. We'll find out if that assumption is wrong.

Quoted 7 lines
net/mac80211/status.c      2009-11-29 11:35:06.000000000 +0100 renamed from net/mac80211/status.c 2009-11-29 11:33:00.000000000 +0100 +3 -0
+       }
+}
+
  void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
  {
        struct sk_buff *skb2;

net/mac80211/status.c      2009-11-29 11:35:06.000000000 +0100 void ieee80211_tx_status(struct ieee8021 · line 252

Quoted 10 lines
net/mac80211/status.c      2009-11-29 11:35:06.000000000 +0100 renamed from net/mac80211/status.c 2009-11-29 11:33:00.000000000 +0100 +4 -0
@@ -209,6 +243,10 @@ void ieee80211_tx_status(struct ieee8021
                rate_control_tx_status(local, sband, sta, skb);
                if (ieee80211_vif_is_mesh(&sta->sdata->vif))
                        ieee80211s_update_metric(local, sta, skb);
+
+               if (!(info->flags & IEEE80211_TX_CTL_INJECTED) &&
+                   (info->flags & IEEE80211_TX_STAT_ACK))
+                       ieee80211_frame_acked(sta, skb);
        }
 
        rcu_read_unlock();

Nice, should the nullfunc ack check be handled here as well?

net/mac80211/main.c        2009-11-29 22:18:07.000000000 +0100 int ieee80211_hw_config(struct ieee80211 · line 122

Quoted 13 lines
net/mac80211/main.c        2009-11-29 22:18:07.000000000 +0100 renamed from net/mac80211/main.c   2009-11-29 11:33:00.000000000 +0100 +7 -0
@@ -113,6 +113,18 @@ int ieee80211_hw_config(struct ieee80211
                changed |= IEEE80211_CONF_CHANGE_CHANNEL;
        }
 
+       if (!conf_is_ht(&local->hw.conf)) {
+               /*
+                * mac80211.h documents that this is only valid
+                * when the channel is set to an HT type, and
+                * that otherwise STATIC is used.
+                */
+               local->hw.conf.smps_mode = NL80211_SMPS_STATIC;

Why wouldn't this just be SMPS_OFF ?

net/mac80211/util.c        2009-11-29 11:35:06.000000000 +0100 int ieee80211_reconfig(struct ieee80211_ · line 1179

Quoted 13 lines
net/mac80211/util.c        2009-11-29 11:35:06.000000000 +0100 renamed from net/mac80211/util.c   2009-11-29 11:33:00.000000000 +0100 +7 -0
@@ -1170,3 +1170,77 @@ int ieee80211_reconfig(struct ieee80211_
        return 0;
  }
 
+static int check_mgd_smps(struct ieee80211_if_managed *ifmgd,
+                         enum nl80211_smps_mode *smps_mode)
+{
+       if (ifmgd->associated) {
+               *smps_mode = ifmgd->ap_smps;
+
+               if (smps_mode == NL80211_SMPS_AUTOMATIC) {

This should be *smps_mode.

Luis

author maintainer
#7 lore raw

Re: [PATCH 2/2] mac80211: enable spatial multiplexing powersave

Quoted 5 lines · Luis R. Rodriguez
Quoted 5 lines
net/mac80211/cfg.c +5 -0
+static int ieee80211_request_smps(struct ieee80211_sub_if_data *sdata,
+                                 enum nl80211_smps_mode smps_mode)
+{
+       const u8 *ap;
+       enum nl80211_smps_mode old_req;
Quoted 8 lines

net/mac80211/cfg.c static int ieee80211_testmode_cmd(struct · line 1329

Quoted 6 lines
net/mac80211/cfg.c +6 -0
+       int err = 0;
+
+       mutex_lock(&sdata->u.mgd.mtx);
+
+       old_req = sdata->u.mgd.req_smps;
+       sdata->u.mgd.req_smps = smps_mode;

sdata->u.mgd.mtx seems protected by sdata->u.mgd.mtx.

You mean req_smps, I gather.

Quoted 43 lines
Quoted 43 lines
net/mac80211/cfg.c +36 -0
+
+       if (old_req == smps_mode &&
+           smps_mode != NL80211_SMPS_AUTOMATIC)
+               goto out;
+
+       /*
+        * If not associated, or current sasociation is not an HT
+        * association, there's no need to send an action frame.
+        */
+       if (!sdata->u.mgd.associated ||
+           sdata->local->oper_channel_type == NL80211_CHAN_NO_HT) {
+               mutex_lock(&sdata->local->iflist_mtx);
+               ieee80211_recalc_smps(sdata->local, sdata);
+               mutex_unlock(&sdata->local->iflist_mtx);
+               goto out;
+       }
+
+       ap = sdata->u.mgd.associated->cbss.bssid;
+
+       if (smps_mode == NL80211_SMPS_AUTOMATIC) {
+               if (sdata->u.mgd.powersave)
+                       smps_mode = NL80211_SMPS_DYNAMIC;
+               else
+                       smps_mode = NL80211_SMPS_OFF;
+       }
+
+       /* send SM PS frame to AP */
+       err = ieee80211_send_smps_action(sdata, smps_mode,
+                                        ap, ap);
+       if (err)
+               sdata->u.mgd.req_smps = old_req;
+ out:
+       mutex_unlock(&sdata->u.mgd.mtx);
+
+       return err;
+}
 static int ieee80211_set_power_mgmt(struct wiphy *wiphy, struct net_device *dev,
                                   bool enabled, int timeout)
 {
@@ -1333,6 +1381,9 @@ static int ieee80211_set_power_mgmt(stru
       sdata->u.mgd.powersave = enabled;
       conf->dynamic_ps_timeout = timeout;
 
Quoted 5 lines

net/mac80211/cfg.c static int ieee80211_set_power_mgmt(stru · line 1385

Quoted 2 lines
net/mac80211/cfg.c +2 -0
+       /* no change, but if automatic follow powersave */
+       ieee80211_request_smps(sdata, sdata->u.mgd.req_smps);

But yet the caller uses it without any locking. Seems racy between here and the respective mutex_lock().

Hmm, good catch. Although I think it doesn't matter since this is the only code path that touches it apart from set_smps, and they both occur under rtnl.

Quoted 9 lines

net/mac80211/mlme.c void ieee80211_sta_setup_sdata(struct ie · line 2385

Quoted 6 lines
net/mac80211/mlme.c +5 -0
       mutex_init(&ifmgd->mtx);
+
+       if (sdata->local->hw.flags & IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS)
+               ifmgd->req_smps = NL80211_SMPS_AUTOMATIC;
+       else
+               ifmgd->req_smps = NL80211_SMPS_OFF;

How about just checking the HT cap as well and if no HT cap has been set warn as it would indicate a driver bug actually.

You mean if it sets dynps w/o HT cap? We /could/ do that, but I don't really see a reason for it. We'd find out soon enough by a non-HT driver supporting SMPS etc.

Quoted 7 lines
Quoted 1 line

+ ieee80211_queue_work(&local->hw, &local->recalc_smps);

OK from what I gather so far we just queue work if we received an ACK from the action frame we sent. Since we tell the device to ieee80211_stop_device() the device should have stopped RX'ing and that *should* mean preventing processing future tx status reports. We'll find out if that assumption is wrong.

It's not about receiving -- only about transmitting. But yeah, we'll find out. I have a patch pending that'll flush queues etc., that would make it completely impossible if implemented by the driver, but I don't think we need to worry about it.

Quoted 10 lines
Quoted 10 lines
net/mac80211/status.c +4 -0
@@ -209,6 +243,10 @@ void ieee80211_tx_status(struct ieee8021
               rate_control_tx_status(local, sband, sta, skb);
               if (ieee80211_vif_is_mesh(&sta->sdata->vif))
                       ieee80211s_update_metric(local, sta, skb);
+
+               if (!(info->flags & IEEE80211_TX_CTL_INJECTED) &&
+                   (info->flags & IEEE80211_TX_STAT_ACK))
+                       ieee80211_frame_acked(sta, skb);
       }
 
Quoted 3 lines

net/mac80211/status.c void ieee80211_tx_status(struct ieee8021 · line 252

Quoted 1 line
net/mac80211/status.c +0 -0
       rcu_read_unlock();

Nice, should the nullfunc ack check be handled here as well?

Well, it could, in theory. But I've now imposed a requirement that SMPS capable devices also implement status notifications properly, which may or may not be possible for all frames. In fact, we may need to change this in the future but for now I prefer this requirement -- but for HT only.

Quoted 9 lines

net/mac80211/main.c int ieee80211_hw_config(struct ieee80211 · line 122

Quoted 7 lines
net/mac80211/main.c +7 -0
+       if (!conf_is_ht(&local->hw.conf)) {
+               /*
+                * mac80211.h documents that this is only valid
+                * when the channel is set to an HT type, and
+                * that otherwise STATIC is used.
+                */
+               local->hw.conf.smps_mode = NL80211_SMPS_STATIC;

Why wouldn't this just be SMPS_OFF ?

Well, it doesn't matter either way. However, it was easier this way for iwlwifi because ultimately we want to turn off all but one chain if non-HT and/or static SMPS. So at least there it made sense to use STATIC here to avoid the extra check. But other drivers may or may not want to ignore it completely in the HT case. I've documented that it sets it to STATIC when a non-HT association is used just for more use. It could be anything really, or even an invalid value. Also remember that SMPS_OFF means all chains turned on.

Quoted 6 lines
Quoted 6 lines
net/mac80211/util.c 2009-11-29 11:35:06.000000000 +0100 renamed from net/mac80211/util.c 2009-11-29 11:33:00.000000000 +0100 +0 -0
@@ -1170,3 +1170,77 @@ int ieee80211_reconfig(struct ieee80211_
       return 0;
 }
 
Quoted 9 lines

net/mac80211/util.c 2009-11-29 11:35:06.000000000 +0100 int ieee80211_reconfig(struct ieee80211_ · line 1179

Quoted 7 lines
net/mac80211/util.c 2009-11-29 11:35:06.000000000 +0100 renamed from net/mac80211/util.c 2009-11-29 11:33:00.000000000 +0100 +7 -0
+static int check_mgd_smps(struct ieee80211_if_managed *ifmgd,
+                         enum nl80211_smps_mode *smps_mode)
+{
+       if (ifmgd->associated) {
+               *smps_mode = ifmgd->ap_smps;
+
+               if (smps_mode == NL80211_SMPS_AUTOMATIC) {

This should be *smps_mode.

Indeed, good catch, thanks!

johannes

author maintainer
#10 lore raw

PATCH v2 2/2 mac80211: enable spatial multiplexing powersave

In reply to Johannes Berg

Enable spatial multiplexing in mac80211 by telling the driver what to do and, where necessary, sending action frames to the AP to update the requested SMPS mode.

Also includes a trivial implementation for hwsim that just logs the requested mode.

---
v2: (thanks to Luis)
* fix typo "sasociation"
* rework locking in cfg hooks
* add missing dereference in reconfig check

 drivers/net/wireless/mac80211_hwsim.c |   22 +++++++-
 include/linux/ieee80211.h             |   25 +++++++++-
 include/net/mac80211.h                |   44 +++++++++++++++++
 net/mac80211/cfg.c                    |   85 ++++++++++++++++++++++++++++++++++
 net/mac80211/driver-trace.h           |    2 
 net/mac80211/ht.c                     |   47 ++++++++++++++++++
 net/mac80211/ieee80211_i.h            |   12 ++++
 net/mac80211/main.c                   |   24 +++++++++
 net/mac80211/mlme.c                   |   63 +++++++++++++++++++++++--
 net/mac80211/status.c                 |   38 +++++++++++++++
 net/mac80211/util.c                   |   74 +++++++++++++++++++++++++++++
 11 files changed, 428 insertions(+), 8 deletions(-)
include/net/mac80211.h +44 -0
@@ -597,8 +597,10 @@ enum ieee80211_conf_flags {
  * @IEEE80211_CONF_CHANGE_CHANNEL: the channel/channel_type changed
  * @IEEE80211_CONF_CHANGE_RETRY_LIMITS: retry limits changed
  * @IEEE80211_CONF_CHANGE_IDLE: Idle flag changed
+ * @IEEE80211_CONF_CHANGE_SMPS: Spatial multiplexing powersave mode changed
  */
 enum ieee80211_conf_changed {
+	IEEE80211_CONF_CHANGE_SMPS		= BIT(1),
 	IEEE80211_CONF_CHANGE_LISTEN_INTERVAL	= BIT(2),
 	IEEE80211_CONF_CHANGE_MONITOR		= BIT(3),
 	IEEE80211_CONF_CHANGE_PS		= BIT(4),
@@ -636,6 +638,10 @@ enum ieee80211_conf_changed {
  * @short_frame_max_tx_count: Maximum number of transmissions for a "short"
  *    frame, called "dot11ShortRetryLimit" in 802.11, but actually means the
  *    number of transmissions not the number of retries
+ *
+ * @smps_mode: spatial multiplexing powersave mode; note that
+ *	%NL80211_SMPS_STATIC is used when the device is not
+ *	configured for an HT channel
  */
 struct ieee80211_conf {
 	u32 flags;
@@ -648,6 +654,7 @@ struct ieee80211_conf {
 
 	struct ieee80211_channel *channel;
 	enum nl80211_channel_type channel_type;
+	enum nl80211_smps_mode smps_mode;
 };
 
 /**
@@ -930,6 +937,16 @@ enum ieee80211_tkip_key_type {
  * @IEEE80211_HW_BEACON_FILTER:
  *	Hardware supports dropping of irrelevant beacon frames to
  *	avoid waking up cpu.
+ *
+ * @IEEE80211_HW_SUPPORTS_STATIC_SMPS:
+ *	Hardware supports static spatial multiplexing powersave,
+ *	ie. can turn off all but one chain even on HT connections
+ *	that should be using more chains.
+ *
+ * @IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS:
+ *	Hardware supports dynamic spatial multiplexing powersave,
+ *	ie. can turn off all but one chain and then wake the rest
+ *	up as required after, for example, rts/cts handshake.
  */
 enum ieee80211_hw_flags {
 	IEEE80211_HW_HAS_RATE_CONTROL			= 1<<0,
@@ -947,6 +964,8 @@ enum ieee80211_hw_flags {
 	IEEE80211_HW_SUPPORTS_DYNAMIC_PS		= 1<<12,
 	IEEE80211_HW_MFP_CAPABLE			= 1<<13,
 	IEEE80211_HW_BEACON_FILTER			= 1<<14,
+	IEEE80211_HW_SUPPORTS_STATIC_SMPS		= 1<<15,
+	IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS		= 1<<16,
 };
 
 /**
@@ -1215,6 +1234,31 @@ ieee80211_get_alt_retry_rate(const struc
  */
 
 /**
+ * DOC: Spatial multiplexing power save
+ *
+ * SMPS (Spatial multiplexing power save) is a mechanism to conserve
+ * power in an 802.11n implementation. For details on the mechanism
+ * and rationale, please refer to 802.11 (as amended by 802.11n-2009)
+ * "11.2.3 SM power save".
+ *
+ * The mac80211 implementation is capable of sending action frames
+ * to update the AP about the station's SMPS mode, and will instruct
+ * the driver to enter the specific mode. It will also announce the
+ * requested SMPS mode during the association handshake. Hardware
+ * support for this feature is required, and can be indicated by
+ * hardware flags.
+ *
+ * The default mode will be "automatic", which nl80211/cfg80211
+ * defines to be dynamic SMPS in (regular) powersave, and SMPS
+ * turned off otherwise.
+ *
+ * To support this feature, the driver must set the appropriate
+ * hardware support flags, and handle the SMPS flag to the config()
+ * operation. It will then with this mechanism be instructed to
+ * enter the requested SMPS mode while associated to an HT AP.
+ */
+
+/**
  * DOC: Frame filtering
  *
  * mac80211 requires to see many management frames for proper
net/mac80211/ieee80211_i.h +12 -0
@@ -297,6 +297,8 @@ struct ieee80211_if_managed {
 
 	unsigned long timers_running; /* used for quiesce/restart */
 	bool powersave; /* powersave requested for this iface */
+	enum nl80211_smps_mode req_smps, /* requested smps mode */
+			       ap_smps; /* smps mode AP thinks we're in */
 
 	unsigned long request;
 
@@ -587,6 +589,9 @@ struct ieee80211_local {
 	/* used for uploading changed mc list */
 	struct work_struct reconfig_filter;
 
+	/* used to reconfigure hardware SM PS */
+	struct work_struct recalc_smps;
+
 	/* aggregated multicast list */
 	struct dev_addr_list *mc_list;
 	int mc_count;
@@ -760,6 +765,8 @@ struct ieee80211_local {
 	int user_power_level; /* in dBm */
 	int power_constr_level; /* in dBm */
 
+	enum nl80211_smps_mode smps_mode;
+
 	struct work_struct restart_work;
 
 #ifdef CONFIG_MAC80211_DEBUGFS
@@ -983,6 +990,9 @@ void ieee80211_send_bar(struct ieee80211
 void ieee80211_send_delba(struct ieee80211_sub_if_data *sdata,
 			  const u8 *da, u16 tid,
 			  u16 initiator, u16 reason_code);
+int ieee80211_send_smps_action(struct ieee80211_sub_if_data *sdata,
+			       enum nl80211_smps_mode smps, const u8 *da,
+			       const u8 *bssid);
 
 void ieee80211_sta_stop_rx_ba_session(struct ieee80211_sub_if_data *sdata, u8 *da,
 				u16 tid, u16 initiator, u16 reason);
@@ -1093,6 +1103,8 @@ void ieee80211_sta_def_wmm_params(struct
 u32 ieee80211_sta_get_rates(struct ieee80211_local *local,
 			    struct ieee802_11_elems *elems,
 			    enum ieee80211_band band);
+void ieee80211_recalc_smps(struct ieee80211_local *local,
+			   struct ieee80211_sub_if_data *forsdata);
 
 #ifdef CONFIG_MAC80211_NOINLINE
 #define debug_noinline noinline
net/mac80211/cfg.c +85 -0

107 lines not on this page · raw message

include/linux/ieee80211.h +24 -1
@@ -707,6 +707,10 @@ struct ieee80211_mgmt {
 					u8 action;
 					u8 trans_id[WLAN_SA_QUERY_TR_ID_LEN];
 				} __attribute__ ((packed)) sa_query;
+				struct {
+					u8 action;
+					u8 smps_control;
+				} __attribute__ ((packed)) ht_smps;
 			} u;
 		} __attribute__ ((packed)) action;
 	} u;
@@ -824,6 +828,7 @@ struct ieee80211_ht_cap {
 #define IEEE80211_HT_CAP_LDPC_CODING		0x0001
 #define IEEE80211_HT_CAP_SUP_WIDTH_20_40	0x0002
 #define IEEE80211_HT_CAP_SM_PS			0x000C
+#define		IEEE80211_HT_CAP_SM_PS_SHIFT	2
 #define IEEE80211_HT_CAP_GRN_FLD		0x0010
 #define IEEE80211_HT_CAP_SGI_20			0x0020
 #define IEEE80211_HT_CAP_SGI_40			0x0040
@@ -839,6 +844,7 @@ struct ieee80211_ht_cap {
 /* 802.11n HT capability AMPDU settings (for ampdu_params_info) */
 #define IEEE80211_HT_AMPDU_PARM_FACTOR		0x03
 #define IEEE80211_HT_AMPDU_PARM_DENSITY		0x1C
+#define		IEEE80211_HT_AMPDU_PARM_DENSITY_SHIFT	2
 
 /*
  * Maximum length of AMPDU that the STA can receive.
@@ -922,12 +928,17 @@ struct ieee80211_ht_info {
 #define IEEE80211_MAX_AMPDU_BUF 0x40
 
 
-/* Spatial Multiplexing Power Save Modes */
+/* Spatial Multiplexing Power Save Modes (for capability) */
 #define WLAN_HT_CAP_SM_PS_STATIC	0
 #define WLAN_HT_CAP_SM_PS_DYNAMIC	1
 #define WLAN_HT_CAP_SM_PS_INVALID	2
 #define WLAN_HT_CAP_SM_PS_DISABLED	3
 
+/* for SM power control field lower two bits */
+#define WLAN_HT_SMPS_CONTROL_DISABLED	0
+#define WLAN_HT_SMPS_CONTROL_STATIC	1
+#define WLAN_HT_SMPS_CONTROL_DYNAMIC	3
+
 /* Authentication algorithms */
 #define WLAN_AUTH_OPEN 0
 #define WLAN_AUTH_SHARED_KEY 1
@@ -1150,6 +1161,18 @@ enum ieee80211_spectrum_mgmt_actioncode 
 	WLAN_ACTION_SPCT_CHL_SWITCH = 4,
 };
 
+/* HT action codes */
+enum ieee80211_ht_actioncode {
+	WLAN_HT_ACTION_NOTIFY_CHANWIDTH = 0,
+	WLAN_HT_ACTION_SMPS = 1,
+	WLAN_HT_ACTION_PSMP = 2,
+	WLAN_HT_ACTION_PCO_PHASE = 3,
+	WLAN_HT_ACTION_CSI = 4,
+	WLAN_HT_ACTION_NONCOMPRESSED_BF = 5,
+	WLAN_HT_ACTION_COMPRESSED_BF = 6,
+	WLAN_HT_ACTION_ASEL_IDX_FEEDBACK = 7,
+};
+
 /* Security key length */
 enum ieee80211_key_len {
 	WLAN_KEY_LEN_WEP40 = 5,
net/mac80211/mlme.c +59 -4

94 lines not on this page · raw message

net/mac80211/ht.c +47 -0

50 lines not on this page · raw message

net/mac80211/status.c +38 -0
@@ -134,6 +134,40 @@ static void ieee80211_handle_filtered_fr
 	dev_kfree_skb(skb);
 }
 
+static void ieee80211_frame_acked(struct sta_info *sta, struct sk_buff *skb)
+{
+	struct ieee80211_mgmt *mgmt = (void *) skb->data;
+	struct ieee80211_local *local = sta->local;
+	struct ieee80211_sub_if_data *sdata = sta->sdata;
+
+	if (ieee80211_is_action(mgmt->frame_control) &&
+	    sdata->vif.type == NL80211_IFTYPE_STATION &&
+	    mgmt->u.action.category == WLAN_CATEGORY_HT &&
+	    mgmt->u.action.u.ht_smps.action == WLAN_HT_ACTION_SMPS) {
+		/*
+		 * This update looks racy, but isn't -- if we come
+		 * here we've definitely got a station that we're
+		 * talking to, and on a managed interface that can
+		 * only be the AP. And the only other place updating
+		 * this variable is before we're associated.
+		 */
+		switch (mgmt->u.action.u.ht_smps.smps_control) {
+		case WLAN_HT_SMPS_CONTROL_DYNAMIC:
+			sta->sdata->u.mgd.ap_smps = NL80211_SMPS_DYNAMIC;
+			break;
+		case WLAN_HT_SMPS_CONTROL_STATIC:
+			sta->sdata->u.mgd.ap_smps = NL80211_SMPS_STATIC;
+			break;
+		case WLAN_HT_SMPS_CONTROL_DISABLED:
+		default: /* shouldn't happen since we don't send that */
+			sta->sdata->u.mgd.ap_smps = NL80211_SMPS_OFF;
+			break;
+		}
+
+		ieee80211_queue_work(&local->hw, &local->recalc_smps);
+	}
+}
+
 void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
 {
 	struct sk_buff *skb2;
@@ -209,6 +243,10 @@ void ieee80211_tx_status(struct ieee8021
 		rate_control_tx_status(local, sband, sta, skb);
 		if (ieee80211_vif_is_mesh(&sta->sdata->vif))
 			ieee80211s_update_metric(local, sta, skb);
+
+		if (!(info->flags & IEEE80211_TX_CTL_INJECTED) &&
+		    (info->flags & IEEE80211_TX_STAT_ACK))
+			ieee80211_frame_acked(sta, skb);
 	}
 
 	rcu_read_unlock();
net/mac80211/main.c +24 -0
@@ -113,6 +113,18 @@ int ieee80211_hw_config(struct ieee80211
 		changed |= IEEE80211_CONF_CHANGE_CHANNEL;
 	}
 
+	if (!conf_is_ht(&local->hw.conf)) {
+		/*
+		 * mac80211.h documents that this is only valid
+		 * when the channel is set to an HT type, and
+		 * that otherwise STATIC is used.
+		 */
+		local->hw.conf.smps_mode = NL80211_SMPS_STATIC;
+	} else if (local->hw.conf.smps_mode != local->smps_mode) {
+		local->hw.conf.smps_mode = local->smps_mode;
+		changed |= IEEE80211_CONF_CHANGE_SMPS;
+	}
+
 	if (scan_chan)
 		power = chan->max_power;
 	else
@@ -297,6 +309,16 @@ void ieee80211_restart_hw(struct ieee802
 }
 EXPORT_SYMBOL(ieee80211_restart_hw);
 
+static void ieee80211_recalc_smps_work(struct work_struct *work)
+{
+	struct ieee80211_local *local =
+		container_of(work, struct ieee80211_local, recalc_smps);
+
+	mutex_lock(&local->iflist_mtx);
+	ieee80211_recalc_smps(local, NULL);
+	mutex_unlock(&local->iflist_mtx);
+}
+
 struct ieee80211_hw *ieee80211_alloc_hw(size_t priv_data_len,
 					const struct ieee80211_ops *ops)
 {
@@ -370,6 +392,8 @@ struct ieee80211_hw *ieee80211_alloc_hw(
 	INIT_WORK(&local->restart_work, ieee80211_restart_work);
 
 	INIT_WORK(&local->reconfig_filter, ieee80211_reconfig_filter);
+	INIT_WORK(&local->recalc_smps, ieee80211_recalc_smps_work);
+	local->smps_mode = NL80211_SMPS_OFF;
 
 	INIT_WORK(&local->dynamic_ps_enable_work,
 		  ieee80211_dynamic_ps_enable_work);
net/mac80211/util.c +74 -0

77 lines not on this page · raw message

drivers/net/wireless/mac80211_hwsim.c +19 -3
@@ -619,12 +619,26 @@ static int mac80211_hwsim_config(struct 
 {
 	struct mac80211_hwsim_data *data = hw->priv;
 	struct ieee80211_conf *conf = &hw->conf;
+	static const char *chantypes[4] = {
+		[NL80211_CHAN_NO_HT] = "noht",
+		[NL80211_CHAN_HT20] = "ht20",
+		[NL80211_CHAN_HT40MINUS] = "ht40-",
+		[NL80211_CHAN_HT40PLUS] = "ht40+",
+	};
+	static const char *smps_modes[__NL80211_SMPS_NUM] = {
+		[NL80211_SMPS_AUTOMATIC] = "auto/invalid",
+		[NL80211_SMPS_OFF] = "off",
+		[NL80211_SMPS_STATIC] = "static",
+		[NL80211_SMPS_DYNAMIC] = "dynamic",
+	};
 
-	printk(KERN_DEBUG "%s:%s (freq=%d idle=%d ps=%d)\n",
+	printk(KERN_DEBUG "%s:%s (freq=%d/%s idle=%d ps=%d smps=%s)\n",
 	       wiphy_name(hw->wiphy), __func__,
 	       conf->channel->center_freq,
+	       chantypes[conf->channel_type],
 	       !!(conf->flags & IEEE80211_CONF_IDLE),
-	       !!(conf->flags & IEEE80211_CONF_PS));
+	       !!(conf->flags & IEEE80211_CONF_PS),
+	       smps_modes[conf->smps_mode]);
 
 	data->idle = !!(conf->flags & IEEE80211_CONF_IDLE);
 
@@ -1121,7 +1135,9 @@ static int __init init_mac80211_hwsim(vo
 			BIT(NL80211_IFTYPE_MESH_POINT);
 
 		hw->flags = IEEE80211_HW_MFP_CAPABLE |
-			    IEEE80211_HW_SIGNAL_DBM;
+			    IEEE80211_HW_SIGNAL_DBM |
+			    IEEE80211_HW_SUPPORTS_STATIC_SMPS |
+			    IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS;
 
 		/* ask mac80211 to reserve space for magic */
 		hw->vif_data_size = sizeof(struct hwsim_vif_priv);
net/mac80211/driver-trace.h +2 -0
@@ -140,6 +140,7 @@ TRACE_EVENT(drv_config,
 		__field(u8, short_frame_max_tx_count)
 		__field(int, center_freq)
 		__field(int, channel_type)
+		__field(int, smps)
 	),
 
 	TP_fast_assign(
@@ -155,6 +156,7 @@ TRACE_EVENT(drv_config,
 		__entry->short_frame_max_tx_count = local->hw.conf.short_frame_max_tx_count;
 		__entry->center_freq = local->hw.conf.channel->center_freq;
 		__entry->channel_type = local->hw.conf.channel_type;
+		__entry->smps = local->hw.conf.smps_mode;
 	),
 
 	TP_printk(
#8 lore raw

Re: [PATCH 2/2] mac80211: enable spatial multiplexing powersave

In reply to Johannes Berg
Quoted 8 lines · Johannes Berg
Quoted 8 lines
Quoted 7 lines

       mutex_init(&ifmgd->mtx);
+
+       if (sdata->local->hw.flags & IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS)
+               ifmgd->req_smps = NL80211_SMPS_AUTOMATIC;
+       else
+               ifmgd->req_smps = NL80211_SMPS_OFF;

Quoted 4 lines
Quoted 2 lines

How about just checking the HT cap as well and if no HT cap has been set warn as it would indicate a driver bug actually.

You mean if it sets dynps w/o HT cap?

Yes

Quoted 3 lines

We /could/ do that, but I don't
really see a reason for it. We'd find out soon enough by a non-HT driver supporting SMPS etc.

OK.

Quoted 9 lines
Quoted 7 lines
Quoted 1 line

+               ieee80211_queue_work(&local->hw, &local->recalc_smps);

OK from what I gather so far we just queue work if we received an ACK from the action frame we sent. Since we tell the device to ieee80211_stop_device() the device should have stopped RX'ing and that *should* mean preventing processing future tx status reports. We'll find out if that assumption is wrong.

It's not about receiving -- only about transmitting.

Yes but this is not about a actual transmit but a tx status.

Quoted 4 lines

But yeah, we'll
find out. I have a patch pending that'll flush queues etc., that would make it completely impossible if implemented by the driver, but I don't think we need to worry about it.

What I mean is that technically a driver could have called even this new tx flush and yet *after* that was called a tx status for a *previously* transmitted frame could have come through hardware, which is why I mentioned hw stop. hw stop would seem to be the only thing ensuring we don't queue more work if we'd try to pm-suspend between the point where we enabled smps and before the AP sent an ACK to us for the action frame.

Quoted 14 lines
Quoted 10 lines
Quoted 10 lines
net/mac80211/status.c +4 -0
@@ -209,6 +243,10 @@ void ieee80211_tx_status(struct ieee8021
                rate_control_tx_status(local, sband, sta, skb);
                if (ieee80211_vif_is_mesh(&sta->sdata->vif))
                        ieee80211s_update_metric(local, sta, skb);
+
+               if (!(info->flags & IEEE80211_TX_CTL_INJECTED) &&
+                   (info->flags & IEEE80211_TX_STAT_ACK))
+                       ieee80211_frame_acked(sta, skb);
        }
 
Quoted 3 lines

net/mac80211/status.c void ieee80211_tx_status(struct ieee8021 · line 252

Quoted 1 line
net/mac80211/status.c +0 -0
        rcu_read_unlock();

Nice, should the nullfunc ack check be handled here as well?

Quoted 5 lines

Well, it could, in theory. But I've now imposed a requirement that SMPS capable devices also implement status notifications properly, which may or may not be possible for all frames. In fact, we may need to change this in the future but for now I prefer this requirement -- but for HT only.

OK I see. Then the next question is can iwl3945 and iwlagn report tx status for a nullfunc sent to an AP?

Quoted 10 lines
Quoted 9 lines
Quoted 7 lines

+       if (!conf_is_ht(&local->hw.conf)) {
+               /*
+                * mac80211.h documents that this is only valid
+                * when the channel is set to an HT type, and
+                * that otherwise STATIC is used.
+                */
+               local->hw.conf.smps_mode = NL80211_SMPS_STATIC;

Why wouldn't this just be SMPS_OFF ?

Quoted 8 lines

Well, it doesn't matter either way. However, it was easier this way for iwlwifi because ultimately we want to turn off all but one chain if non-HT and/or static SMPS. So at least there it made sense to use STATIC here to avoid the extra check. But other drivers may or may not want to ignore it completely in the HT case. I've documented that it sets it to STATIC when a non-HT association is used just for more use. It could be anything really, or even an invalid value. Also remember that SMPS_OFF means all chains turned on.

Hm -- so hardware would *typically* leave all chains on even for legacy mode of operation?

Luis

author maintainer
#9 lore raw

Re: [PATCH 2/2] mac80211: enable spatial multiplexing powersave

Quoted 11 lines · Luis R. Rodriguez
Quoted 9 lines
Quoted 7 lines
Quoted 1 line

+ ieee80211_queue_work(&local->hw, &local->recalc_smps);

OK from what I gather so far we just queue work if we received an ACK from the action frame we sent. Since we tell the device to ieee80211_stop_device() the device should have stopped RX'ing and that *should* mean preventing processing future tx status reports. We'll find out if that assumption is wrong.

It's not about receiving -- only about transmitting.

Yes but this is not about a actual transmit but a tx status.

Right.

Quoted 5 lines
Quoted 4 lines

But yeah, we'll
find out. I have a patch pending that'll flush queues etc., that would make it completely impossible if implemented by the driver, but I don't think we need to worry about it.

Quoted 7 lines

What I mean is that technically a driver could have called even this new tx flush and yet *after* that was called a tx status for a *previously* transmitted frame could have come through hardware, which is why I mentioned hw stop. hw stop would seem to be the only thing ensuring we don't queue more work if we'd try to pm-suspend between the point where we enabled smps and before the AP sent an ACK to us for the action frame.

Yeah, I see what you're saying, I just don't think it'll actually happen. I guess we will find out by the warning if it ever does.

Quoted 2 lines

OK I see. Then the next question is can iwl3945 and iwlagn report tx status for a nullfunc sent to an AP?

It doesn't matter for them -- they do it all in the firmware. hw_scan and complete PS mode offload.

Quoted 11 lines
Quoted 8 lines

Well, it doesn't matter either way. However, it was easier this way for iwlwifi because ultimately we want to turn off all but one chain if non-HT and/or static SMPS. So at least there it made sense to use STATIC here to avoid the extra check. But other drivers may or may not want to ignore it completely in the HT case. I've documented that it sets it to STATIC when a non-HT association is used just for more use. It could be anything really, or even an invalid value. Also remember that SMPS_OFF means all chains turned on.

Hm -- so hardware would *typically* leave all chains on even for legacy mode of operation?

It depends on what you're after. You can leave them all on, and you'll have better reception. Or you can turn off all but one, and you'll save power. Better reception doesn't help you _much_ because the AP still also has to receive your stuff, and if it's a legacy AP it only has one chain so you receiving it well won't necessarily mean it receives you well enough for a connection -- we would therefore like to save more power and use only one chain on a legacy AP. Hence the default here, it makes it easier the way iwlwifi is done.

I had "Automatic" here as the default in my first iteration of the patch but it just ended up being a few lines of code more in iwlwifi and no real difference in mac80211.

johannes

#2 lore raw

Re: [PATCH 1/2] cfg80211: add SM PS hooks

In reply to Johannes Berg
Quoted 2 lines · Johannes Berg

Add spatial multiplexing power save configuration
hooks to cfg80211/nl80211.

Is it really necessary to export this to user space, at least via nl80211? If we add this to nl80211, we have to support this almost forever.

Also how are planning to use this? What components will use the interface and how?

My concern here is that we will end up having, yet again, complicated user space interface for power save. The ideal situation would be that kernel would configure all this automatically and we would have a simple interface just to disable power save in cases where it doesn't work (broken APs etc).

Signature · 1 line
Kalle Valo
author maintainer
#3 lore raw

Re: [PATCH 1/2] cfg80211: add SM PS hooks

Quoted 11 lines · Kalle Valo
Quoted 2 lines · Johannes Berg

Add spatial multiplexing power save configuration
hooks to cfg80211/nl80211.

Is it really necessary to export this to user space, at least via nl80211? If we add this to nl80211, we have to support this almost forever.

Also how are planning to use this? What components will use the interface and how?

Good questions.

Quoted 5 lines

My concern here is that we will end up having, yet again, complicated user space interface for power save. The ideal situation would be that kernel would configure all this automatically and we would have a simple interface just to disable power save in cases where it doesn't work (broken APs etc).

I'm not actually sure that there are APs broken wrt. SM PS, it seems highly unlikely -- even if there are (like mac80211!!) the rate control algorithm would recover the situation.

As such, I suppose it's somewhat a debugging API. On the other hand, there are actual traffic throughput consequences of enabling SM PS, even when in powersave. Powersave will be turned off automatically if there's enough traffic, but SM PS won't. The default, automatic, means it just follows powersave (dynamic SM PS if on, no SM PS if off), but I'm not sure that is typically desirable.

Of course, on the other hand, I don't see many users actually setting it. An alternative could be to try to estimate traffic, but that gets messy fairly quickly because the thresholds depend on the environment.

If you prefer to leave it out for now, I can probably move it to debugfs until we have a more clearly defined use case, although if we decide that we never want it then obviously the action frame handling can go away again.

johannes

#4 lore raw

Re: [PATCH 1/2] cfg80211: add SM PS hooks

Quoted 10 lines · Johannes Berg
Quoted 5 lines · Kalle Valo

My concern here is that we will end up having, yet again, complicated user space interface for power save. The ideal situation would be that kernel would configure all this automatically and we would have a simple interface just to disable power save in cases where it doesn't work (broken APs etc).

I'm not actually sure that there are APs broken wrt. SM PS, it seems highly unlikely -- even if there are (like mac80211!!) the rate control algorithm would recover the situation.

Oh, that's good.

Quoted 10 lines

As such, I suppose it's somewhat a debugging API. On the other hand, there are actual traffic throughput consequences of enabling SM PS, even when in powersave. Powersave will be turned off automatically if there's enough traffic, but SM PS won't. The default, automatic, means it just follows powersave (dynamic SM PS if on, no SM PS if off), but I'm not sure that is typically desirable.

Of course, on the other hand, I don't see many users actually setting it. An alternative could be to try to estimate traffic, but that gets messy fairly quickly because the thresholds depend on the environment.

I think at some point we need to start estimating the traffic somehow and having heuristics to dynamically change the power save settings. But it's a huge challenge, so it isn't coming anytime soon.

Quoted 2 lines

If you prefer to leave it out for now, I can probably move it to debugfs until we have a more clearly defined use case,

Great if you can convert it to debugfs for now. That way we have a bit more time to think about the power save interface. Thanks.

Quoted 2 lines

although if we decide that we never want it then obviously the action frame handling can go away again.

Yeah.

Signature · 1 line
Kalle Valo
author maintainer
#11 lore raw

PATCH v3 1/1 mac80211: enable spatial multiplexing powersave

In reply to Johannes Berg

Enable spatial multiplexing in mac80211 by telling the driver what to do and, where necessary, sending action frames to the AP to update the requested SMPS mode.

Also includes a trivial implementation for hwsim that just logs the requested mode.

For now, the userspace interface is in debugfs only, and let you toggle the requested mode at any time.

---
v2: (thanks to Luis)
* fix typo "sasociation"
* rework locking in cfg hooks
* add missing dereference in reconfig check
v3:
* use debugfs as requested by Kalle, replaces both previous patches then

 drivers/net/wireless/mac80211_hwsim.c |   22 +++++-
 include/linux/ieee80211.h             |   25 +++++++
 include/net/mac80211.h                |   59 ++++++++++++++++++
 net/mac80211/cfg.c                    |   49 +++++++++++++++
 net/mac80211/debugfs_netdev.c         |  111 +++++++++++++++++++++++++++++++++-
 net/mac80211/driver-trace.h           |    2 
 net/mac80211/ht.c                     |   47 ++++++++++++++
 net/mac80211/ieee80211_i.h            |   14 ++++
 net/mac80211/main.c                   |   24 +++++++
 net/mac80211/mlme.c                   |   63 ++++++++++++++++++-
 net/mac80211/status.c                 |   38 +++++++++++
 net/mac80211/util.c                   |   74 ++++++++++++++++++++++
 12 files changed, 517 insertions(+), 11 deletions(-)
include/net/mac80211.h +59 -0
@@ -597,8 +597,10 @@ enum ieee80211_conf_flags {
  * @IEEE80211_CONF_CHANGE_CHANNEL: the channel/channel_type changed
  * @IEEE80211_CONF_CHANGE_RETRY_LIMITS: retry limits changed
  * @IEEE80211_CONF_CHANGE_IDLE: Idle flag changed
+ * @IEEE80211_CONF_CHANGE_SMPS: Spatial multiplexing powersave mode changed
  */
 enum ieee80211_conf_changed {
+	IEEE80211_CONF_CHANGE_SMPS		= BIT(1),
 	IEEE80211_CONF_CHANGE_LISTEN_INTERVAL	= BIT(2),
 	IEEE80211_CONF_CHANGE_MONITOR		= BIT(3),
 	IEEE80211_CONF_CHANGE_PS		= BIT(4),
@@ -609,6 +611,21 @@ enum ieee80211_conf_changed {
 };
 
 /**
+ * enum ieee80211_smps_mode - spatial multiplexing power save mode
+ *
+ * @
+ */
+enum ieee80211_smps_mode {
+	IEEE80211_SMPS_AUTOMATIC,
+	IEEE80211_SMPS_OFF,
+	IEEE80211_SMPS_STATIC,
+	IEEE80211_SMPS_DYNAMIC,
+
+	/* keep last */
+	IEEE80211_SMPS_NUM_MODES,
+};
+
+/**
  * struct ieee80211_conf - configuration of the device
  *
  * This struct indicates how the driver shall configure the hardware.
@@ -636,6 +653,10 @@ enum ieee80211_conf_changed {
  * @short_frame_max_tx_count: Maximum number of transmissions for a "short"
  *    frame, called "dot11ShortRetryLimit" in 802.11, but actually means the
  *    number of transmissions not the number of retries
+ *
+ * @smps_mode: spatial multiplexing powersave mode; note that
+ *	%IEEE80211_SMPS_STATIC is used when the device is not
+ *	configured for an HT channel
  */
 struct ieee80211_conf {
 	u32 flags;
@@ -648,6 +669,7 @@ struct ieee80211_conf {
 
 	struct ieee80211_channel *channel;
 	enum nl80211_channel_type channel_type;
+	enum ieee80211_smps_mode smps_mode;
 };
 
 /**
@@ -930,6 +952,16 @@ enum ieee80211_tkip_key_type {
  * @IEEE80211_HW_BEACON_FILTER:
  *	Hardware supports dropping of irrelevant beacon frames to
  *	avoid waking up cpu.
+ *
+ * @IEEE80211_HW_SUPPORTS_STATIC_SMPS:
+ *	Hardware supports static spatial multiplexing powersave,
+ *	ie. can turn off all but one chain even on HT connections
+ *	that should be using more chains.
+ *
+ * @IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS:
+ *	Hardware supports dynamic spatial multiplexing powersave,
+ *	ie. can turn off all but one chain and then wake the rest
+ *	up as required after, for example, rts/cts handshake.
  */
 enum ieee80211_hw_flags {
 	IEEE80211_HW_HAS_RATE_CONTROL			= 1<<0,
@@ -947,6 +979,8 @@ enum ieee80211_hw_flags {
 	IEEE80211_HW_SUPPORTS_DYNAMIC_PS		= 1<<12,
 	IEEE80211_HW_MFP_CAPABLE			= 1<<13,
 	IEEE80211_HW_BEACON_FILTER			= 1<<14,
+	IEEE80211_HW_SUPPORTS_STATIC_SMPS		= 1<<15,
+	IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS		= 1<<16,
 };
 
 /**
@@ -1215,6 +1249,31 @@ ieee80211_get_alt_retry_rate(const struc
  */
 
 /**
+ * DOC: Spatial multiplexing power save
+ *
+ * SMPS (Spatial multiplexing power save) is a mechanism to conserve
+ * power in an 802.11n implementation. For details on the mechanism
+ * and rationale, please refer to 802.11 (as amended by 802.11n-2009)
+ * "11.2.3 SM power save".
+ *
+ * The mac80211 implementation is capable of sending action frames
+ * to update the AP about the station's SMPS mode, and will instruct
+ * the driver to enter the specific mode. It will also announce the
+ * requested SMPS mode during the association handshake. Hardware
+ * support for this feature is required, and can be indicated by
+ * hardware flags.
+ *
+ * The default mode will be "automatic", which nl80211/cfg80211
+ * defines to be dynamic SMPS in (regular) powersave, and SMPS
+ * turned off otherwise.
+ *
+ * To support this feature, the driver must set the appropriate
+ * hardware support flags, and handle the SMPS flag to the config()
+ * operation. It will then with this mechanism be instructed to
+ * enter the requested SMPS mode while associated to an HT AP.
+ */
+
+/**
  * DOC: Frame filtering
  *
  * mac80211 requires to see many management frames for proper
net/mac80211/ieee80211_i.h +14 -0
@@ -297,6 +297,8 @@ struct ieee80211_if_managed {
 
 	unsigned long timers_running; /* used for quiesce/restart */
 	bool powersave; /* powersave requested for this iface */
+	enum ieee80211_smps_mode req_smps, /* requested smps mode */
+				 ap_smps; /* smps mode AP thinks we're in */
 
 	unsigned long request;
 
@@ -587,6 +589,9 @@ struct ieee80211_local {
 	/* used for uploading changed mc list */
 	struct work_struct reconfig_filter;
 
+	/* used to reconfigure hardware SM PS */
+	struct work_struct recalc_smps;
+
 	/* aggregated multicast list */
 	struct dev_addr_list *mc_list;
 	int mc_count;
@@ -760,6 +765,8 @@ struct ieee80211_local {
 	int user_power_level; /* in dBm */
 	int power_constr_level; /* in dBm */
 
+	enum ieee80211_smps_mode smps_mode;
+
 	struct work_struct restart_work;
 
 #ifdef CONFIG_MAC80211_DEBUGFS
@@ -983,6 +990,9 @@ void ieee80211_send_bar(struct ieee80211
 void ieee80211_send_delba(struct ieee80211_sub_if_data *sdata,
 			  const u8 *da, u16 tid,
 			  u16 initiator, u16 reason_code);
+int ieee80211_send_smps_action(struct ieee80211_sub_if_data *sdata,
+			       enum ieee80211_smps_mode smps, const u8 *da,
+			       const u8 *bssid);
 
 void ieee80211_sta_stop_rx_ba_session(struct ieee80211_sub_if_data *sdata, u8 *da,
 				u16 tid, u16 initiator, u16 reason);
@@ -1093,6 +1103,10 @@ void ieee80211_sta_def_wmm_params(struct
 u32 ieee80211_sta_get_rates(struct ieee80211_local *local,
 			    struct ieee802_11_elems *elems,
 			    enum ieee80211_band band);
+int __ieee80211_request_smps(struct ieee80211_sub_if_data *sdata,
+			     enum ieee80211_smps_mode smps_mode);
+void ieee80211_recalc_smps(struct ieee80211_local *local,
+			   struct ieee80211_sub_if_data *forsdata);
 
 #ifdef CONFIG_MAC80211_NOINLINE
 #define debug_noinline noinline
net/mac80211/cfg.c +49 -0

61 lines not on this page · raw message

include/linux/ieee80211.h +24 -1
@@ -707,6 +707,10 @@ struct ieee80211_mgmt {
 					u8 action;
 					u8 trans_id[WLAN_SA_QUERY_TR_ID_LEN];
 				} __attribute__ ((packed)) sa_query;
+				struct {
+					u8 action;
+					u8 smps_control;
+				} __attribute__ ((packed)) ht_smps;
 			} u;
 		} __attribute__ ((packed)) action;
 	} u;
@@ -824,6 +828,7 @@ struct ieee80211_ht_cap {
 #define IEEE80211_HT_CAP_LDPC_CODING		0x0001
 #define IEEE80211_HT_CAP_SUP_WIDTH_20_40	0x0002
 #define IEEE80211_HT_CAP_SM_PS			0x000C
+#define		IEEE80211_HT_CAP_SM_PS_SHIFT	2
 #define IEEE80211_HT_CAP_GRN_FLD		0x0010
 #define IEEE80211_HT_CAP_SGI_20			0x0020
 #define IEEE80211_HT_CAP_SGI_40			0x0040
@@ -839,6 +844,7 @@ struct ieee80211_ht_cap {
 /* 802.11n HT capability AMPDU settings (for ampdu_params_info) */
 #define IEEE80211_HT_AMPDU_PARM_FACTOR		0x03
 #define IEEE80211_HT_AMPDU_PARM_DENSITY		0x1C
+#define		IEEE80211_HT_AMPDU_PARM_DENSITY_SHIFT	2
 
 /*
  * Maximum length of AMPDU that the STA can receive.
@@ -922,12 +928,17 @@ struct ieee80211_ht_info {
 #define IEEE80211_MAX_AMPDU_BUF 0x40
 
 
-/* Spatial Multiplexing Power Save Modes */
+/* Spatial Multiplexing Power Save Modes (for capability) */
 #define WLAN_HT_CAP_SM_PS_STATIC	0
 #define WLAN_HT_CAP_SM_PS_DYNAMIC	1
 #define WLAN_HT_CAP_SM_PS_INVALID	2
 #define WLAN_HT_CAP_SM_PS_DISABLED	3
 
+/* for SM power control field lower two bits */
+#define WLAN_HT_SMPS_CONTROL_DISABLED	0
+#define WLAN_HT_SMPS_CONTROL_STATIC	1
+#define WLAN_HT_SMPS_CONTROL_DYNAMIC	3
+
 /* Authentication algorithms */
 #define WLAN_AUTH_OPEN 0
 #define WLAN_AUTH_SHARED_KEY 1
@@ -1150,6 +1161,18 @@ enum ieee80211_spectrum_mgmt_actioncode 
 	WLAN_ACTION_SPCT_CHL_SWITCH = 4,
 };
 
+/* HT action codes */
+enum ieee80211_ht_actioncode {
+	WLAN_HT_ACTION_NOTIFY_CHANWIDTH = 0,
+	WLAN_HT_ACTION_SMPS = 1,
+	WLAN_HT_ACTION_PSMP = 2,
+	WLAN_HT_ACTION_PCO_PHASE = 3,
+	WLAN_HT_ACTION_CSI = 4,
+	WLAN_HT_ACTION_NONCOMPRESSED_BF = 5,
+	WLAN_HT_ACTION_COMPRESSED_BF = 6,
+	WLAN_HT_ACTION_ASEL_IDX_FEEDBACK = 7,
+};
+
 /* Security key length */
 enum ieee80211_key_len {
 	WLAN_KEY_LEN_WEP40 = 5,
net/mac80211/mlme.c +59 -4

94 lines not on this page · raw message

net/mac80211/ht.c +47 -0

50 lines not on this page · raw message

net/mac80211/status.c +38 -0
@@ -134,6 +134,40 @@ static void ieee80211_handle_filtered_fr
 	dev_kfree_skb(skb);
 }
 
+static void ieee80211_frame_acked(struct sta_info *sta, struct sk_buff *skb)
+{
+	struct ieee80211_mgmt *mgmt = (void *) skb->data;
+	struct ieee80211_local *local = sta->local;
+	struct ieee80211_sub_if_data *sdata = sta->sdata;
+
+	if (ieee80211_is_action(mgmt->frame_control) &&
+	    sdata->vif.type == NL80211_IFTYPE_STATION &&
+	    mgmt->u.action.category == WLAN_CATEGORY_HT &&
+	    mgmt->u.action.u.ht_smps.action == WLAN_HT_ACTION_SMPS) {
+		/*
+		 * This update looks racy, but isn't -- if we come
+		 * here we've definitely got a station that we're
+		 * talking to, and on a managed interface that can
+		 * only be the AP. And the only other place updating
+		 * this variable is before we're associated.
+		 */
+		switch (mgmt->u.action.u.ht_smps.smps_control) {
+		case WLAN_HT_SMPS_CONTROL_DYNAMIC:
+			sta->sdata->u.mgd.ap_smps = IEEE80211_SMPS_DYNAMIC;
+			break;
+		case WLAN_HT_SMPS_CONTROL_STATIC:
+			sta->sdata->u.mgd.ap_smps = IEEE80211_SMPS_STATIC;
+			break;
+		case WLAN_HT_SMPS_CONTROL_DISABLED:
+		default: /* shouldn't happen since we don't send that */
+			sta->sdata->u.mgd.ap_smps = IEEE80211_SMPS_OFF;
+			break;
+		}
+
+		ieee80211_queue_work(&local->hw, &local->recalc_smps);
+	}
+}
+
 void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
 {
 	struct sk_buff *skb2;
@@ -209,6 +243,10 @@ void ieee80211_tx_status(struct ieee8021
 		rate_control_tx_status(local, sband, sta, skb);
 		if (ieee80211_vif_is_mesh(&sta->sdata->vif))
 			ieee80211s_update_metric(local, sta, skb);
+
+		if (!(info->flags & IEEE80211_TX_CTL_INJECTED) &&
+		    (info->flags & IEEE80211_TX_STAT_ACK))
+			ieee80211_frame_acked(sta, skb);
 	}
 
 	rcu_read_unlock();
net/mac80211/main.c +24 -0
@@ -113,6 +113,18 @@ int ieee80211_hw_config(struct ieee80211
 		changed |= IEEE80211_CONF_CHANGE_CHANNEL;
 	}
 
+	if (!conf_is_ht(&local->hw.conf)) {
+		/*
+		 * mac80211.h documents that this is only valid
+		 * when the channel is set to an HT type, and
+		 * that otherwise STATIC is used.
+		 */
+		local->hw.conf.smps_mode = IEEE80211_SMPS_STATIC;
+	} else if (local->hw.conf.smps_mode != local->smps_mode) {
+		local->hw.conf.smps_mode = local->smps_mode;
+		changed |= IEEE80211_CONF_CHANGE_SMPS;
+	}
+
 	if (scan_chan)
 		power = chan->max_power;
 	else
@@ -297,6 +309,16 @@ void ieee80211_restart_hw(struct ieee802
 }
 EXPORT_SYMBOL(ieee80211_restart_hw);
 
+static void ieee80211_recalc_smps_work(struct work_struct *work)
+{
+	struct ieee80211_local *local =
+		container_of(work, struct ieee80211_local, recalc_smps);
+
+	mutex_lock(&local->iflist_mtx);
+	ieee80211_recalc_smps(local, NULL);
+	mutex_unlock(&local->iflist_mtx);
+}
+
 struct ieee80211_hw *ieee80211_alloc_hw(size_t priv_data_len,
 					const struct ieee80211_ops *ops)
 {
@@ -370,6 +392,8 @@ struct ieee80211_hw *ieee80211_alloc_hw(
 	INIT_WORK(&local->restart_work, ieee80211_restart_work);
 
 	INIT_WORK(&local->reconfig_filter, ieee80211_reconfig_filter);
+	INIT_WORK(&local->recalc_smps, ieee80211_recalc_smps_work);
+	local->smps_mode = IEEE80211_SMPS_OFF;
 
 	INIT_WORK(&local->dynamic_ps_enable_work,
 		  ieee80211_dynamic_ps_enable_work);
net/mac80211/util.c +74 -0

77 lines not on this page · raw message

drivers/net/wireless/mac80211_hwsim.c +19 -3
@@ -619,12 +619,26 @@ static int mac80211_hwsim_config(struct 
 {
 	struct mac80211_hwsim_data *data = hw->priv;
 	struct ieee80211_conf *conf = &hw->conf;
+	static const char *chantypes[4] = {
+		[NL80211_CHAN_NO_HT] = "noht",
+		[NL80211_CHAN_HT20] = "ht20",
+		[NL80211_CHAN_HT40MINUS] = "ht40-",
+		[NL80211_CHAN_HT40PLUS] = "ht40+",
+	};
+	static const char *smps_modes[IEEE80211_SMPS_NUM_MODES] = {
+		[IEEE80211_SMPS_AUTOMATIC] = "auto",
+		[IEEE80211_SMPS_OFF] = "off",
+		[IEEE80211_SMPS_STATIC] = "static",
+		[IEEE80211_SMPS_DYNAMIC] = "dynamic",
+	};
 
-	printk(KERN_DEBUG "%s:%s (freq=%d idle=%d ps=%d)\n",
+	printk(KERN_DEBUG "%s:%s (freq=%d/%s idle=%d ps=%d smps=%s)\n",
 	       wiphy_name(hw->wiphy), __func__,
 	       conf->channel->center_freq,
+	       chantypes[conf->channel_type],
 	       !!(conf->flags & IEEE80211_CONF_IDLE),
-	       !!(conf->flags & IEEE80211_CONF_PS));
+	       !!(conf->flags & IEEE80211_CONF_PS),
+	       smps_modes[conf->smps_mode]);
 
 	data->idle = !!(conf->flags & IEEE80211_CONF_IDLE);
 
@@ -1121,7 +1135,9 @@ static int __init init_mac80211_hwsim(vo
 			BIT(NL80211_IFTYPE_MESH_POINT);
 
 		hw->flags = IEEE80211_HW_MFP_CAPABLE |
-			    IEEE80211_HW_SIGNAL_DBM;
+			    IEEE80211_HW_SIGNAL_DBM |
+			    IEEE80211_HW_SUPPORTS_STATIC_SMPS |
+			    IEEE80211_HW_SUPPORTS_DYNAMIC_SMPS;
 
 		/* ask mac80211 to reserve space for magic */
 		hw->vif_data_size = sizeof(struct hwsim_vif_priv);
net/mac80211/driver-trace.h +2 -0
@@ -140,6 +140,7 @@ TRACE_EVENT(drv_config,
 		__field(u8, short_frame_max_tx_count)
 		__field(int, center_freq)
 		__field(int, channel_type)
+		__field(int, smps)
 	),
 
 	TP_fast_assign(
@@ -155,6 +156,7 @@ TRACE_EVENT(drv_config,
 		__entry->short_frame_max_tx_count = local->hw.conf.short_frame_max_tx_count;
 		__entry->center_freq = local->hw.conf.channel->center_freq;
 		__entry->channel_type = local->hw.conf.channel_type;
+		__entry->smps = local->hw.conf.smps_mode;
 	),
 
 	TP_printk(
net/mac80211/debugfs_netdev.c +108 -3

158 lines not on this page · raw message