e1000e: provide family-specific functions to manage VLAN filter arrays
Subsystems (2)
PATCH 1/9 e1000e: provide family-specific functions to manage VLAN filter arrays
From: Bruce Allan <[email protected]>
The two MAC-families that have VLAN filter table register arrays manage each a bit differently from one another, so provide family-specific functions for managing the register arrays and function pointers to access the appropriate function. Also make sure attempts to access these register arrays are not done on parts not supporting that feature.
---
drivers/net/e1000e/82571.c | 9 ++++++--- drivers/net/e1000e/e1000.h | 4 ++-- drivers/net/e1000e/es2lan.c | 4 +++- drivers/net/e1000e/hw.h | 2 ++ drivers/net/e1000e/lib.c | 21 +++++++++++++++++++-- drivers/net/e1000e/netdev.c | 21 +++++++++++++-------- 6 files changed, 45 insertions(+), 16 deletions(-)
drivers/net/e1000e/82571.c +6 -3
@@ -65,6 +65,7 @@ static s32 e1000_fix_nvm_checksum_82571(struct e1000_hw *hw);static void e1000_initialize_hw_bits_82571 (struct e1000_hw *hw);static s32 e1000_setup_link_82571 (struct e1000_hw *hw);static void e1000_clear_hw_cntrs_82571 (struct e1000_hw *hw); +static void e1000_clear_vfta_82571 (struct e1000_hw *hw);static bool e1000_check_mng_mode_82574 (struct e1000_hw *hw);static s32 e1000_led_on_82574 (struct e1000_hw *hw);static void e1000_put_hw_semaphore_82571 (struct e1000_hw *hw);
@@ -949,7 +950,7 @@ static s32 e1000_init_hw_82571(struct e1000_hw *hw)/* Disabling VLAN filtering */ e_dbg ("Initializing the IEEE VLAN\n" ); -e1000e_clear_vfta (hw); + mac->ops.clear_vfta (hw);/* Setup the receive address. */ /*
@@ -1128,13 +1129,13 @@ static void e1000_initialize_hw_bits_82571(struct e1000_hw *hw) }/** -* e1000e_clear_vfta - Clear VLAN filter table +* e1000_clear_vfta_82571 - Clear VLAN filter table * @hw: pointer to the HW structure * * Clears the register array which contains the VLAN filter table by * setting all the values to 0. **/ -void e1000e_clear_vfta (struct e1000_hw *hw) +static void e1000_clear_vfta_82571 (struct e1000_hw *hw) {u32 offset;u32 vfta_value =0 ;
@@ -1656,6 +1657,8 @@ static struct e1000_mac_operations e82571_mac_ops = {/* .led_on: mac type dependent */ .led_off = e1000e_led_off_generic, .update_mc_addr_list = e1000_update_mc_addr_list_82571, + .write_vfta = e1000_write_vfta_generic, + .clear_vfta = e1000_clear_vfta_82571, .reset_hw = e1000_reset_hw_82571, .init_hw = e1000_init_hw_82571, .setup_link = e1000_setup_link_82571,
drivers/net/e1000e/e1000.h +2 -2
@@ -509,7 +509,7 @@ extern s32 e1000e_setup_fiber_serdes_link(struct e1000_hw *hw);extern s32 e1000e_copper_link_setup_m88 (struct e1000_hw *hw);extern s32 e1000e_copper_link_setup_igp (struct e1000_hw *hw);extern s32 e1000e_setup_link (struct e1000_hw *hw); -extern void e1000e_clear_vfta (struct e1000_hw *hw); +extern void e1000_clear_vfta_generic (struct e1000_hw *hw);extern void e1000e_init_rx_addrs (struct e1000_hw *hw,u16 rar_count); extern void e1000e_update_mc_addr_list_generic(struct e1000_hw *hw, u8 *mc_addr_list,
@@ -525,7 +525,7 @@ extern void e1000e_config_collision_dist(struct e1000_hw *hw);extern s32 e1000e_config_fc_after_link_up (struct e1000_hw *hw);extern s32 e1000e_force_mac_fc (struct e1000_hw *hw);extern s32 e1000e_blink_led (struct e1000_hw *hw); -extern void e1000e_write_vfta (struct e1000_hw *hw,u32 offset,u32 value); +extern void e1000_write_vfta_generic (struct e1000_hw *hw,u32 offset,u32 value);extern void e1000e_reset_adaptive (struct e1000_hw *hw);extern void e1000e_update_adaptive (struct e1000_hw *hw);
drivers/net/e1000e/es2lan.c +3 -1
@@ -807,7 +807,7 @@ static s32 e1000_init_hw_80003es2lan(struct e1000_hw *hw)/* Disabling VLAN filtering */ e_dbg ("Initializing the IEEE VLAN\n" ); -e1000e_clear_vfta (hw); + mac->ops.clear_vfta (hw);/* Setup the receive address. */ e1000e_init_rx_addrs (hw, mac->rar_entry_count);
@@ -1350,6 +1350,8 @@ static struct e1000_mac_operations es2_mac_ops = { .led_on = e1000e_led_on_generic, .led_off = e1000e_led_off_generic, .update_mc_addr_list = e1000e_update_mc_addr_list_generic, + .write_vfta = e1000_write_vfta_generic, + .clear_vfta = e1000_clear_vfta_generic, .reset_hw = e1000_reset_hw_80003es2lan, .init_hw = e1000_init_hw_80003es2lan, .setup_link = e1000e_setup_link,
drivers/net/e1000e/hw.h +2 -0
@@ -741,6 +741,7 @@ struct e1000_mac_operations {s32 (*check_for_link)(struct e1000_hw *);s32 (*cleanup_led)(struct e1000_hw *);void (*clear_hw_cntrs)(struct e1000_hw *); +void (*clear_vfta)(struct e1000_hw *);s32 (*get_bus_info)(struct e1000_hw *);s32 (*get_link_up_info)(struct e1000_hw *,u16 *,u16 *);s32 (*led_on)(struct e1000_hw *);
@@ -751,6 +752,7 @@ struct e1000_mac_operations {s32 (*setup_link)(struct e1000_hw *);s32 (*setup_physical_interface)(struct e1000_hw *);s32 (*setup_led)(struct e1000_hw *); +void (*write_vfta)(struct e1000_hw *,u32 ,u32 ); };/* Function pointers for the PHY. */
drivers/net/e1000e/lib.c +19 -2
@@ -82,7 +82,24 @@ s32 e1000e_get_bus_info_pcie(struct e1000_hw *hw) }/** -* e1000e_write_vfta - Write value to VLAN filter table +* e1000_clear_vfta_generic - Clear VLAN filter table +* @hw: pointer to the HW structure +* +* Clears the register array which contains the VLAN filter table by +* setting all the values to 0. +**/ +void e1000_clear_vfta_generic (struct e1000_hw *hw) +{ +u32 offset; + +for (offset =0 ; offset <E1000_VLAN_FILTER_TBL_SIZE ; offset++) { +E1000_WRITE_REG_ARRAY (hw,E1000_VFTA , offset,0 ); +e1e_flush (); + } +} + +/** +* e1000_write_vfta_generic - Write value to VLAN filter table * @hw: pointer to the HW structure * @offset: register offset in VLAN filter table * @value: register value written to VLAN filter table
@@ -90,7 +107,7 @@ s32 e1000e_get_bus_info_pcie(struct e1000_hw *hw)* Writes value at the given offset in the register array which stores * the VLAN filter table. **/ -void e1000e_write_vfta (struct e1000_hw *hw,u32 offset,u32 value) +void e1000_write_vfta_generic (struct e1000_hw *hw,u32 offset,u32 value) {E1000_WRITE_REG_ARRAY (hw,E1000_VFTA , offset, value);e1e_flush ();
drivers/net/e1000e/netdev.c +13 -8
@@ -2031,11 +2031,14 @@ static void e1000_vlan_rx_add_vid(struct net_device *netdev, u16 vid) E1000_MNG_DHCP_COOKIE_STATUS_VLAN) && (vid == adapter->mng_vlan_id)) return; +/* add VID to filter table */ - index = (vid >>5 ) &0x7F ; - vfta =E1000_READ_REG_ARRAY (hw,E1000_VFTA , index); - vfta |= (1 << (vid &0x1F )); -e1000e_write_vfta (hw, index, vfta); +if (adapter->flags &FLAG_HAS_HW_VLAN_FILTER ) { + index = (vid >>5 ) &0x7F ; + vfta =E1000_READ_REG_ARRAY (hw,E1000_VFTA , index); + vfta |= (1 << (vid &0x1F )); + hw->mac.ops.write_vfta (hw, index, vfta); + } }static void e1000_vlan_rx_kill_vid (struct net_device *netdev,u16 vid)
@@ -2060,10 +2063,12 @@ static void e1000_vlan_rx_kill_vid(struct net_device *netdev, u16 vid) }/* remove VID from filter table */ - index = (vid >>5 ) &0x7F ; - vfta =E1000_READ_REG_ARRAY (hw,E1000_VFTA , index); - vfta &= ~(1 << (vid &0x1F )); -e1000e_write_vfta (hw, index, vfta); +if (adapter->flags &FLAG_HAS_HW_VLAN_FILTER ) { + index = (vid >>5 ) &0x7F ; + vfta =E1000_READ_REG_ARRAY (hw,E1000_VFTA , index); + vfta &= ~(1 << (vid &0x1F )); + hw->mac.ops.write_vfta (hw, index, vfta); + } }static void e1000_update_mng_vlan (struct e1000_adapter *adapter)
PATCH 2/9 e1000e: guard against buffer overflow in cable length tables
From: Bruce Allan <[email protected]>
---
drivers/net/e1000e/es2lan.c | 17 +++++++++++++---- drivers/net/e1000e/phy.c | 14 +++++++++++--- 2 files changed, 24 insertions(+), 7 deletions(-)
drivers/net/e1000e/es2lan.c +13 -4
@@ -99,6 +99,8 @@*/ static const u16 e1000_gg82563_cable_length_table[] = {0 ,60 ,115 ,150 ,150 ,60 ,115 ,150 ,180 ,180 ,0xFF }; +#define GG82563_CABLE_LENGTH_TABLE_SIZE \ + ARRAY_SIZE(e1000_gg82563_cable_length_table)static s32 e1000_setup_copper_link_80003es2lan (struct e1000_hw *hw);static s32 e1000_acquire_swfw_sync_80003es2lan (struct e1000_hw *hw,u16 mask);
@@ -694,20 +696,27 @@ static s32 e1000_phy_force_speed_duplex_80003es2lan(struct e1000_hw *hw)static s32 e1000_get_cable_length_80003es2lan (struct e1000_hw *hw) {struct e1000_phy_info *phy = &hw->phy; -s32 ret_val; +s32 ret_val =0 ;u16 phy_data, index; ret_val =e1e_rphy (hw,GG82563_PHY_DSP_DISTANCE , &phy_data);if (ret_val) -return ret_val; + goto out; index = phy_data &GG82563_DSPD_CABLE_LENGTH ; + +if (index >=GG82563_CABLE_LENGTH_TABLE_SIZE -5 ) { + ret_val = -E1000_ERR_PHY ; + goto out; + } + phy->min_cable_length = e1000_gg82563_cable_length_table[index]; - phy->max_cable_length = e1000_gg82563_cable_length_table[index+5 ]; + phy->max_cable_length = e1000_gg82563_cable_length_table[index +5 ]; phy->cable_length = (phy->min_cable_length + phy->max_cable_length) /2 ; -return 0 ; +out: +return ret_val; }/**
drivers/net/e1000e/phy.c +11 -3
@@ -44,6 +44,8 @@ static s32 e1000_access_phy_debug_regs_hv(struct e1000_hw *hw, u32 offset,/* Cable length tables */ static const u16 e1000_m88_cable_length_table[] = {0 ,50 ,80 ,110 ,140 ,140 ,E1000_CABLE_LENGTH_UNDEFINED }; +#define M88E1000_CABLE_LENGTH_TABLE_SIZE \ + ARRAY_SIZE(e1000_m88_cable_length_table)static const u16 e1000_igp_2_cable_length_table[] = {0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,3 ,5 ,8 ,11 ,13 ,16 ,18 ,21 ,0 ,0 ,0 ,3 ,
@@ -1717,15 +1719,21 @@ s32 e1000e_get_cable_length_m88(struct e1000_hw *hw) ret_val =e1e_rphy (hw,M88E1000_PHY_SPEC_STATUS , &phy_data);if (ret_val) -return ret_val; + goto out; index = (phy_data &M88E1000_PSSR_CABLE_LENGTH ) >> -M88E1000_PSSR_CABLE_LENGTH_SHIFT ; +M88E1000_PSSR_CABLE_LENGTH_SHIFT ; +if (index >=M88E1000_CABLE_LENGTH_TABLE_SIZE -1 ) { + ret_val = -E1000_ERR_PHY ; + goto out; + } + phy->min_cable_length = e1000_m88_cable_length_table[index]; - phy->max_cable_length = e1000_m88_cable_length_table[index+1 ]; + phy->max_cable_length = e1000_m88_cable_length_table[index +1 ]; phy->cable_length = (phy->min_cable_length + phy->max_cable_length) /2 ; +out:return ret_val; }
PATCH 3/9 e1000e: provide family-specific PHY power up/down operations
In reply to Jeff KirsherFrom: Bruce Allan <[email protected]>
The different families (80003es2lan, 8257x, ICHx/PCH) supported by the driver each have their own conditions when the PHY can be powered down. This patch rewrites the PHY power up/down code to fit with the family- specific style used in the driver. All pre-existing calls to power up or down the PHY remain untouched. A new call to power down the PHY when removing the driver when the interface is down replaces the current call to reset the PHY in order to reduce power consumption.
---
drivers/net/e1000e/82571.c | 26 ++++++++++++++++++++++ drivers/net/e1000e/e1000.h | 2 ++ drivers/net/e1000e/es2lan.c | 21 ++++++++++++++++++ drivers/net/e1000e/hw.h | 2 ++ drivers/net/e1000e/ich8lan.c | 23 +++++++++++++++++++ drivers/net/e1000e/netdev.c | 50 +++++++++--------------------------------- drivers/net/e1000e/phy.c | 37 +++++++++++++++++++++++++++++++ 7 files changed, 122 insertions(+), 39 deletions(-)
drivers/net/e1000e/82571.c +26 -0
@@ -69,6 +69,7 @@ static void e1000_clear_vfta_82571(struct e1000_hw *hw);static bool e1000_check_mng_mode_82574 (struct e1000_hw *hw);static s32 e1000_led_on_82574 (struct e1000_hw *hw);static void e1000_put_hw_semaphore_82571 (struct e1000_hw *hw); +static void e1000_power_down_phy_copper_82571 (struct e1000_hw *hw);/** * e1000_init_phy_params_82571 - Init PHY func ptrs.
@@ -88,6 +89,9 @@ static s32 e1000_init_phy_params_82571(struct e1000_hw *hw) phy->autoneg_mask =AUTONEG_ADVERTISE_SPEED_DEFAULT ; phy->reset_delay_us =100 ; + phy->ops.power_up = e1000_power_up_phy_copper; + phy->ops.power_down = e1000_power_down_phy_copper_82571; +switch (hw->mac.type) {case e1000_82571:case e1000_82572:
@@ -1601,6 +1605,28 @@ static s32 e1000_fix_nvm_checksum_82571(struct e1000_hw *hw) }/** +* e1000_power_down_phy_copper_82571 - Remove link during PHY power down +* @hw: pointer to the HW structure +* +* In the case of a PHY power down to save power, or to turn off link during a +* driver unload, or wake on lan is not enabled, remove the link. +**/ +static void e1000_power_down_phy_copper_82571 (struct e1000_hw *hw) +{ +struct e1000_phy_info *phy = &hw->phy; +struct e1000_mac_info *mac = &hw->mac; + +if (!(phy->ops.check_reset_block)) +return ; + +/* If the management interface is not enabled, then power down */ +if (!(mac->ops.check_mng_mode (hw) || phy->ops.check_reset_block (hw))) +e1000_power_down_phy_copper (hw); + +return ; +} + +/** * e1000_clear_hw_cntrs_82571 - Clear device specific hardware counters * @hw: pointer to the HW structure *
drivers/net/e1000e/e1000.h +2 -0
@@ -568,6 +568,8 @@ extern s32 e1000e_read_kmrn_reg_locked(struct e1000_hw *hw, u32 offset,extern s32 e1000e_phy_has_link_generic (struct e1000_hw *hw,u32 iterations,u32 usec_interval,bool *success);extern s32 e1000e_phy_reset_dsp (struct e1000_hw *hw); +extern void e1000_power_up_phy_copper (struct e1000_hw *hw); +extern void e1000_power_down_phy_copper (struct e1000_hw *hw);extern s32 e1000e_read_phy_reg_mdic (struct e1000_hw *hw,u32 offset,u16 *data);extern s32 e1000e_write_phy_reg_mdic (struct e1000_hw *hw,u32 offset,u16 data);extern s32 e1000e_check_downshift (struct e1000_hw *hw);
drivers/net/e1000e/es2lan.c +21 -0
@@ -114,6 +114,7 @@ static s32 e1000_read_kmrn_reg_80003es2lan(struct e1000_hw *hw, u32 offset, u16 *data);static s32 e1000_write_kmrn_reg_80003es2lan (struct e1000_hw *hw,u32 offset,u16 data); +static void e1000_power_down_phy_copper_80003es2lan (struct e1000_hw *hw);/** * e1000_init_phy_params_80003es2lan - Init ESB2 PHY func ptrs.
@@ -127,6 +128,9 @@ static s32 e1000_init_phy_params_80003es2lan(struct e1000_hw *hw)if (hw->phy.media_type != e1000_media_type_copper) { phy->type = e1000_phy_none;return 0 ; + }else { + phy->ops.power_up = e1000_power_up_phy_copper; + phy->ops.power_down = e1000_power_down_phy_copper_80003es2lan; } phy->addr =1 ;
@@ -1303,6 +1307,23 @@ static s32 e1000_write_kmrn_reg_80003es2lan(struct e1000_hw *hw, u32 offset, }/** +* e1000_power_down_phy_copper_80003es2lan - Remove link during PHY power down +* @hw: pointer to the HW structure +* +* In the case of a PHY power down to save power, or to turn off link during a +* driver unload, or wake on lan is not enabled, remove the link. +**/ +static void e1000_power_down_phy_copper_80003es2lan (struct e1000_hw *hw) +{ +/* If the management interface is not enabled, then power down */ +if (!(hw->mac.ops.check_mng_mode (hw) || + hw->phy.ops.check_reset_block (hw))) +e1000_power_down_phy_copper (hw); + +return ; +} + +/** * e1000_clear_hw_cntrs_80003es2lan - Clear device specific hardware counters * @hw: pointer to the HW structure *
drivers/net/e1000e/hw.h +2 -0
@@ -774,6 +774,8 @@ struct e1000_phy_operations {s32 (*set_d3_lplu_state)(struct e1000_hw *,bool );s32 (*write_reg)(struct e1000_hw *,u32 ,u16 );s32 (*write_reg_locked)(struct e1000_hw *,u32 ,u16 ); +void (*power_up)(struct e1000_hw *); +void (*power_down)(struct e1000_hw *); };/* Function pointers for the NVM. */
drivers/net/e1000e/ich8lan.c +23 -0
@@ -217,6 +217,7 @@ static s32 e1000_cleanup_led_pchlan(struct e1000_hw *hw);static s32 e1000_led_on_pchlan (struct e1000_hw *hw);static s32 e1000_led_off_pchlan (struct e1000_hw *hw);static s32 e1000_set_lplu_state_pchlan (struct e1000_hw *hw,bool active); +static void e1000_power_down_phy_copper_ich8lan (struct e1000_hw *hw);static void e1000_lan_init_done_ich8lan (struct e1000_hw *hw);static s32 e1000_k1_gig_workaround_hv (struct e1000_hw *hw,bool link);
@@ -266,6 +267,8 @@ static s32 e1000_init_phy_params_pchlan(struct e1000_hw *hw) phy->ops.set_d3_lplu_state = e1000_set_lplu_state_pchlan; phy->ops.write_reg = e1000_write_phy_reg_hv; phy->ops.write_reg_locked = e1000_write_phy_reg_hv_locked; + phy->ops.power_up = e1000_power_up_phy_copper; + phy->ops.power_down = e1000_power_down_phy_copper_ich8lan; phy->autoneg_mask =AUTONEG_ADVERTISE_SPEED_DEFAULT ; phy->id = e1000_phy_unknown;
@@ -299,6 +302,9 @@ static s32 e1000_init_phy_params_ich8lan(struct e1000_hw *hw) phy->addr =1 ; phy->reset_delay_us =100 ; + phy->ops.power_up = e1000_power_up_phy_copper; + phy->ops.power_down = e1000_power_down_phy_copper_ich8lan; +/* * We may need to do this twice - once for IGP and if that fails, * we'll set BM func pointers and try again
@@ -3392,6 +3398,23 @@ static s32 e1000_get_cfg_done_ich8lan(struct e1000_hw *hw) }/** +* e1000_power_down_phy_copper_ich8lan - Remove link during PHY power down +* @hw: pointer to the HW structure +* +* In the case of a PHY power down to save power, or to turn off link during a +* driver unload, or wake on lan is not enabled, remove the link. +**/ +static void e1000_power_down_phy_copper_ich8lan (struct e1000_hw *hw) +{ +/* If the management interface is not enabled, then power down */ +if (!(hw->mac.ops.check_mng_mode (hw) || + hw->phy.ops.check_reset_block (hw))) +e1000_power_down_phy_copper (hw); + +return ; +} + +/** * e1000_clear_hw_cntrs_ich8lan - Clear statistical counters * @hw: pointer to the HW structure *
drivers/net/e1000e/netdev.c +11 -39
81 lines not on this page · raw message
drivers/net/e1000e/phy.c +37 -0
@@ -2534,6 +2534,43 @@ out: }/** +* e1000_power_up_phy_copper - Restore copper link in case of PHY power down +* @hw: pointer to the HW structure +* +* In the case of a PHY power down to save power, or to turn off link during a +* driver unload, or wake on lan is not enabled, restore the link to previous +* settings. +**/ +void e1000_power_up_phy_copper (struct e1000_hw *hw) +{ +u16 mii_reg =0 ; + +/* The PHY will retain its settings across a power down/up cycle */ +e1e_rphy (hw,PHY_CONTROL , &mii_reg); + mii_reg &= ~MII_CR_POWER_DOWN ; +e1e_wphy (hw,PHY_CONTROL , mii_reg); +} + +/** +* e1000_power_down_phy_copper - Restore copper link in case of PHY power down +* @hw: pointer to the HW structure +* +* In the case of a PHY power down to save power, or to turn off link during a +* driver unload, or wake on lan is not enabled, restore the link to previous +* settings. +**/ +void e1000_power_down_phy_copper (struct e1000_hw *hw) +{ +u16 mii_reg =0 ; + +/* The PHY will retain its settings across a power down/up cycle */ +e1e_rphy (hw,PHY_CONTROL , &mii_reg); + mii_reg |=MII_CR_POWER_DOWN ; +e1e_wphy (hw,PHY_CONTROL , mii_reg); +msleep (1 ); +} + +/** * e1000e_commit_phy - Soft PHY reset * @hw: pointer to the HW structure *
From: Jeff Kirsher <[email protected]>
Date: Tue, 01 Dec 2009 17:46:43 -0800
Quoted 10 lines
From: Bruce Allan <[email protected]>
The two MAC-families that have VLAN filter table register arrays manage each a bit differently from one another, so provide family-specific functions for managing the register arrays and function pointers to access the appropriate function. Also make sure attempts to access these register arrays are not done on parts not supporting that feature.
Signed-off-by Bruce Allan <[email protected]>Signed-off-by Jeff Kirsher <[email protected]>
Applied.
Re: [net-next-2.6 PATCH 2/9] e1000e: guard against buffer overflow in cable length tables
In reply to Jeff KirsherFrom: Jeff Kirsher <[email protected]>
Date: Tue, 01 Dec 2009 17:47:02 -0800
Quoted 4 lines
From: Bruce Allan <[email protected]>
Signed-off-by Bruce Allan <[email protected]>Signed-off-by Jeff Kirsher <[email protected]>
Applied.
Re: [net-next-2.6 PATCH 3/9] e1000e: provide family-specific PHY power up/down operations
In reply to Jeff KirsherFrom: Jeff Kirsher <[email protected]>
Date: Tue, 01 Dec 2009 17:47:22 -0800
Quoted 10 lines
From: Bruce Allan <[email protected]>
The different families (80003es2lan, 8257x, ICHx/PCH) supported by the driver each have their own conditions when the PHY can be powered down. This patch rewrites the PHY power up/down code to fit with the family- specific style used in the driver. All pre-existing calls to power up or down the PHY remain untouched. A new call to power down the PHY when removing the driver when the interface is down replaces the current call to reset the PHY in order to reduce power consumption.
Quoted 2 lines
Signed-off-by Bruce Allan <[email protected]>Signed-off-by Jeff Kirsher <[email protected]>
Applied.