Skip to contentSkip to conversation

ACPICA: update documentation to reflect correct parameter name

PATCH In review Anisse Astier 3 participants 5 messages Dec 4, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPICA: update documentation to reflect correct parameter name

Second parameter for function acpi_ut_copy_iobject_to_eobject is named ret_buffer, not buffer_ptr, since longer than git can remember.

---
Hi,

ACPICA is somewhat auto-generated. How can this trivial patch be applied?

Regards,

Anisse

 drivers/acpi/acpica/utcopy.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/acpi/acpica/utcopy.c +0 -0
index 0f0c64b..ecfa7f9 100644
@@ -382,7 +382,7 @@ acpi_ut_copy_ipackage_to_epackage(union

acpi_operand_object *internal_object,
* FUNCTION: acpi_ut_copy_iobject_to_eobject
*

  * PARAMETERS:  internal_object     - The internal object to be converted
- *              buffer_ptr          - Where the object is returned
+ *              ret_buffer          - Where the object is returned

*
* RETURN: Status
*

Signature · 1 line
1.6.5.3
#1 lore raw
Quoted 1 line

since longer than git can remember.

What does this mean?

Quoted 41 lines

-----Original Message-----
From: Anisse Astier [mailto:[email protected]]
Sent: Friday, December 04, 2009 6:36 AM
To: [email protected]
Cc: Len Brown; Moore, Robert; Jiri Kosina
Subject: [PATCH] ACPICA: update documentation to reflect correct parameter name

Second parameter for function acpi_ut_copy_iobject_to_eobject is named ret_buffer, not buffer_ptr, since longer than git can remember.

---
Hi,

ACPICA is somewhat auto-generated. How can this trivial patch be applied?

Regards,

Anisse

drivers/acpi/acpica/utcopy.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
drivers/acpi/acpica/utcopy.c +1 -1
index 0f0c64b..ecfa7f9 100644
@@ -382,7 +382,7 @@ acpi_ut_copy_ipackage_to_epackage(union
 acpi_operand_object *internal_object,
 * FUNCTION:    acpi_ut_copy_iobject_to_eobject
 *
 * PARAMETERS:  internal_object     - The internal object to be converted
- *              buffer_ptr          - Where the object is returned
+ *              ret_buffer          - Where the object is returned
 *
 * RETURN:      Status

*
--
1.6.5.3

#2 lore raw
Quoted 3 lines · Robert
Quoted 1 line

since longer than git can remember.

What does this mean?

That it's not easily trackable who introduced this and when, I'd say ...

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.
#3 lore raw
Quoted 8 lines · Jiri Kosina
Quoted 3 lines · Robert
Quoted 1 line

since longer than git can remember.

What does this mean?

That it's not easily trackable who introduced this and when, I'd say ...

Indeed, what I meant is that this documentation error has been present since before the introduction of git in kernel 2.6.12-rc2.

#4 lore raw

Ok, I understand.

I just fixed this in ACPICA (along with a couple others). It will be released in mid-december, then will be merged into Linux.

Thanks!
Bob

Quoted 23 lines

-----Original Message-----
From: Anisse Astier [mailto:[email protected]]
Sent: Friday, December 04, 2009 6:55 AM
To: Jiri Kosina
Cc: Moore, Robert; [email protected]; Len Brown
Subject: Re: [PATCH] ACPICA: update documentation to reflect correct parameter name

Quoted 8 lines · Jiri Kosina
Quoted 3 lines · Robert
Quoted 1 line

since longer than git can remember.

What does this mean?

That it's not easily trackable who introduced this and when, I'd say ...

Indeed, what I meant is that this documentation error has been present since
before the introduction of git in kernel 2.6.12-rc2.