Skip to contentSkip to conversation

potential null deref in lpfc_els.c

PATCH New Dan Carpenter 1 participant 1 message Dec 5, 2009

Subsystems (2)
SCSI Emulex/Broadcom lpfc FC/FCoE SCSI driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 potential null deref in lpfc_els.c

This patch is against 2.6.32-rc8.

The issue was found by a static checker. If cmd == ELS_CMD_PLOGI, it is possible for ndlp to be NULL. We do check ndlp further down the function so that would also indicate that we should check ndlp here.

Compile tested.

Signed-off-by Dan Carpenter <[email protected]>
drivers/scsi/lpfc/lpfc_els.c +1 -1
@@ -2548,7 +2548,7 @@ lpfc_els_retry(struct lpfc_hba *phba, st
 
 	lpfc_debugfs_disc_trc(vport, LPFC_DISC_TRC_ELS_CMD,
 		"Retry ELS:       wd7:x%x wd4:x%x did:x%x",
-		*(((uint32_t *) irsp) + 7), irsp->un.ulpWord[4], ndlp->nlp_DID);
+		*(((uint32_t *) irsp) + 7), irsp->un.ulpWord[4], (ndlp ? ndlp->nlp_DID : 0));
 
 	switch (irsp->ulpStatus) {
 	case IOSTAT_FCP_RSP_ERROR: