Skip to contentSkip to conversation

dspbridge sync proposal for 0.1

DISCUSSION Felipe Contreras 4 participants 6 messages Dec 5, 2009 – Dec 15, 2009

lore
Share & tools
lore
#0 lore raw

Hi,

There is a proposal to get the dspbridge branch into a decent state for the 0.1 release, so I've been trying to synchronize the internal maemo branch with the upstream one.

Unfortunately, there are severe issues:
* TI modified the patches sent by Nokia
* Many patches have never been sent to l-o for review

And more importantly; I couldn't get it to work, neither on the N900, nor the beagleboard (I didn't try very hard, though). So I decided to compare the branches patch by patch.

First, I found the last synchronization point is:
6cc7482 DSPBRIDGE: Buffer size warning fixes

It's not exactly synchronized, as it's missing some patches from Nokia, but it's as good as it gets.

Then I marked each patch as "ok" if they are in both branches, "needs sync" if it was modified, "!l-m" if it was not in the maemo branch, and "unrev" if it was never sent for review.

Next I tried to come up with something that could resemble the current maemo branch, but I found no easy way. So, what I did is to pick each patch that was somehow present on both branches (I used the Nokia version for the patches that came from Nokia), then, pick all the patches that were only in the upstream branch, but have been sent for review, and finally, apply any other necessary patches. Needless to say; this was not straightforward; I had to resolve many conflcts, and drop many patches.

The end result is my proposal for 0.1 which is something that resembles the maemo branch, works both on the N900 (based on 2.6.28), and the beagleboard (using 2.6.32 without DVFS). There are still many patches missing, both from the upstream and maemo branches, but I think those should be tackled in 0.2.

The only change needed from 2.6.28 to 2.6.32 seems to be IO_ADDRESS -> OMAP2_IO_ADDRESS, but I guess it would be much better to use ioremap instead, so the same code works everywhere. Any volunteers? :)

All the branches are in:
http://gitorious.org/~felipec/linux-omap/felipec

* dspbridge-0.1:: 0.1 proposal
* dspbridge-0.1-base:: last synchronization point
* dspbridge-0.1-step1:: first step: patches on both branches
* dspbridge-0.1-step2:: second step: patches only on upstream
* dspbridge-0.2-maemo:: maemo patches for 0.2

For more detail in my analysis of the current dspbridge branch check:
http://people.freedesktop.org/~felipec/dspbridge-0.1-sync.html

Comments?

Signature · 1 line
Felipe Contreras
#1 lore raw
Quoted 3 lines · Felipe Contreras

There is a proposal to get the dspbridge branch into a decent state for the 0.1 release, so I've been trying to synchronize the internal maemo branch with the upstream one.

After a few private discussions with Omar here's v2 which is essentially the same except many patches are taking from TI. There's not much difference in the actual content, the difference it's mostly in the commit messages:

All the branches are in:
http://gitorious.org/~felipec/linux-omap/felipec

The branch for the current proposal is 'dspbridge-0.1-v2'.

Cheers.

Signature · 1 line
Felipe Contreras
#2 lore raw

Hi,

Quoted 14 lines

From: Felipe Contreras [mailto:[email protected]]
Sent: Monday, December 14, 2009 10:04 AM

Quoted 3 lines · Felipe Contreras

There is a proposal to get the dspbridge branch into a decent state for the 0.1 release, so I've been trying to synchronize the internal maemo branch with the upstream one.

After a few private discussions with Omar here's v2 which is essentially the same except many patches are taking from TI. There's not much difference in the actual content, the difference it's mostly in the commit messages:

Quoted 5 lines

All the branches are in:
http://gitorious.org/~felipec/linux-omap/felipec

The branch for the current proposal is 'dspbridge-0.1-v2'.

As a follow up...

After the analysis of both branches (current dspbridge and dspbridge-0.1) and the need to resend the patches that haven't been reviewed. It was decided that the unsent patches would be reverted and sent to the list for review, given the need to have a baseline that works for most of the OMAP 3 platforms, I took Felipe's patch order proposal (as it is working for N900) and recreated the future dspbridge branch.

This can be found at:
http://dev.omapzoom.org/?p=tidspbridge/kernel-dspbridge.git;a=summary dspbridge-baseline-v2

Differences:

- DSPBRIDGE: enable smart/autoidle for mailbox sysconfig Patch dropped until final version is discussed

- DSPBRIDGE: Pass filp->private to all the ioctl wrappers
Patch dropped until resource cleanup patches are discussed, this to keep the entire series of resource cleanup changes out.

- DSPBRIDGE: Increased DMM size to 256MB
Will be pushed on top of all patches as it seems it is breaking N900, this until failure is root caused.

- DSPBRIDGE: Remove PID usage and replace with TGID Pushed as it was sent to LO mailing list.

Next step will be to send the unreviewed patches and continue until no patches are missing. For now and until -baseline-v2 is synchronized, further development will continue on dspbridge-next.

Regards,

Omar

#3 lore raw
Quoted 4 lines · Omar

After the analysis of both branches (current dspbridge and dspbridge-0.1) and the need to resend the patches that haven't been reviewed. It was decided that the unsent patches would be reverted and sent to the list for review, given the need to have a baseline that works for most of the OMAP 3 platforms, I took Felipe's patch order proposal (as it is working for N900) and recreated the future dspbridge branch.

This can be found at:
http://dev.omapzoom.org/?p=tidspbridge/kernel-dspbridge.git;a=summary  dspbridge-baseline-v2

There's something wrong with that repository; I can't retrieve it in any way:

% git remote add omar git://dev.omapzoom.org/pub/scm/tidspbrid
% git fetch omar
fatal: The remote end hung up unexpectedly
fatal: protocol error: bad pack header

% git clone git://dev.omapzoom.org/pub/scm/tidspbridge/kernel-dspbridge.git
--reference=~src/linux tmp-omar
Initialized empty Git repository in tmp-omar/.git/
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed

% git clone git://dev.omapzoom.org/pub/scm/tidspbridge/kernel-dspbridge.git
tmp-omar
Initialized empty Git repository in tmp-omar/.git/
remote: Counting objects: 1430544, done.
remote: Compressing objects: 100% (238646/238646), done.
fatal: The remote end hung up unexpectedly3.75 MiB | 37 KiB/s
fatal: early EOF
fatal: index-pack failed

Signature · 5 lines
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#4 lore raw
Quoted 2 lines

Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve Loubet. 036 420 040 R.C.S Antibes. Capital de EUR 753.920

-----Original Message-----

Quoted 19 lines

From: [email protected] [mailto:[email protected]] On Behalf Of Felipe Contreras
Sent: Tuesday, December 15, 2009 12:46 PM
To: Ramirez Luna, Omar
Cc: linux-omap; Hiroshi Doyu; Ameya Palande; Artem Bityutskiy; Shah, Bhavin; Tony Lindgren; Felipe Contreras
Subject: Re: dspbridge sync proposal for 0.1

Quoted 1 line · Omar

After the analysis of both branches (current dspbridge and

dspbridge-0.1) and the need to resend the patches that haven't been reviewed. It was decided that the unsent patches would be reverted and sent to the list for review, given the need to have a baseline that works for most of the OMAP 3 platforms, I took Felipe's patch order proposal (as it is working for N900) and recreated the future dspbridge branch.

Quoted 1 line
Quoted 8 lines
Quoted 2 lines

This can be found at:

http://dev.omapzoom.org/?p=tidspbridge/kernel-dspbridge.git;a=
summary

Quoted 1 line

dspbridge-baseline-v2

There's something wrong with that repository; I can't retrieve it in any way:

It's somehow a known issue. We are facing issues with dev.omapzoom.org and git.omapzoom.org servers and we are trying to resolve them.

Quoted 32 lines

% git remote add omar git://dev.omapzoom.org/pub/scm/tidspbrid
% git fetch omar
fatal: The remote end hung up unexpectedly
fatal: protocol error: bad pack header

% git clone
git://dev.omapzoom.org/pub/scm/tidspbridge/kernel-dspbridge.git
--reference=~src/linux tmp-omar Initialized empty Git repository in tmp-omar/.git/
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed

% git clone
git://dev.omapzoom.org/pub/scm/tidspbridge/kernel-dspbridge.git
tmp-omar
Initialized empty Git repository in tmp-omar/.git/
remote: Counting objects: 1430544, done.
remote: Compressing objects: 100% (238646/238646), done.
fatal: The remote end hung up unexpectedly3.75 MiB | 37 KiB/s
fatal: early EOF
fatal: index-pack failed

--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at
http://vger.kernel.org/majordomo-info.html

#5 lore raw
Quoted 1 line · Nicolas

It's somehow a known issue. We are facing issues with dev.omapzoom.org and git.omapzoom.org servers and we are trying to resolve them.

Thanks. The http one worked, but it took *ages*.

Signature · 1 line
Felipe Contreras