"Move do_irqinfo() to common/cmd_irq.c" breaks MVBLUE board...
Dear Peter,
your commit c253122395 (Move do_irqinfo() to common/cmd_irq.c) breaks building of the MVBLUE board:
-> ./MAKEALL MVBLUE
Configuring for MVBLUE board... common/libcommon.a(cmd_irq.o):(.u_boot_cmd+0x24): undefined reference to `do_irqinfo'
make: *** [u-boot] Error 1
Can you please have a look?
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de What's the sound a name makes when it's dropped?
Quoted 5 lines · Wolfgang Denk
Dear Peter,
your commit
c253122395(Movedo_irqinfo()tocommon/cmd_irq.c) breaks building of the MVBLUE board:
Quoted 7 lines
-> ./MAKEALL MVBLUE
Configuring for MVBLUE board... common/libcommon.a(cmd_irq.o):(.u_boot_cmd+0x24): undefined reference to `do_irqinfo'
make: *** [u-boot] Error 1Can you please have a look?
Sure, sorry for the breakage. Looks like MVBLUE has CONFIG_CMD_IRQ defined, but doesn't have CONFIG_CMD_MISC defined. Prior to my move, since the do_irqinfo() was inside cmd_misc.c, the do_irqinfo() call was never compiled.
So previously, CONFIG_CMD_IRQ had no effect and was ignored for the MVBLUE.
cpu/mpc824x/interrupts.c doesn't have do_irqinfo() implemented, which causes the problem.
I'll send a patch which removes CONFIG_CMD_IRQ from MVBLUE.h as a fix.
Best,
Peter
Quoted 19 lines · Peter Tyser
Quoted 5 lines · Wolfgang Denk
Dear Peter,
your commit
c253122395(Movedo_irqinfo()tocommon/cmd_irq.c) breaks building of the MVBLUE board:Quoted 7 lines
-> ./MAKEALL MVBLUE
Configuring for MVBLUE board... common/libcommon.a(cmd_irq.o):(.u_boot_cmd+0x24): undefined reference to `do_irqinfo'
make: *** [u-boot] Error 1Can you please have a look?
Sure, sorry for the breakage. Looks like MVBLUE has
CONFIG_CMD_IRQdefined, but doesn't haveCONFIG_CMD_MISCdefined. Prior to my move, since thedo_irqinfo()was insidecmd_misc.c, thedo_irqinfo()call was never compiled.
Quoted 7 lines
So previously,
CONFIG_CMD_IRQhad no effect and was ignored for the MVBLUE.
cpu/mpc824x/interrupts.cdoesn't havedo_irqinfo()implemented, which causes the problem.I'll send a patch which removes
CONFIG_CMD_IRQfromMVBLUE.has a fix.
On second thought, this will disable both the 'interrupts' and 'irqinfo' command for the MVBLUE. Andre, do you mind if the 'interrupts' command is not available the MVBLUE?
Thanks,
Peter
Peter,
Quoted 4 lines
On second thought, this will disable both the 'interrupts' and 'irqinfo' command for the MVBLUE. Andre, do you mind if the 'interrupts' command is not available the MVBLUE?
please go ahead - no problem at all.
Regards,
Andr?
MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich