Skip to contentSkip to conversation

FS-Cache: Avoid maybe-used-uninitialised warning on variable

PATCH New David Howells 1 participant 1 message Dec 6, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 FS-Cache: Avoid maybe-used-uninitialised warning on variable

Andrew Morton's compiler sees the following warning in FS-Cache:

fs/fscache/object-list.c: In function 'fscache_objlist_lookup':
fs/fscache/object-list.c:94: warning: 'obj' may be used uninitialized in this function

which my compiler doesn't. This is a false positive as obj can only be used in the comparison against minobj if minobj has been set to something other than NULL, but for that to happen, obj has to be first set to something.

Deal with this by preclearing obj too.

---

 fs/fscache/object-list.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/fscache/object-list.c +1 -1
index e590242..3221a0c 100644
@@ -91,7 +91,7 @@ EXPORT_SYMBOL(fscache_object_destroy);
  */
 static struct fscache_object *fscache_objlist_lookup(loff_t *_pos)
 {
-	struct fscache_object *pobj, *obj, *minobj = NULL;
+	struct fscache_object *pobj, *obj = NULL, *minobj = NULL;
 	struct rb_node *p;
 	unsigned long pos;