drivers/scsi/u14-34f.c: fix uffer overflow

PATCH New [email protected] 1 participant 1 message Dec 8, 2009 SCSI

lore

Share & tools

lore

[email protected]

author

2009-12-08 22:09 UTC #0 lore raw

PATCH 6/17 drivers/scsi/u14-34f.c: fix uffer overflow

From: Roel Kluin <[email protected]>

This allows i == MAX_INT_PARAM, which is out of range for ints[]

Found with Parfait, http://research.sun.com/projects/parfait/

Signed-off-by Roel Kluin <[email protected]>

Cc Dario Ballabio <[email protected]>

Cc James Bottomley <[email protected]>

Signed-off-by Andrew Morton <[email protected]>

---

 drivers/scsi/u14-34f.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/scsi/u14-34f.c renamed from drivers/scsi/u14-34f.c~drivers-scsi-u14-34fc-fix-uffer-overflow +1 -1

diff -puN drivers/scsi/u14-34f.c~drivers-scsi-u14-34fc-fix-uffer-overflow drivers/scsi/u14-34f.c
@@ -1070,7 +1070,7 @@ static int option_setup(char *str) {
    char *cur = str;
    int i = 1;
 
-   while (cur && isdigit(*cur) && i <= MAX_INT_PARAM) {
+   while (cur && isdigit(*cur) && i < MAX_INT_PARAM) {
       ints[i++] = simple_strtoul(cur, NULL, 0);
 
       if ((cur = strchr(cur, ',')) != NULL) cur++;