pass upstream rev to scripts/get_maintainer.pl
Hello,
I often face the "problem" that get_maintainer.pl yields my name, too, as the commits I want to send are included in HEAD.
I think the nicest fix for that would be to be able to pass an upstream rev à la:
scripts/get_maintainer.pl --upstream linus/master ...
. As my knowledge of perl is quite limited I only provide you with my quick'n'dirty patch I usually use, just to give you an idea.
Best regards
Uwe
scripts/get_maintainer.pl +3 -3
@@ -715,7 +715,7 @@ sub recent_git_signoffs { return; } - $cmd = "git log --since=${email_git_since} -- ${file}"; + $cmd = "git log --since=${email_git_since} linus/master -- ${file}"; $output = `${cmd}`; $output =~ s/^\s*//gm;
@@ -785,12 +785,12 @@ sub git_assign_blame { my $diff_start = $2; my $diff_length = $3; next if (!("$file" eq "$diff_file")); - $cmd = "git blame -l -L $diff_start,+$diff_length $file"; + $cmd = "git blame -l -L $diff_start,+$diff_length linus/master -- $file"; @commits = save_commits($cmd, @commits); } } else { if (-f $file) { - $cmd = "git blame -l $file"; + $cmd = "git blame -l linus/master -- $file"; @commits = save_commits($cmd, @commits); } }
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
Joe Perches
maintainerQuoted 2 lines · Uwe Kleine-König
I often face the "problem" that get_maintainer.pl yields my name, too, as the commits I want to send are included in HEAD.
Why is this a problem?
If you are using git send-email, does adding
--suppress-cc=self solve it?
Quoted 5 lines · Joe Perches
Quoted 2 lines · Uwe Kleine-K??nig
I often face the "problem" that get_maintainer.pl yields my name, too, as the commits I want to send are included in HEAD.
Why is this a problem?
With the limit on the number of people returned it's possible that authors of the patch series being posted (there may be more than one) will push out folks that it'd be good to include.
Joe Perches
maintainerQuoted 8 lines · Mark Brown
Quoted 4 lines · Joe Perches
Quoted 2 lines · Uwe Kleine-K??nig
I often face the "problem" that get_maintainer.pl yields my name, too, as the commits I want to send are included in HEAD.
Why is this a problem?
With the limit on the number of people returned it's possible that authors of the patch series being posted (there may be more than one) will push out folks that it'd be good to include.
You could use --git-max-maintainers=<value more than default>
Quoted 7 lines · Joe Perches
Quoted 3 lines · Mark Brown
With the limit on the number of people returned it's possible that authors of the patch series being posted (there may be more than one) will push out folks that it'd be good to include.
You could use --git-max-maintainers=<value more than default>
Of course, for that use case the patch is just a potentially clearer idiom for doing it.
Quoted 8 lines · Joe Perches
Quoted 2 lines · Uwe Kleine-König
I often face the "problem" that get_maintainer.pl yields my name, too, as the commits I want to send are included in HEAD.
Why is this a problem?
If you are using git send-email, does adding
--suppress-cc=self solve it?
I use get_maintainer.pl to add Cc: entries to changelogs, not as cc-prog of git send-email. So the alternative solution is to use grep here. Anyhow I consider the suggestion I pointed out nicer.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |