Skip to contentSkip to conversation

net: smc91x: Fix up type mismatch in smc_drv_resume().

PATCH Applied Paul Mundt 2 participants 2 messages Dec 11, 2009

Subsystems (2)
lore
Share & tools
lore

Paul Mundt

author
#0 lore raw

PATCH 1/1 net: smc91x: Fix up type mismatch in smc_drv_resume().

smc_drv_resume() takes a struct device, while smc_enable_device() takes a platform device. This fixes up the smc_enable_device() callsite with the proper pointer.

It's not obvious when this change was introduced, as git history doesn't go back that far. Presumably the resume code has always been broken in this fashion.

---

 drivers/net/smc91x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/smc91x.c +1 -1
index ae4983a..5c9222d 100644
@@ -2387,7 +2387,7 @@ static int smc_drv_resume(struct device *dev)
 
 	if (ndev) {
 		struct smc_local *lp = netdev_priv(ndev);
-		smc_enable_device(dev);
+		smc_enable_device(pdev);
 		if (netif_running(ndev)) {
 			smc_reset(ndev);
 			smc_enable(ndev);
maintainer Applied
#1 lore raw

From: Paul Mundt <[email protected]>
Date: Fri, 11 Dec 2009 15:42:27 +0900

Quoted 9 lines

smc_drv_resume() takes a struct device, while smc_enable_device() takes a platform device. This fixes up the smc_enable_device() callsite with the proper pointer.

It's not obvious when this change was introduced, as git history doesn't go back that far. Presumably the resume code has always been broken in this fashion.

Applied.