Skip to contentSkip to conversation

commit fc7b92fca4e546184557f1c53f84ad57c66b7695 broke compilation

DISCUSSION Felipe Balbi 2 participants 3 messages Dec 15, 2009

lore
Share & tools
lore
#0 lore raw

Hi,

the patch renaming twl4030 to twl broke compilation of several omap boards.

Here are all the files including a file that doesn't exist anymore:

arch/arm/mach-omap2/board-cm-t35.c:#include <linux/i2c/twl4030.h> arch/arm/mach-omap2/board-igep0020.c:#include <linux/i2c/twl4030.h> arch/arm/mach-omap2/board-omap3evm.c:#include <linux/i2c/twl4030.h> arch/arm/mach-omap2/board-omap3touchbook.c:#include <linux/i2c/twl4030.h> arch/arm/mach-omap2/board-rx51-peripherals.c:#include <linux/i2c/twl4030.h> arch/arm/mach-omap2/board-zoom-peripherals.c:#include <linux/i2c/twl4030.h> drivers/mfd/twl4030-codec.c:#include <linux/i2c/twl4030.h> drivers/video/omap/lcd_ldp.c:#include <linux/i2c/twl4030.h> drivers/video/omap/lcd_omap2evm.c:#include <linux/i2c/twl4030.h> drivers/video/omap/lcd_omap3beagle.c:#include <linux/i2c/twl4030.h> drivers/video/omap/lcd_omap3evm.c:#include <linux/i2c/twl4030.h> drivers/video/omap/lcd_overo.c:#include <linux/i2c/twl4030.h> sound/soc/omap/sdp3430.c:#include <linux/i2c/twl4030.h>

Signature · 1 line
balbi
#1 lore raw
Quoted 7 lines

-----Original Message-----
From: Felipe Balbi [mailto:[email protected]]
Sent: Tuesday, December 15, 2009 5:28 PM
To: Linux OMAP Mailing List
Cc: Krishnamoorthy, Balaji T
Subject: commit fc7b92fca4e546184557f1c53f84ad57c66b7695 broke compilation

Quoted 7 lines

Hi,

the patch renaming twl4030 to twl broke compilation of several omap boards.

Here are all the files including a file that doesn't exist anymore:

Thanks Felipe,
I am preparing a patch for this.

Thanks and Regards,
Balaji T K

Quoted 2 lines

--
balbi

#2 lore raw
Quoted 9 lines · Balaji T
Quoted 9 lines

-----Original Message-----
From: Felipe Balbi [mailto:[email protected]]
Sent: Tuesday, December 15, 2009 5:28 PM
To: Linux OMAP Mailing List
Cc: Krishnamoorthy, Balaji T
Subject: commit fc7b92fca4e546184557f1c53f84ad57c66b7695 broke compilation

Hi,

Quoted 7 lines
Quoted 5 lines

the patch renaming twl4030 to twl broke compilation of several omap boards.

Here are all the files including a file that doesn't exist anymore:

Thanks Felipe,
I am preparing a patch for this.

please, compile test with all omap3 defconfigs to be sure.

something like:

for i in ls arch/arm/configs | grep omap | grep -v 'omap-l137'; do

	make CROSS_COMPILE=arm-linux- ARCH=arm $i defconfig;
	make CROSS_COMPILE=arm-linux- ARCH=arm;

done

this won't get rx51_defconfig or n8x0_deconfig nor n770_defconfig, but it's good enough. rx51_defconfig is the only of those three that twl4030 anyways.

Signature · 1 line
balbi