Skip to contentSkip to conversation

refuse checkpoint of file with f_owner

RFC PATCH In review Serge E. Hallyn 2 participants 3 messages Dec 16, 2009 – Dec 23, 2009 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 refuse checkpoint of file with f_owner

... because we don't yet support its restore.

---
 checkpoint/files.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
checkpoint/files.c +12 -0
index c8e8d7f..cac5236 100644
@@ -261,6 +261,7 @@ static int checkpoint_file_desc(struct ckpt_ctx *ctx,
 	struct fdtable *fdt;
 	int objref, ret;
 	int coe = 0;	/* avoid gcc warning */
+	pid_t pid;
 
 	h = ckpt_hdr_get_type(ctx, sizeof(*h), CKPT_HDR_FILE_DESC);
 	if (!h)
@@ -283,6 +284,17 @@ static int checkpoint_file_desc(struct ckpt_ctx *ctx,
 	}
 
 	/*
+	 * TODO: Implement c/r of fowner and f_sigio.  Should be
+	 * trivial, but for now we just refuse its checkpoint
+	 */
+	pid = f_getown(file);
+	if (pid) {
+		ret = -EBUSY;
+		ckpt_err(ctx, ret, "%(T)fd %d has an owner (%d)\n", fd);
+		goto out;
+	}
+
+	/*
 	 * if seen first time, this will add 'file' to the objhash, keep
 	 * a reference to it, dump its state while at it.
 	 */
Signature · 1 line
1.6.0.4

A message that is not in the archive (sent off-list or not yet received): 20091216212258.GA31602-r/[email protected]

#3 lore raw
In reply to a message not in the archive

Also for v19-rc3.

Quoted 37 lines · Serge E. Hallyn

... because we don't yet support its restore.

---
 checkpoint/files.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
checkpoint/files.c +12 -0
index c8e8d7f..cac5236 100644
@@ -261,6 +261,7 @@ static int checkpoint_file_desc(struct ckpt_ctx *ctx,
 	struct fdtable *fdt;
 	int objref, ret;
 	int coe = 0;	/* avoid gcc warning */
+	pid_t pid;
 
 	h = ckpt_hdr_get_type(ctx, sizeof(*h), CKPT_HDR_FILE_DESC);
 	if (!h)
@@ -283,6 +284,17 @@ static int checkpoint_file_desc(struct ckpt_ctx *ctx,
 	}
 
 	/*
+	 * TODO: Implement c/r of fowner and f_sigio.  Should be
+	 * trivial, but for now we just refuse its checkpoint
+	 */
+	pid = f_getown(file);
+	if (pid) {
+		ret = -EBUSY;
+		ckpt_err(ctx, ret, "%(T)fd %d has an owner (%d)\n", fd);
+		goto out;
+	}
+
+	/*
 	 * if seen first time, this will add 'file' to the objhash, keep
 	 * a reference to it, dump its state while at it.
 	 */