Skip to contentSkip to conversation

kernel/rcutree.h:301: sorry, unimplemented: inlining failed in call to 'rcu_bootup_announce': function body not available

kernel Paul E. McKenney 4 participants 6 messages Dec 18, 2009

lore
Share & tools
lore
#0 lore raw

Hello, Greg,

Could you please consider the following commit for 2.6.32-stable? It fixes a build error that some people are seeing.

Thanx, Paul

dbe01350fa8ce0c11948ab7d6be71a4d901be151 rcu: Remove inline from forward-referenced functions

----- Forwarded message from "Mr. James W. Laferriere" <[email protected]> -----

Date: Fri, 18 Dec 2009 10:05:46 -0900 (AKST)
From: "Mr. James W. Laferriere" <[email protected]>
To: "Paul E. McKenney" <[email protected]>
cc: Américo Wang <[email protected]>,
Linux Kernel Maillist <[email protected]>
Subject: Re: [kernel] Re: kernel/rcutree.h:301: sorry, unimplemented: inlining
failed in call to 'rcu_bootup_announce': function body not available

Hello Paul ,

Quoted 149 lines · Paul E. McKenney
Quoted 135 lines · Mr. James W. Laferriere
Quoted 122 lines · Paul E. McKenney
Quoted 113 lines · Mr. James W. Laferriere
Quoted 91 lines · Paul E. McKenney
Quoted 48 lines · Américo Wang
Quoted 38 lines · Mr. James W. Laferriere

       Hello All ,

 gcc -Wp,-MD,kernel/.rcutree.o.d  -nostdinc -isystem /usr/lib/gcc/i486-slackware-linux/3.4.6/include -Iinclude -I/usr/src/linux-2.6.32.1/arch/x86/include -include include/linux/autoconf.h

(quoted diff) +0 -14
-D__KERNEL__ -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs
-fno-strict-aliasing -fno-common 
-Werror-implicit-function-declaration
-Wno-format-security -fno-delete-null-pointer-checks -O2 -m32
-msoft-float
-mregparm=3 -freg-struct-return -mpreferred-stack-boundary=2
-fno-unit-at-a-time -march=i686 -ffreestanding -DCONFIG_AS_CFI=1 
-pipe
-Wno-sign-compare -fno-asynchronous-unwind-tables -mno-sse -mno-mmx
-mno-sse2 -mno-3dnow -fno-omit-frame-pointer
-fno-optimize-sibling-calls
-g
-Wdeclaration-after-statement   -D"KBUILD_STR(s)=#s"
-D"KBUILD_BASENAME=KBUILD_STR(rcutree)"

 -D"KBUILD_MODNAME=KBUILD_STR(rcutree)" -c -o kernel/rcutree.o kernel/rcutree.c
kernel/rcutree.c: In function `__rcu_init':
kernel/rcutree.h:301: sorry, unimplemented: inlining failed in call to
'rcu_bootup_announce': function body not available kernel/rcutree.c:1740: sorry, unimplemented: called from here make[1]: *** [kernel/rcutree.o] Error 1
make: *** [kernel] Error 2

       There is no way ,  thru the 'make *config' methods to disable this
broken stuff ,  So How may I get past this brokeness ? And looking the posts for the 2.6.32-pre/rc the old rcu has
been
trashed completely .  So I am not able to even try using that .

Quoted 5 lines

       Would someone please shed some light on this .  I really need the
updates for the Fusion/mpt driver & the changes in the /md/ tree as well
.

Hmm, I see the problem, but not sure how to fix it...

Quoted 4 lines

Paul, why do we have #include "rcutree_plugin.h" at the bottom of rcutree.c? This looks strange for me...

How about moving it up? At least just move upper to rcu_init().

Could you please apply commit #dbe01350fa8ce0c11948ab7d6be71a4d901be151 from Linus's git tree? Corresponding diff attached.

Thanx, Paul

------------------------------------------------------------------------

kernel/rcutree.h +1 -1
index c1891c3..ddb79ec 100644
@@ -301,7 +301,7 @@ DECLARE_PER_CPU(struct rcu_data, 
 rcu_preempt_data);
 #else /* #ifdef RCU_TREE_NONCORE */
 
 /* Forward declarations for rcutree_plugin.h */
-static inline void rcu_bootup_announce(void);
+static void rcu_bootup_announce(void);
 long rcu_batches_completed(void);
 static void rcu_preempt_note_context_switch(int cpu);

static int rcu_preempted_readers(struct rcu_node *rnp);

kernel/rcutree_plugin.h +1 -1
index ef2a58c..c03edf7 100644
@@ -33,7 +33,7 @@ DEFINE_PER_CPU(struct rcu_data, rcu_preempt_data);
 /*
 * Tell them what RCU they are running.
 */
-static inline void rcu_bootup_announce(void)
+static void rcu_bootup_announce(void)
 {
 	printk(KERN_INFO
 	       "Experimental preemptable hierarchical RCU 

implementation.\n");

kernel/rcutree_plugin.h void exit_rcu(void) · line 487

Quoted 8 lines
kernel/rcutree_plugin.h +1 -1
@@ -481,7 +481,7 @@ void exit_rcu(void)
 /*
 * Tell them what RCU they are running.
 */
-static inline void rcu_bootup_announce(void)
+static void rcu_bootup_announce(void)
 {
 	printk(KERN_INFO "Hierarchical RCU implementation.\n");
 }

Thank you & Americo for responding .

Patch applied & same error as far as I can tell . did

make mrproper
cp ../old.config .config (same as in previous email)
make oldconfig
( time make V=1 KBUILD_VERBOSE=1 INSTALL_PATH=/boot clean all install
modules_install ) >../linux-2.6.32.1d.log 2>&1
error'd (See below) ...

Quoted 2 lines

If there is any further info I can provide or something I can do to provide , Please request it .

Hmmm.... Yes. Could you please execute the following command from the top-level directory of your patched kernel source tree?

grep rcu_bootup_announce kernel/rcu*

Quoted 8 lines

I would expect the following output:

	kernel/rcutree.c:       rcu_bootup_announce();
	kernel/rcutree.h:static void rcu_bootup_announce(void);
	kernel/rcutree_plugin.h:static void __init rcu_bootup_announce(void)
	kernel/rcutree_plugin.h:static void __init rcu_bootup_announce(void)

							Thanx, Paul

This is with your patch applied on top of linux-2.6.32.1.tar.gz no other patches or additions .

Quoted 12 lines

OK , it looks like I wandered right by the first file ie:
'kernel/rcutree.h' so I need to patch that as well . Doing this by hand as
the offending system is not online and all I have is serial console access
presently .
But , the last two you've changed to 'void __init' instead of just
'void'
.
Do you want me to add those changes to the file
'kernel/rcutree_plugin.h'
as well ?

Quoted 2 lines

We were starting from different places. The important thing is to remove the "inline" declarations.

Ok , That was the very reason for why I asked this question .

Quoted 6 lines
Quoted 3 lines
# grep rcu_bootup_announce kernel/rcu*
kernel/rcutree.c:       rcu_bootup_announce();
kernel/rcutree.h:static inline void rcu_bootup_announce(void);

The above "inline" needs to go as well. (Ah, as you noted above.) Strange -- this change -was- in the patch I sent.

I also mentioned not seeing the first file in the patch so I had to go
back & edit it also .

Quoted 6 lines
Quoted 2 lines

kernel/rcutree_plugin.h:static void rcu_bootup_announce(void) kernel/rcutree_plugin.h:static void rcu_bootup_announce(void)

Does removing all three "inline" directives fix your build?

Thanx, Paul

Yes , Removing the 'inline's from all three locations gets me past the
rcu error issue . But now I am into errors in the code that I was really interested in getting 2.6.32 for are now error'ng . I'll place those errors onto the list & other authors in another email .

Thank you , for your efforts & the success . JimL

Signature · 8 lines
+------------------------------------------------------------------+
| James   W.   Laferriere | System    Techniques | Give me VMS     |
| Network&System Engineer | 3237     Holden Road |  Give me Linux  |
| [email protected] | Fairbanks, AK. 99709 |   only  on  AXP |
+------------------------------------------------------------------+


----- End forwarded message -----
#1 lore raw
Quoted 8 lines · Paul E. McKenney

Hello, Greg,

Could you please consider the following commit for 2.6.32-stable? It fixes a build error that some people are seeing.

Thanx, Paul

dbe01350fa8ce0c11948ab7d6be71a4d901be151 rcu: Remove inline from forward-referenced functions

I'm guessing that you don't pay attention to the "now applied to the staging..." emails that I send out when I apply patches to different trees. This patch is already queued up for the 2.6.32.2 release which will happen in a few hours.

{sigh}

greg k-h

#2 lore raw
Quoted 6 lines · Greg KH
Quoted 5 lines · Paul E. McKenney

Hello, Greg,

Could you please consider the following commit for 2.6.32-stable? It fixes a build error that some people are seeing.

Quoted 6 lines
Quoted 3 lines

Thanx, Paul

dbe01350fa8ce0c11948ab7d6be71a4d901be151 rcu: Remove inline from forward-referenced functions

I'm guessing that you don't pay attention to the "now applied to the staging..." emails that I send out when I apply patches to different

s/staging/stable/

#3 lore raw
In reply to Greg KH

Hello Greg ,

Quoted 10 lines · Greg KH
Quoted 8 lines · Paul E. McKenney

Hello, Greg,

Could you please consider the following commit for 2.6.32-stable? It fixes a build error that some people are seeing.

Thanx, Paul

dbe01350fa8ce0c11948ab7d6be71a4d901be151 rcu: Remove inline from forward-referenced functions

Quoted 8 lines

I'm guessing that you don't pay attention to the "now applied to the staging..." emails that I send out when I apply patches to different trees. This patch is already queued up for the 2.6.32.2 release which will happen in a few hours.

{sigh}

greg k-h

Fyi , There is another driver that has this issue as well ,
fusion/mptsas , has a 'inline' in drivers/message/fusion/mptsas.c at line 105 that causes compile time failure in the same vein .
See email to linux-scsi , Subject: linux-2.6.32.1 drivers/message/fusion/mptsas.c:106: sorry, unimplemented: inlining failed in call to 'mptsas_set_rphy': function body not available I am also having 'ld' time troubles with
drivers/gpu/drm/radeon/radeon_test.c:45: undefined reference to `__udivdi3' and have sent emails to the appropriate lists & maintainers(I hope) .

Don't know if any of these would/should hold up the push of 32.2 or not
.
Hth , JimL

Signature · 5 lines
+------------------------------------------------------------------+
| James   W.   Laferriere | System    Techniques | Give me VMS     |
| Network&System Engineer | 3237     Holden Road |  Give me Linux  |
| [email protected] | Fairbanks, AK. 99709 |   only  on  AXP |
+------------------------------------------------------------------+
#4 lore raw
Quoted 4 lines · Mr. James W. Laferriere

Fyi , There is another driver that has this issue as well ,
fusion/mptsas , has a 'inline' in drivers/message/fusion/mptsas.c at line
105 that causes compile time failure in the same vein .
See email to linux-scsi , Subject: linux-2.6.32.1 drivers/message/fusion/mptsas.c:106: sorry, unimplemented: inlining failed in call to 'mptsas_set_rphy': function body not available

Is there a patch in Linus's tree that solves this problem already? If so, what is the git commit id of it?

Quoted 3 lines

I am also having 'ld' time troubles with
drivers/gpu/drm/radeon/radeon_test.c:45: undefined reference to `__udivdi3' and have sent emails to the appropriate lists & maintainers(I hope) .

When that gets fixed, let the [email protected] address know the git commit id that needs to be applied.

Quoted 1 line

Don't know if any of these would/should hold up the push of 32.2 or not

Don't worry, it will not :)

thanks,

greg k-h

#5 lore raw
In reply to Greg KH
Quoted 8 lines · Greg KH
Quoted 7 lines · Paul E. McKenney

Hello, Greg,

Could you please consider the following commit for 2.6.32-stable? It fixes a build error that some people are seeing.

Thanx, Paul

Quoted 8 lines
Quoted 1 line

dbe01350fa8ce0c11948ab7d6be71a4d901be151 rcu: Remove inline from forward-referenced functions

I'm guessing that you don't pay attention to the "now applied to the staging..." emails that I send out when I apply patches to different trees. This patch is already queued up for the 2.6.32.2 release which will happen in a few hours.

{sigh}

Color me oblivious, and apologies for the noise!

Thanx, Paul