Skip to contentSkip to conversation

get_maintainers.pl & acer-wmi

DISCUSSION Carlos Corbacho 2 participants 2 messages Dec 23, 2009

lore
Share & tools
lore
#0 lore raw

Hi Joe,

We're getting some odd results out of get_maintainers.pl for acer-wmi.

ccorbacho@pacifica:~/src/kernel/linux-2.6$ perl scripts/get_maintainer.pl -f 
drivers/platform/x86/acer-wmi.c

Carlos Corbacho <[email protected]>
John W. Linville <[email protected]>
Len Brown <[email protected]>
Alan Jenkins <[email protected]>
Johannes Berg <[email protected]>
[email protected]

Which is odd, as I'm the only maintainer of acer-wmi, so why does it pull in all the other names above?

-Carlos

Signature · 3 lines
E-Mail: [email protected]
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
#1 lore raw
Quoted 1 line · Carlos Corbacho

Hi Joe,

Hi Carlos.

Quoted 12 lines

We're getting some odd results out of get_maintainers.pl for acer-wmi.

ccorbacho@pacifica:~/src/kernel/linux-2.6$ perl scripts/get_maintainer.pl -f 
drivers/platform/x86/acer-wmi.c

Carlos Corbacho <[email protected]>
John W. Linville <[email protected]>
Len Brown <[email protected]>
Alan Jenkins <[email protected]>
Johannes Berg <[email protected]>
[email protected]

Quoted 2 lines

Which is odd, as I'm the only maintainer of acer-wmi, so why does it pull in all the other names above?

You have git installed.

get_maintainer.pl by default uses git commit history and searches for signatures.

These are people that have added "acked-by", "signed-off-by", "reviewed-by" or any other "by" lines in the git commits.

$ ./scripts/get_maintainer.pl -f drivers/platform/x86/acer-wmi.c
Carlos Corbacho <[email protected]>
John W. Linville <[email protected]>
Len Brown <[email protected]>
Alan Jenkins <[email protected]>
Johannes Berg <[email protected]>
[email protected]

If you want to not use git history, add --nogit

$ ./scripts/get_maintainer.pl -f --nogit drivers/platform/x86/acer-wmi.c
Carlos Corbacho <[email protected]>
[email protected]

With the latest version of get_maintainer, you could add --rolestats and see how many of the commits were signed by each person.

$ ./scripts/get_maintainer.pl -f --rolestats drivers/platform/x86/acer-wmi.c
Carlos Corbacho <[email protected]> (maintainer:ACER WMI LAPTOP E...,commit_signer:4/11=36%)
John W. Linville <[email protected]> (commit_signer:5/11=45%)
Len Brown <[email protected]> (commit_signer:4/11=36%)
Alan Jenkins <[email protected]> (commit_signer:3/11=27%)
Johannes Berg <[email protected]> (commit_signer:2/11=18%)
[email protected] (open list)