tun: use tun_sk instead container_of
Subsystems (3)
PATCH 1/1 tun: use tun_sk instead container_of
Using macro tun_sk is more clear and shorter. However tun.c has tun_sk, but doesn't use it.
Signed-off-by Vitaliy Gusev <[email protected]>
--- drivers/net/tun.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/tun.c +3 -3
@@ -849,13 +849,13 @@ static void tun_sock_write_space(struct sock *sk)if (sk->sk_sleep &&waitqueue_active (sk->sk_sleep))wake_up_interruptible_sync (sk->sk_sleep); - tun = container_of(sk, struct tun_sock, sk)->tun; + tun =tun_sk (sk)->tun;kill_fasync (&tun->fasync,SIGIO ,POLL_OUT ); }static void tun_sock_destruct (struct sock *sk) { - free_netdev(container_of(sk, struct tun_sock, sk)->tun->dev); +free_netdev (tun_sk (sk)->tun->dev); }static struct proto tun_proto = {
@@ -990,7 +990,7 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr) sk->sk_write_space = tun_sock_write_space; sk->sk_sndbuf =INT_MAX ; - container_of(sk, struct tun_sock, sk)->tun = tun; +tun_sk (sk)->tun = tun;security_tun_dev_post_create (sk);
From: Vitaliy Gusev <[email protected]>
Date: Fri, 25 Dec 2009 20:17:43 +0300
Quoted 4 lines
Using macro
tun_skis more clear and shorter. Howevertun.chastun_sk, but doesn't use it.Signed-off-by Vitaliy Gusev <[email protected]>
Applied, thanks.