off by one bug

PATCH New Dan Carpenter 1 participant 1 message Jan 3, 2010 Multifunction devices (MFD)

lore

Share & tools

lore

Dan Carpenter

author

2010-01-03 12:16 UTC #0 lore raw

PATCH 1/1 off by one bug

if irq == PCF50633_NUM_IRQ that puts us past the end of the array.

Signed-off-by Dan Carpenter <[email protected]>

drivers/mfd/pcf50633-core.c +2 -2

@@ -217,7 +217,7 @@ static struct attribute_group pcf_attr_g
 int pcf50633_register_irq(struct pcf50633 *pcf, int irq,
 			void (*handler) (int, void *), void *data)
 {
-	if (irq < 0 || irq > PCF50633_NUM_IRQ || !handler)
+	if (irq < 0 || irq >= PCF50633_NUM_IRQ || !handler)
 		return -EINVAL;
 
 	if (WARN_ON(pcf->irq_handler[irq].handler))

@@ -234,7 +234,7 @@ EXPORT_SYMBOL_GPL(pcf50633_register_irq)
 
 int pcf50633_free_irq(struct pcf50633 *pcf, int irq)
 {
-	if (irq < 0 || irq > PCF50633_NUM_IRQ)
+	if (irq < 0 || irq >= PCF50633_NUM_IRQ)
 		return -EINVAL;
 
 	mutex_lock(&pcf->lock);