precedence bug in ieee80211_wx_get_encode_ext()

PATCH New Dan Carpenter 1 participant 1 message Jan 3, 2010 Staging

lore

Share & tools

lore

Dan Carpenter

author

2010-01-03 15:24 UTC #0 lore raw

PATCH 1/1 precedence bug in ieee80211_wx_get_encode_ext()

The original test is always false because ! has precendence over &.

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c +1 -1

@@ -718,7 +718,7 @@ int ieee80211_wx_get_encode_ext(struct i
 	} else
 		idx = ieee->tx_keyidx;
 
-	if (!ext->ext_flags & IW_ENCODE_EXT_GROUP_KEY &&
+	if (!(ext->ext_flags & IW_ENCODE_EXT_GROUP_KEY) &&
 	    ext->alg != IW_ENCODE_ALG_WEP)
 		if (idx != 0 || ieee->iw_mode != IW_MODE_INFRA)
 			return -EINVAL;